From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58A93A034F for ; Tue, 11 Jan 2022 01:32:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 493954116A; Tue, 11 Jan 2022 01:32:03 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 09CDE40041; Tue, 11 Jan 2022 01:31:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641861120; x=1673397120; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=18c1N1IGkAxF/wXpJ1z1mu8d4hqLRIQmwKNikw8KpYw=; b=eWLPmuIewQtO1kV0bWjxqc9w2gMRqlmTQjFdcqO2hKrzx/oyC/lTL7KK 8KBXK3BZUdAS8S/MkSR04cpLSJ8zJo6L9FjfybvBvTVJpwxDSTeH5jWbY nDrvLCLsblliKlGmaztAO9uWNHfLqkbyJ3wcCg7dwCnnkvlLQMD7MNdId isI4UUEiFI8OXYJUcvlick3KoyhpqpS1Tl/Pc+kXLMGi19xwmwNlF4VXJ k+3yS/CyUejoAfKpru/OKjYOM6gXFHzcmcj27yk/BJ/BUJ82yBwRbd/dq lBph33jwLn2UNEwL+ib0oeIHlifw0dDKgCBNGiHcRjAzjKOnlD3V0wJWT w==; X-IronPort-AV: E=McAfee;i="6200,9189,10223"; a="224064118" X-IronPort-AV: E=Sophos;i="5.88,278,1635231600"; d="scan'208";a="224064118" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2022 16:31:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,278,1635231600"; d="scan'208";a="472267815" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga003.jf.intel.com with ESMTP; 10 Jan 2022 16:31:56 -0800 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 10 Jan 2022 16:31:56 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 11 Jan 2022 08:31:54 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2308.020; Tue, 11 Jan 2022 08:31:53 +0800 From: "Zhang, Qi Z" To: "Wang, Haiyue" , "Rong, Leyi" , Bin Zheng , "dev@dpdk.org" CC: "liangma@liangbit.com" , "stable@dpdk.org" , "jia.guo@intel.com" Subject: RE: [PATCH v3] net/ixgbe: add vector Rx parameter check Thread-Topic: [PATCH v3] net/ixgbe: add vector Rx parameter check Thread-Index: AQHX7Z8mieMuiJpX7Um/zja3oivqJqwvOmMAgAHc1gCALBK9EA== Date: Tue, 11 Jan 2022 00:31:53 +0000 Message-ID: <65a377590faa4d3abf0edb6eda78bebe@intel.com> References: <20211202092001.1830481-2-zhengbin.89740@bytedance.com> <20211210082209.4102794-1-zhengbin.89740@bytedance.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Wang, Haiyue > Sent: Tuesday, December 14, 2021 3:29 PM > To: Rong, Leyi ; Bin Zheng > ; dev@dpdk.org > Cc: liangma@liangbit.com; stable@dpdk.org; jia.guo@intel.com > Subject: RE: [PATCH v3] net/ixgbe: add vector Rx parameter check >=20 > > -----Original Message----- > > From: Rong, Leyi > > Sent: Monday, December 13, 2021 11:03 > > To: Bin Zheng ; dev@dpdk.org > > Cc: Wang, Haiyue ; liangma@liangbit.com; > > stable@dpdk.org; jia.guo@intel.com > > Subject: RE: [PATCH v3] net/ixgbe: add vector Rx parameter check > > > > > > > -----Original Message----- > > > From: Bin Zheng > > > Sent: Friday, December 10, 2021 4:22 PM > > > To: dev@dpdk.org > > > Cc: Wang, Haiyue ; liangma@liangbit.com; > > > stable@dpdk.org; Rong, Leyi ; Bin Zheng > > > ; jia.guo@intel.com > > > Subject: [PATCH v3] net/ixgbe: add vector Rx parameter check > > > > > > Under the circumstance that `rx_tail` wrap back to zero and the > > > advance speed of `rx_tail` is greater than `rxrearm_start`, > > > `rx_tail` will catch up with `rxrearm_start` and surpass it. > > > This may cause some mbufs be reused by application. > > > > > > So we need to make some restrictions to ensure that `rx_tail` will > > > not exceed `rxrearm_start`. > > > > > > e.g. > > > > > > RDH: 972 RDT: 991 rxrearm_nb: 991 rxrearm_start: 992 rx_tail: 959 > > > RDH: 1004 RDT: 1023 rxrearm_nb: 991 rxrearm_start: 0 rx_tail: 991 > > > RDH: 12 RDT: 31 rxrearm_nb: 991 rxrearm_start: 32 rx_tail: 1023 > > > RDH: 31 RDT: 63 rxrearm_nb: 960 rxrearm_start: 64 rx_tail: 0 > > > RDH: 95 RDT: 95 rxrearm_nb: 1016 rxrearm_start: 96 rx_tail: 88 > > > RDH: 95 RDT: 127 rxrearm_nb: 991 rxrearm_start: 128 rx_tail: 95 ... > > > RDH: 908 RDT: 927 rxrearm_nb: 991 rxrearm_start: 928 rx_tail: 895 > > > RDH: 940 RDT: 959 rxrearm_nb: 991 rxrearm_start: 960 rx_tail: 927 > > > RDH: 980 RDT: 991 rxrearm_nb: 991 rxrearm_start: 992 rx_tail: 959 > > > RDH: 991 RDT: 991 rxrearm_nb: 1026 rxrearm_start: 992 rx_tail: 994 > > > > > > when `rx_tail` catches up with `rxrearm_start`, > > > 2(994 - 992) mbufs be reused by application ! > > > > > > Bugzilla ID: 882 > > > Fixes: 5a3cca342417 ("net/ixgbe: fix vector Rx") > > > Cc: jia.guo@intel.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Bin Zheng > > > --- > > > drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > >=20 >=20 > > > > Acked-by: Leyi Rong >=20 > Reviewed-by: Haiyue Wang Applied to dpdk-next-net-intel. Thanks Qi