From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0306A42672 for ; Fri, 29 Sep 2023 16:41:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E6C3140EE1; Fri, 29 Sep 2023 16:41:55 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2040.outbound.protection.outlook.com [40.107.102.40]) by mails.dpdk.org (Postfix) with ESMTP id 5F611402AA; Fri, 29 Sep 2023 16:41:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BjWVijND3/wz1DymV+Xsf07gXIXi40D4leyf5eSU8lA8Zy8l62cG2GVijzOQ8XoxJauPls4A5y/VQYD18gaFrORnCAnpbDm7aStTsYR2KWHBFtmHE7Ip83iZldmpXYQFWrTvQIMnsD1vM9NNHccjBKAv5u34mgJhUqJnGjIURg+nmbrYCdEv9RBAAwLOO5YdbkwdjPxiUBmisIUzA3MmtJ5JpWYnk5bUsZU1tnI4rqYYbIU9AFJTZ1YMQmaRsMh6nARWikSy6783weIXWkWXhKUQCixEC/LDJ5PHApPTGQ/eMb5uIgzIQRpKETrpc0xm041V60X3GIByNBnQDzGfyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MTOzTcMH1i0J4n+Dah1u0NnYTZmvvE91QrHQ+BzrBG0=; b=l0nBIo8IPO38F5q2vnZecFNalDIS0mJ3L65pdAGoffoaZs872gAjco6cnPhi6I9DxbdVjdJNlJH09B0IRmQt/lWSLsH08wjZ+2N1QeRZ/IqTqKZUu+lh/GdVQE5K+lCfp+8zQMePnwgY2HTtOXSBQVE4Aq4Bt8POa1jwKhZJ1SOz5J5B4/sviKEVhHPgMZoH8PT7/LFFXs4Lad29HQ6gHkZL4lyFQ16J46CM4ezBmCmdEPwLe8cTEoaPJrqusLGz7dg/FH+pOCXzwyoSSpiOfGxApyvcqeKAsLSc5pR3L6G/Ur7QzRHTqH0F7TAhu3EBUAj5bX7En9K5g0PvRqi6Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MTOzTcMH1i0J4n+Dah1u0NnYTZmvvE91QrHQ+BzrBG0=; b=LVfMcrgdB5oh5yc3pIVzb2WHCNOZ/uLZHjf4zBm3Q/ckill6EDg/CfrLU3wFvSJi2/oFSXiSEpHN96Gx45dvk1JepMWKYz4GWPz+Z92fXK0Cpz+trV7OfUajqsTJY14cDplhs6/abDFJ00CS4JRBepE9hHzWuX/uI2/9gwSrCtQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH0PR12MB5121.namprd12.prod.outlook.com (2603:10b6:610:bc::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.26; Fri, 29 Sep 2023 14:41:51 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6838.024; Fri, 29 Sep 2023 14:41:51 +0000 Message-ID: <65b25f36-32fd-45cd-8f84-2058e941c361@amd.com> Date: Fri, 29 Sep 2023 15:41:43 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] net/memif: fix segfault with large burst size Content-Language: en-US To: Joyce Kong , Jakub Grajciar , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Ruifeng Wang Cc: dev@dpdk.org, nd@arm.com, stable@dpdk.org, Feifei Wang References: <20230904071041.3403495-1-joyce.kong@arm.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230904071041.3403495-1-joyce.kong@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0554.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH0PR12MB5121:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d6111f1-5542-472e-951c-08dbc0fa378c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F9hCfoVgpQakOWww5NmsfGoLF6j2oFTT5CGHERgQH+cUPjBjTy0rEvmpeiVtJs16s1DDtIlfgMTHZfbotmjCAPLspCE35Zhwrjwjk95iqkDT48QYtPEpAULhL8P2LcESlrVafrGit+UEkTn3jDT+5wUnmk08HIWTTRITOvuVnLmJwcPNtYQT5giCU7E9JTjC4gENP5D+T4Yi6/wySUH5yj0SJ9r2hJkFPWiz1CfvnCSJLxiNS0eOw8vo0W/HjC6reSDsH98ADHbapIyS63rQK2ixHwKUsRmRfLrtpKq33JrpZm1koJYDqHxrkOvisrXiRPfPE5HAACITI1qLZyfCFNY6CM3xnuLAjbmvKzyGrS9WHGHytuRfEk+iSBFdKBEGL4Zkhh1x2vh8lKXV+cfBT+K+eM/Yhq4yPHPfCEAWCf78zfWEG2tMGYDFO3DyjXe/DRcthj7gZBWjz8OskZ6SilCbA30tXw/XkPcyypbgo6pXNdayHf4+4fjsncOfQylyRFJIZrCNAE/E1PKgo1/JoKmAjKf/0IjLSn1/10XIm8h2DNJA7plhed7E0tn4AscakN5hi+ekitbviNIRRpIHCDT5+qdDz3gvkbnPQQnuiUNHioMu1xXnuC47d2Nazz+7JYfa1qMSAVZUX5NsBmy1Zw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(366004)(136003)(376002)(346002)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(6512007)(6666004)(6506007)(6486002)(53546011)(26005)(2616005)(66556008)(31696002)(110136005)(86362001)(478600001)(66476007)(38100700002)(83380400001)(2906002)(66946007)(8936002)(8676002)(4326008)(36756003)(41300700001)(316002)(44832011)(5660300002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUVOaUxVMHVka1J3WVNRYURlS3RtZ3Z2czRiRjhIRGNzekxXR01xSVdsbjBT?= =?utf-8?B?UmgrQXhhcFpBY1dTU0M0U3ZTYWM0NTgyT3NmaGlCVWxlNDQ0b2pKc2o3UTRI?= =?utf-8?B?UFhLWjhKWUJMV2wrbWtHSkI4bWpHT3ZhR0N4YklhcURJNWVpb0t4akRZVU1K?= =?utf-8?B?Y3hJUFI2WnlHNTB3UXowTXhKeGJpZm44ZFRVOEpJWTFFVjE0T2VycjBXbTNM?= =?utf-8?B?QzFXa1RQY0xLSkZjNEpBMnNEazA1NHBHdDYwYm1BaDZ5VjJyallNYVNtdnRW?= =?utf-8?B?T3M1eDRZejR0NnF5UmN3L2o0YkQ3UGZBcGpiMi8yRy9nRmcyUUpsQVFwOVhH?= =?utf-8?B?OUh6WEZFak5abmRmdmhLZTJhQzZvY1oyck41TUkweFB4di93a1ZiMlhyTGI5?= =?utf-8?B?dFk2Vk5GOGNOVmdEUUdOcUlXelNWQ3pLbmNRNCtVbVpDYnVSRzdiSG5zR0Vu?= =?utf-8?B?UkpOaXBIUWFjcUhWVElrbm5vZnFVM2tRcEhQaGh2ZTdUYlloajkwRXNwcmNi?= =?utf-8?B?L1U3S1VTVks5Q2Y0UGkrcExKZmJVcjRPcTNFMldGa2ZROGJJa21kalorWlNI?= =?utf-8?B?d01UMHl1TFdkc0M5MjFVRGpUMkY2WThBS0sramU4clVZMWIvSllKQ2RhcmdE?= =?utf-8?B?T1Z1N0Q2VWI5QWxlb3o1Y2ZESmpQdTdSa1NRKzJ5TkVGaVZYaXhKZkoxTjRl?= =?utf-8?B?N3RoNVJoU0l4WUZpeFlBUHhtem9BOGw0VjcxUjkxdkdiZStvd1Q2eVdERW5X?= =?utf-8?B?UkdQc0poQVFKVWFNNlBVR0Q1UkdDMnFpTHBVRy9GSCtlZ2FnN2tnS0lYYTZB?= =?utf-8?B?Ui8rMGViVXJRaU1wVk9wMHJTUUtpT2lxVGlLWml6T01rSEpYL0Uydmx3aXdT?= =?utf-8?B?Y04yZzdKQis1ZW8xUDc2UWJQa0JldW1xVWVkY010Ykx3L25ORjAzYWlTd1B0?= =?utf-8?B?a1hQK0NETkdkeFNvNWNTK1d1TjJvMzhKemcwZ3FqcjVjRDNhZm1QQ2F1NFU0?= =?utf-8?B?SEpOOW8vdGtjcHI3TDRJNlZkRjlLdERoYTdDNUdWSzZEZ1dBZ1Y1UWlDTUIr?= =?utf-8?B?eFhZczh1Z3JQMElMZlJXRDFhTnM1eUIxbTh6eWJueFhJQ3c5bWxJU0pvWEtP?= =?utf-8?B?Z3d0M2llbndvVHVjUXpWRC9EUXVDT3R1QmhYU0hoWC93a3NoSnlWMTFJTk90?= =?utf-8?B?aGR6OEkxUWx0emlzTVR0cWJubnRUZkRoMDlEVENwQU0rOFJmQk4wVUlzTURw?= =?utf-8?B?YllCSnNrN2lsdGowM2tvWldtUjZCZDlINFNIVXRKbUZLVUdzaW4yNENDcHU3?= =?utf-8?B?bW9VTE83YkNFMU4wbjloZ0VmQ1liUFBiQm03bEtNU1paaG5yUXU1cDVMZjNB?= =?utf-8?B?d2tOMzcwaTB5NFN3VmNCTE8rVlYzRUdPZzVRN0VxVTl6Z3A2eW9sZ2tzcVc5?= =?utf-8?B?YXowQVR1OU8rT2VuVEpuTjc4c0RsWW9wNkNZazR6VXFER2dYODFoS1RzcDVX?= =?utf-8?B?MFNIK0pTVEFIVk90UEw0ejhFMWtiRlNRZVppS3BKa2g3clo2VnNmaElFMmsv?= =?utf-8?B?RGZNanNXK3gyRThBUS9pa0ZMZkpsUWtseEdMUjFFc2tEa0VmR0JoR2FsWDhh?= =?utf-8?B?bzYvK3NveDhaejZWNkJVeHFxLzkraGRkSU4wK3E5T2xwSDFIaUtjckptVXVn?= =?utf-8?B?MElaMm1hMVhoWXZ0em1hQ09pWC9oSWtUaUc5S0Rta1dDZGs0MzUxV2E0blNi?= =?utf-8?B?WTVqMmJvamoydXcxczN4bGFPTHJVanZqdFhRQXBLbXpSeEFudUE0YnJXZk5u?= =?utf-8?B?QXAyUng2Y1QycldkWDBrUUJldHhxd2J2MzZCWnpoK1hscm9oRTRzMTdlUk5V?= =?utf-8?B?TS9YSlQrSmpBM3BCSTBnWmdwUGZTZ3lnQk5qMDhVTE96T0tyZTlEMEZTWFdl?= =?utf-8?B?S0xEYXdrS1RQUFMzaUtxYWovbit4QWJsUjVwWm0rRk4wWHNPSFNIakZNY1I0?= =?utf-8?B?YlhqTjY3RDZGR2JScURzVkxxMlRrUE5xa3ZVWjNhL0xTMHhjazdVWkJCMUhO?= =?utf-8?B?ZkRwZ1dGOGtpTDlCYytmRG5qUjArYnNiN0pObFRuc1FjUVdnSFNydzMzWit5?= =?utf-8?Q?AlMJsbnmKxzvBJXtdFmaHBDX4?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d6111f1-5542-472e-951c-08dbc0fa378c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2023 14:41:51.2913 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0F+pXkcHDYNxPvBwc29HnE5vhWuK+P+UKxjxBRve0otUTzhBfX46tQLSQDl864v/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5121 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 9/4/2023 8:10 AM, Joyce Kong wrote: > There will be a segfault when Rx burst size is greater than > MAX_PKT_BURST of memif. Fix the issue by correcting the > wrong mbuf index in eth_memif_rx, which results in accessing > invalid memory address. > > Bugzilla ID: 1273 > Fixes: aa17df860891 ("net/memif: add a Rx fast path") > Cc: stable@dpdk.org > > Signed-off-by: Joyce Kong > Reviewed-by: Feifei Wang > Reviewed-by: Ruifeng Wang > Hi Joyce, good catch. Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks. For record, if nb_pkts > MAX_PKT_BURST, memif buffer consumed in chunks of MAX_PKT_BURST mbufs, next chunk consumption starts with 'goto next_bulk' call. For each chunk, MAX_PKT_BURST mbufs allocated and filled, they are accessed by 'n_rx_pkts' index, but 'n_rx_pkts' is overall received mbuf number, so it shouldn't be used as index for that chunk, but 'rx_pkts' should be used which is reset at the beginning of the chunk processing. For the first chunk using 'n_rx_pkts' or 'rx_pkts' are same, that explains how issue lived till now, as commit log mentions issue can be observed when nb_pkts > MAX_PKT_BURST.