From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 5767B1E4F1; Tue, 12 Jun 2018 10:38:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2018 01:38:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,213,1526367600"; d="scan'208";a="66301328" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.106]) ([163.33.230.106]) by orsmga002.jf.intel.com with ESMTP; 12 Jun 2018 01:38:28 -0700 To: David Marchand , dev@dpdk.org References: <1528359323-22885-1-git-send-email-david.marchand@6wind.com> Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, stable@dpdk.org From: Remy Horton Organization: Intel Shannon Limited Message-ID: <660a5233-0e54-3028-3a86-1ad167f4e937@intel.com> Date: Tue, 12 Jun 2018 09:38:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1528359323-22885-1-git-send-email-david.marchand@6wind.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH] app/testpmd: add sanity checks when retrieving xstats X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jun 2018 08:38:32 -0000 Was out of office, so only saw the patchset this morning. Missing fixlines (watch out for subject line wrap): Fixes: e2aae1c1ced9 ("ethdev: remove name from extended statistic fetch") Fixes: 0a5beecf466a ("ethdev: revert xstats by ID") Otherwise looks good to me. A case of implementation simplification turning into API assumption :( ..Remy On 07/06/2018 09:15, David Marchand wrote: [..] > Signed-off-by: David Marchand Acked-by: Remy Horton