From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8AB9DA0A04 for ; Tue, 19 Jan 2021 05:41:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84863140E71; Tue, 19 Jan 2021 05:41:34 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id EA5F9140E56; Tue, 19 Jan 2021 05:41:30 +0100 (CET) IronPort-SDR: cosp64waCGxiO1xtifjgEOpUPHTo0JYS0tqKcfI8pE/BonyzGmWg4ix9f9i1fBC6tJw/PXobR3 PcdC5nP+u0aA== X-IronPort-AV: E=McAfee;i="6000,8403,9868"; a="179026579" X-IronPort-AV: E=Sophos;i="5.79,357,1602572400"; d="scan'208";a="179026579" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 20:41:15 -0800 IronPort-SDR: 5XqLBwZqcnuk03IcqtDpp0o794V++MKaEBCjEO35P878uxlvyi4dk7in/8Y76Z4ptDHcSgVBv/ pMYvQA/6vX0A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,357,1602572400"; d="scan'208";a="402238000" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga002.fm.intel.com with ESMTP; 18 Jan 2021 20:41:14 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 18 Jan 2021 20:41:14 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 19 Jan 2021 12:41:12 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Tue, 19 Jan 2021 12:41:12 +0800 From: "Zhang, Qi Z" To: "Ding, Xuan" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA handling Thread-Index: AQHW7XW189uF90S/6UucEfrN+fXANaouTpBg//+JMgCAAIa4cA== Date: Tue, 19 Jan 2021 04:41:12 +0000 Message-ID: <66346f4e65be4d4cb48965dbbf710d9f@intel.com> References: <20210118081506.107794-1-xuan.ding@intel.com> <20210118082826.1261-1-xuan.ding@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA handling X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Ding, Xuan > Sent: Tuesday, January 19, 2021 12:35 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA handling >=20 > Hi Qi, >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Tuesday, January 19, 2021 11:45 AM > > To: Ding, Xuan ; Wu, Jingjing > > ; Xing, Beilei > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: RE: [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA > > handling > > > > > > > > > -----Original Message----- > > > From: Ding, Xuan > > > Sent: Monday, January 18, 2021 4:28 PM > > > To: Zhang, Qi Z ; Wu, Jingjing > > > ; Xing, Beilei > > > Cc: dev@dpdk.org; Ding, Xuan ; stable@dpdk.org > > > Subject: [PATCH v2] net/iavf: fix VIRTHCNL_OP_SET_RSS_HENA handling > > > > > > Allow error to be returned for VIRTCHNL_OP_SET_RSS_HENA when set > > > hena =3D > > 0. > > > Add warning that PF does not support hena =3D 0 now. > > > > Actually this is not a fix, it's a workaround to handle some defect in > > legacy kernel driver. > > So changed title and commit log as below: > > > > Title: workaround RSS cleanup failure handling > > > > Allow to ignore error returned from virtual channel command > > VIRTCHNL_OP_SET_RSS_HENA with hena =3D 0 due to some legacy > > kernel driver does not support this. Add warning message when > > this happen. > > > > > > > > Fixes: 95f2f0e9fc2a6("net/iavf: improve default RSS") > > > > The fix line should be removed. > > > > > Cc: stable@dpdk.org >=20 > Since fix line is removed, should CC to stable also be removed? Sometime we can still have CC stable to hint backport, even its not a fix. But for this patch, I think its not necessary, as the patch to enable hena= =3D0 belongs to this release, so no workaround need to backport, thanks for= the capture. > Thanks for your correction. >=20 > Regards, > Xuan >=20 > > > > > > Signed-off-by: Xuan Ding > > > > Acked by: Qi Zhang > > > > Applied to dpdk-next-net-intel. > > > > Thanks > > Qi >=20