* Re: [PATCH] sched: fix wrr parameter data type
[not found] ` <20250918085145.584fca13@hermes.local>
@ 2025-10-23 17:40 ` Thomas Monjalon
0 siblings, 0 replies; only message in thread
From: Thomas Monjalon @ 2025-10-23 17:40 UTC (permalink / raw)
To: Megha Ajmera; +Cc: dev, jasvinder.singh, Stephen Hemminger, stable
18/09/2025 17:51, Stephen Hemminger:
> On Thu, 18 Sep 2025 08:16:09 +0530
> Megha Ajmera <megha.ajmera@intel.com> wrote:
>
> > wrr tokens getting truncated to uint8_t in wrr_store function() due to
> > type mismatch. This patch changes the data type to uint16_t.
> >
> > Fixes: e16b06da0908 ("sched: remove WRR from strict priority TC queues")
> >
> > Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
> > Acked-by: Jasvinder Singh <Jasvinder.singh@intel.com>
>
> The pipe tokens are updated in grinder_wrr_store by:
>
> pipe->wrr_tokens[0] =
> (grinder->wrr_tokens[0] & grinder->wrr_mask[0]) >>
> RTE_SCHED_WRR_SHIFT;
>
> The token in rte_sched_grinder is uint16_t.
> The mask value in wrr_mask is either 0 or 0xffff.
> The shift is 3.
> Therefore the range of pipe tokens is 0xffff >> 3 = 1FFF
>
> The sched code is severely under commented and overly complex.
> The patch looks right.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Cc stable
Applied, thanks.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-10-23 17:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20250918024609.2027038-1-megha.ajmera@intel.com>
[not found] ` <20250918085145.584fca13@hermes.local>
2025-10-23 17:40 ` [PATCH] sched: fix wrr parameter data type Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).