From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Gregory Etelson <getelson@nvidia.com>, <dev@dpdk.org>
Cc: <matan@nvidia.com>, <rasland@nvidia.com>, <stable@dpdk.org>,
"Viacheslav Ovsiienko" <viacheslavo@nvidia.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 2/2] net/mlx5: fix INET IPIP protocol type
Date: Thu, 3 Mar 2022 16:07:29 +0000 [thread overview]
Message-ID: <67896084-e08e-4615-8992-84524f220b1b@intel.com> (raw)
In-Reply-To: <20220301151856.17341-2-getelson@nvidia.com>
On 3/1/2022 3:18 PM, Gregory Etelson wrote:
> Fix typo in INET IPIP protocol macro.
>
> Cc: stable@dpdk.org
>
> Fixes: f3f1f576f438 ("net/mlx5: fix RSS expansion with explicit next protocol")
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 0d774cfd19..efb988a9bb 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -208,7 +208,7 @@ mlx5_inet_proto_to_item_type(uint8_t proto_spec, uint8_t proto_mask)
> case IPPROTO_TCP:
> type = RTE_FLOW_ITEM_TYPE_TCP;
> break;
> - case IPPROTO_IP:
> + case IPPROTO_IPIP:
Hi Gregory, Matan,
Are you sure about this change?
In linux header (include/uapi/linux/in.h) it is defined as:
IPPROTO_IPIP = 4, /* IPIP tunnels (older KA9Q tunnels use 94) */
And IPIP tunnels as far as I can found [1]:
IPIP tunnel, just as the name suggests, is an IP over IP tunnel, defined in RFC 2003.
Since type set to 'RTE_FLOW_ITEM_TYPE_IPV4' in this case
statement, I would like to double check if this is correct.
[1]
https://developers.redhat.com/blog/2019/05/17/an-introduction-to-linux-virtual-interfaces-tunnels#ipip_tunnel
next prev parent reply other threads:[~2022-03-03 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 15:18 [PATCH 1/2] net/mlx5: fix next protocol RSS expansion Gregory Etelson
2022-03-01 15:18 ` [PATCH 2/2] net/mlx5: fix INET IPIP protocol type Gregory Etelson
2022-03-03 16:07 ` Ferruh Yigit [this message]
2022-03-07 6:04 ` Gregory Etelson
2022-03-02 16:41 ` [PATCH 1/2] net/mlx5: fix next protocol RSS expansion Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67896084-e08e-4615-8992-84524f220b1b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).