From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D0DF42D1B for ; Thu, 22 Jun 2023 15:53:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 076BD406B8; Thu, 22 Jun 2023 15:53:34 +0200 (CEST) Received: from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80]) by mails.dpdk.org (Postfix) with ESMTP id 4B687406A2; Thu, 22 Jun 2023 15:53:32 +0200 (CEST) Received: from [192.168.2.179] (unknown [141.136.90.242]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by agw.arknetworks.am (Postfix) with ESMTPSA id BE1BBE123D; Thu, 22 Jun 2023 17:53:31 +0400 (+04) Message-ID: <679468ec-14df-2d2d-557f-9c467fbf17a1@arknetworks.am> Date: Thu, 22 Jun 2023 17:52:51 +0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v5] common/sfc_efx/base: fix Rx queue creation without RSS hash prefix Content-Language: en-US To: Ferruh Yigit , dev@dpdk.org Cc: Andrew Rybchenko , stable@dpdk.org, Andy Moreton References: <20230531070810.93131-1-artemii.morozov@arknetworks.am> <20230622123136.264482-1-artemii.morozov@arknetworks.am> From: Artemii Morozov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 6/22/23 17:13, Ferruh Yigit wrote: > On 6/22/2023 1:31 PM, Artemii Morozov wrote: >> If the prefix for the RSS hash was not chosen the ENOTSUP error should >> be returned. >> >> Before this patch success was returned for this case causing Rx queue >> creation to fail. >> >> Fixing return value to indicate failure. >> > It looks like you used sample commit log as it is, so can you please > confirm this is the actual case (because this was my assumption without > really knowing the actual problem), problem is not crash or undefined > behavior because of 'erpp' was not set etc..? The main problem is that if the RSS prefix was requested and an error occurred when creating the Rx queue, then this is ignored. Now the commit message reflects this. > >> Fixes: f784cdc5cbb1 ("common/sfc_efx/base: provide control to deliver RSS hash") >> Cc: stable@dpdk.org >> >> Signed-off-by: Artemii Morozov >> Reviewed-by: Andy Moreton >> Acked-by: Andrew Rybchenko >> --- >> v5: update commit message >> >> v4: add Cc: stable@dpdk.org and transform rss to RSS >> >> v3: update commit log as fix commit >> >> v2: don't use capital letters in email >> >> drivers/common/sfc_efx/base/efx_rx.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c >> index 68f42f5cac..61726a9f0b 100644 >> --- a/drivers/common/sfc_efx/base/efx_rx.c >> +++ b/drivers/common/sfc_efx/base/efx_rx.c >> @@ -937,8 +937,10 @@ efx_rx_qcreate_internal( >> >> rss_hash_field = >> &erplp->erpl_fields[EFX_RX_PREFIX_FIELD_RSS_HASH]; >> - if (rss_hash_field->erpfi_width_bits == 0) >> + if (rss_hash_field->erpfi_width_bits == 0) { >> + rc = ENOTSUP; >> goto fail5; >> + } >> } >> >> enp->en_rx_qcount++;