From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94AF8A0A0B for ; Fri, 22 Jan 2021 15:58:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83390141007; Fri, 22 Jan 2021 15:58:56 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 0C8E3140FFB; Fri, 22 Jan 2021 15:58:53 +0100 (CET) IronPort-SDR: GVkAwnM5xxvFYFOkk7yxaMEXstMDp3BKXUH5vuCfp6Biij/0iZSbBp0idRIkRhhQ0Z+a82tpYA mBD0gVnpa6Hg== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="176881552" X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="176881552" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 06:58:52 -0800 IronPort-SDR: Mgt4HtE5+UYa07CE5/7dTtJ82U6Im8kmS7WRGnllQS6SwI8h4udFZV4Zavy4Yj2z+iX/lm00rO YvvB4wc4TOOA== X-IronPort-AV: E=Sophos;i="5.79,366,1602572400"; d="scan'208";a="385787632" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.222.36]) ([10.213.222.36]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2021 06:58:51 -0800 To: "Zhou, JunX W" , "Zhang, AlvinX" Cc: "dev@dpdk.org" , "stable@dpdk.org" References: <20210118085937.12072-1-alvinx.zhang@intel.com> <20210121094154.6788-1-alvinx.zhang@intel.com> From: Ferruh Yigit Message-ID: <67a2059d-c426-9aeb-6479-52375b060349@intel.com> Date: Fri, 22 Jan 2021 14:58:47 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] app/testpmd: fix RSS key X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 1/22/2021 5:43 AM, Zhou, JunX W wrote: <...> > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang,Alvin > Sent: Thursday, January 21, 2021 5:42 PM > To: Yigit, Ferruh > Cc: dev@dpdk.org; Zhang, AlvinX ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix RSS key > > From: Alvin Zhang > > Since the patch '1848b117' has initialized the variable 'key' in 'struct rte_flow_action_rss' with 'NULL', the PMD cannot get the RSS key now. Details as bellow: > > testpmd> flow create 0 ingress pattern eth / ipv4 / end actions > rss types ipv4-other end key > 1234567890123456789012345678901234567890FFFFFFFFFFFF123 > 4567890123456789012345678901234567890FFFFFFFFFFFF > queues end / end > Flow rule #1 created > testpmd> show port 0 rss-hash key > RSS functions: > all ipv4-other ip > RSS key: > 4439796BB54C5023B675EA5B124F9F30B8A2C03DDFDC4D02A08C9B3 > 34AF64A4C05C6FA343958D8557D99583AE138C92E81150366 > > This patch sets offset and size of the 'key' variable as the first parameter of the token 'key'. Later, the address of the RSS key will be copied to 'key' variable. > > Fixes: 1848b117cca1 ("app/testpmd: fix RSS key for flow API RSS rule") > Cc: stable@dpdk.org > > Signed-off-by: Alvin Zhang > > Tested-by: Zhou, Jun > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.