[PATCH 21.11] build: suppress rte_crypto_asym_op abi check

[PATCH 21.11] build: suppress rte_crypto_asym_op abi check

[Kevin Traynor]

Suppress of rte_crypto_asym_op was added in dpdk main branch
as part of
a678c5d36589 ("cryptodev: add DSA random number k")

That is not backported to 21.11 branch, but other commit
f092922c3674 ("cryptodev: fix RSA key type name")
also needs this suppression.

Add the suppression here.

Fixes: f092922c3674 ("cryptodev: fix RSA key type name")
Cc: arkadiuszx.kusztal@intel.com

Reported-by: https://lab.dpdk.org/results/dashboard/tarballs/19132
Reported-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
 devtools/libabigail.abignore | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
index 004fd53180..146a601ed3 100644
--- a/devtools/libabigail.abignore
+++ b/devtools/libabigail.abignore
@@ -13,4 +13,8 @@
         name_regexp = _pmd_info$
 
+; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is experimental
+[suppress_type]
+        name = rte_crypto_asym_op
+
 ; Ignore section attribute fixes in experimental regexdev library
 [suppress_file]
-- 
2.34.1

Re: [PATCH 21.11] build: suppress rte_crypto_asym_op abi check

[Kevin Traynor]

On 16/03/2022 11:45, Kevin Traynor wrote:
> Suppress of rte_crypto_asym_op was added in dpdk main branch
> as part of
> a678c5d36589 ("cryptodev: add DSA random number k")
> 
> That is not backported to 21.11 branch, but other commit
> f092922c3674 ("cryptodev: fix RSA key type name")
> also needs this suppression.
> 
> Add the suppression here.
> 
> Fixes: f092922c3674 ("cryptodev: fix RSA key type name")
> Cc: arkadiuszx.kusztal@intel.com
> 
> Reported-by: https://lab.dpdk.org/results/dashboard/tarballs/19132
> Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---

Will apply this by EOD if no objections so the nightly CI will pass.

>   devtools/libabigail.abignore | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> index 004fd53180..146a601ed3 100644
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -13,4 +13,8 @@
>           name_regexp = _pmd_info$
>   
> +; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is experimental
> +[suppress_type]
> +        name = rte_crypto_asym_op
> +
>   ; Ignore section attribute fixes in experimental regexdev library
>   [suppress_file]

Re: [PATCH 21.11] build: suppress rte_crypto_asym_op abi check

[David Marchand]

On Wed, Mar 16, 2022 at 12:45 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>
> Suppress of rte_crypto_asym_op was added in dpdk main branch
> as part of
> a678c5d36589 ("cryptodev: add DSA random number k")
>
> That is not backported to 21.11 branch, but other commit
> f092922c3674 ("cryptodev: fix RSA key type name")
> also needs this suppression.
>
> Add the suppression here.
>
> Fixes: f092922c3674 ("cryptodev: fix RSA key type name")
> Cc: arkadiuszx.kusztal@intel.com
>
> Reported-by: https://lab.dpdk.org/results/dashboard/tarballs/19132

In dpdk history, the Reported-by tag has always been used with people
names, and not URI.
It is probably not an issue (except maybe for people doing stats on
those tags), but I would rather keep this URI as a comment in the
commitlog.

> Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>

The change lgtm,

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand

Re: [PATCH 21.11] build: suppress rte_crypto_asym_op abi check

[Kevin Traynor]

On 16/03/2022 16:14, David Marchand wrote:
> On Wed, Mar 16, 2022 at 12:45 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>>
>> Suppress of rte_crypto_asym_op was added in dpdk main branch
>> as part of
>> a678c5d36589 ("cryptodev: add DSA random number k")
>>
>> That is not backported to 21.11 branch, but other commit
>> f092922c3674 ("cryptodev: fix RSA key type name")
>> also needs this suppression.
>>

This caused a failure in UNH CI
https://lab.dpdk.org/results/dashboard/tarballs/19132

>> Add the suppression here.
>>
>> Fixes: f092922c3674 ("cryptodev: fix RSA key type name")
>> Cc: arkadiuszx.kusztal@intel.com
>>
>> Reported-by: https://lab.dpdk.org/results/dashboard/tarballs/19132
> 
> In dpdk history, the Reported-by tag has always been used with people
> names, and not URI.
> It is probably not an issue (except maybe for people doing stats on
> those tags), but I would rather keep this URI as a comment in the
> commitlog.
> 

ok, sure. I changed it to free form in the commit msg as above instead.

>> Reported-by: David Marchand <david.marchand@redhat.com>
>> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> 
> The change lgtm,
> 
> Reviewed-by: David Marchand <david.marchand@redhat.com>

Thanks. Applied with changes above.

> 
>