From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5A5441CDE for ; Sun, 19 Feb 2023 13:01:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD7DA42D1D; Sun, 19 Feb 2023 13:01:18 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 7EBD740698; Sun, 19 Feb 2023 13:01:16 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 226075C0124; Sun, 19 Feb 2023 07:01:16 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 19 Feb 2023 07:01:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676808076; x= 1676894476; bh=wFGlhMnKv7cVvH6EN26JUsLGs6C1r0rHJypHivpyUNE=; b=H 1Z99E4wKy/b4MM+ISD4gkmS0kt1Z8LeR1q3qgR1dNHGcGpkTuQLG33cyF2PQKEju addzmWEgZ0dfC1A+b9JmLYfckr3ZBXDolTZXqsOAblx+OzSNV9gAYw7WK4ZG8gTn d63FgHg6F0307n6vVudDWVOqwbpldzmTU+7JVTfNRrA5REGFpg749eZ2Fo0kPSts 5qUjgQ6RqhUKbwhLFVMzc6um/OBoaG1BjPQ0DYQ6E5FQ3z7rQ5KgMuHjWP4oMuVs 8JSHlRpFd2sSA+P6MiWruzM7bdB24GUpXJgoTOICLpuLcLeMf09Y5cZd/EL87xq1 FtgRvJz68axmCQ/MXJdwQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676808076; x= 1676894476; bh=wFGlhMnKv7cVvH6EN26JUsLGs6C1r0rHJypHivpyUNE=; b=a xpfo1NKl1hjrnlx9zKFrTPRCl3swhCFyv/yWpxyzSwP/QqNJd5Y3mfrRWsgtkxtP 1LZtKFakSVt7d9NgecHNXz1i115hOKJj2ahYiUhT3wOdbx2MaNKj99w7ooy19isL VucPCsb3DUzO30MA9xatEBy+JzxVKYHTheHxIGGjmTomZiP+HWqiKkS1sQMC/wTx LF0pXIMy1ovTWxMyUADWMYKIz/1QGEenjW5JmC23ugooWE5+L6WN/+2w6CvVagLr mXG4bRxM7z/nsPa70/cv5HOM8IDU6abCb342IudhXOubUnz1L3u2GA+vUkobxMek W/fyr0WZ3Okiiq4IONZuQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejfedgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejjefffffgffekfefflefgkeelteejffelledugefhheelffet heevudffudfgvdenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Feb 2023 07:01:14 -0500 (EST) From: Thomas Monjalon To: "mb@smartsharesystems.com" , "Richardson, Bruce" , "Lu, Wenzhuo" , "Wu, Wenjun1" Cc: dev@dpdk.org, stable@dpdk.org, "stable@dpdk.org" , "Zhang, Qi Z" , david.marchand@redhat.com, bruce.richardson@intel.com, Shijith Thotton Subject: Re: [PATCH v2] net: not build PMD AVX library when no IOVA as PA Date: Sun, 19 Feb 2023 13:01:12 +0100 Message-ID: <6959633.aoefvbuG5b@thomas> In-Reply-To: <5705342.1B3tZ46Xf9@thomas> References: <20221212121711.857866-1-qi.z.zhang@intel.com> <3023187.ktpJ11cQ8Q@thomas> <5705342.1B3tZ46Xf9@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 19/02/2023 12:08, Thomas Monjalon: > 19/02/2023 11:04, Thomas Monjalon: > > 29/01/2023 13:35, Zhang, Qi Z: > > > From: Zhang, Qi Z > > > > > > > > PMD not announce pmd_supports_disable_iova_as_pa will not be build > > > > when RTE_IOVA_AS_PA is not defined, but some AVX library for vector path > > > > is not skipped by the build system which cause compile error. > > > > > > > > The patch modify i40e, iavf, ice's meson file to skip AVX library build when > > > > RTE_IOVA_AS_PA is not defined. > > > > > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Qi Zhang > > > > > > Move this for next-net review. > > > > > > Acked-by: Qi Zhang > > > > You ack your own patch? > > > > > Applied to dpdk-next-net-intel. > > > > Sorry I don't pull this one, as I think there is a better fix: > > we should not handle this option in each driver. > > Instead the file drivers/meson.build must be fixed. > > No sorry, it cannot be handled in drivers/meson.build. > > So I suggest disabling the whole driver: > > +if not get_option('enable_iova_as_pa') > + subdir_done() > +endif > > Note: no need to disable ice, as it is enabled in another commit. I've sent a patch to better disable more drivers: https://patches.dpdk.org/project/dpdk/patch/20230219115529.3260580-1-thomas@monjalon.net/ I think more patches would be required to enable more drivers supporting IOVA as VA. For instance, mempool drivers should be enabled.