* [dpdk-stable] [PATCH 17.11] test/bonding: assign non-zero MAC to null devices
@ 2019-07-19 8:55 Rybalchenko, Kirill
2019-07-23 1:32 ` Yongseok Koh
0 siblings, 1 reply; 2+ messages in thread
From: Rybalchenko, Kirill @ 2019-07-19 8:55 UTC (permalink / raw)
To: Yongseok Koh; +Cc: stable
From: Radu Nicolau <radu.nicolau@intel.com>
[backported from upstream commit e8df563bac263e55b7dd9d45a00417aa92ef66cb]
Prevent failure in rte_eth_dev_default_mac_addr_set() that
results in bonding add slave failure.
Fixes: aa7791ba8de0 ("net/bonding: fix setting slave MAC addresses")
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
| 5 +++++
1 file changed, 5 insertions(+)
--git a/test/test/test_link_bonding_rssconf.c b/test/test/test_link_bonding_rssconf.c
index 54cbf12..a637453 100644
--- a/test/test/test_link_bonding_rssconf.c
+++ b/test/test/test_link_bonding_rssconf.c
@@ -534,6 +534,7 @@ test_setup(void)
int port_id;
char name[256];
struct slave_conf *port;
+ struct ether_addr mac_addr = {0};
if (test_params.mbuf_pool == NULL) {
@@ -565,6 +566,10 @@ test_setup(void)
TEST_ASSERT_SUCCESS(retval, "Failed to configure virtual ethdev %s\n",
name);
+ /* assign a non-zero MAC */
+ mac_addr.addr_bytes[5] = 0x10 + port->port_id;
+ rte_eth_dev_default_mac_addr_set(port->port_id, &mac_addr);
+
rte_eth_dev_info_get(port->port_id, &port->dev_info);
}
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH 17.11] test/bonding: assign non-zero MAC to null devices
2019-07-19 8:55 [dpdk-stable] [PATCH 17.11] test/bonding: assign non-zero MAC to null devices Rybalchenko, Kirill
@ 2019-07-23 1:32 ` Yongseok Koh
0 siblings, 0 replies; 2+ messages in thread
From: Yongseok Koh @ 2019-07-23 1:32 UTC (permalink / raw)
To: Rybalchenko, Kirill; +Cc: stable
> On Jul 19, 2019, at 1:55 AM, Rybalchenko, Kirill <kirill.rybalchenko@intel.com> wrote:
>
> From: Radu Nicolau <radu.nicolau@intel.com>
> [backported from upstream commit e8df563bac263e55b7dd9d45a00417aa92ef66cb]
>
> Prevent failure in rte_eth_dev_default_mac_addr_set() that
> results in bonding add slave failure.
>
> Fixes: aa7791ba8de0 ("net/bonding: fix setting slave MAC addresses")
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
This has been cherry-picked from the upstream commit.
Thanks,
Yongseok
> test/test/test_link_bonding_rssconf.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/test/test/test_link_bonding_rssconf.c b/test/test/test_link_bonding_rssconf.c
> index 54cbf12..a637453 100644
> --- a/test/test/test_link_bonding_rssconf.c
> +++ b/test/test/test_link_bonding_rssconf.c
> @@ -534,6 +534,7 @@ test_setup(void)
> int port_id;
> char name[256];
> struct slave_conf *port;
> + struct ether_addr mac_addr = {0};
>
> if (test_params.mbuf_pool == NULL) {
>
> @@ -565,6 +566,10 @@ test_setup(void)
> TEST_ASSERT_SUCCESS(retval, "Failed to configure virtual ethdev %s\n",
> name);
>
> + /* assign a non-zero MAC */
> + mac_addr.addr_bytes[5] = 0x10 + port->port_id;
> + rte_eth_dev_default_mac_addr_set(port->port_id, &mac_addr);
> +
> rte_eth_dev_info_get(port->port_id, &port->dev_info);
> }
>
> --
> 2.7.4
>
> <0001-test-virtual_pmd-add-set-MAC-address-dev-op.patch>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-23 1:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-19 8:55 [dpdk-stable] [PATCH 17.11] test/bonding: assign non-zero MAC to null devices Rybalchenko, Kirill
2019-07-23 1:32 ` Yongseok Koh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).