From: Chas Williams <3chas3@gmail.com>
To: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>, dev@dpdk.org
Cc: reshma.pattan@intel.com, declan.doherty@intel.com,
jananeex.m.parthasarathy@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/bonding: fix create bonded device test failure
Date: Mon, 7 Jan 2019 13:44:39 -0500 [thread overview]
Message-ID: <69a66875-ec6c-f284-a5bc-78c10e987f68@gmail.com> (raw)
In-Reply-To: <1546866064-11929-1-git-send-email-hari.kumarx.vemula@intel.com>
On 1/7/19 8:01 AM, Hari Kumar Vemula wrote:
> Create bonded device test is failing due to improper initialisation in
> bonded device configuration. which leads to crash while setting up queues.
>
> The value of nb_rx_desc is checked if it is not in range of rx_desc_lim of
> bonded device which fails.
> This is due to "rx_desc_lim" is set to 0 as default value of bonded device
> during bond_alloc().
> Hence nb_rx_desc (1024) is > 0 and test fails.
>
> Fix is to set the default values of rx_desc_lim of bonded device to
> appropriate value.
The default values for the bond device aren't known until the first
slave is added. Can you explain your setup? What PMD are you
using for testing?
>
> Fixes: 2efb58cbab ("bond: new link bonding library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index 44deaf119..e0888e960 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -2225,6 +2225,11 @@ static void
> bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
> {
> struct bond_dev_private *internals = dev->data->dev_private;
> + struct rte_eth_desc_lim bond_lim = {
> + .nb_max = UINT16_MAX,
> + .nb_min = 0,
> + .nb_align = 1,
> + };
>
> uint16_t max_nb_rx_queues = UINT16_MAX;
> uint16_t max_nb_tx_queues = UINT16_MAX;
> @@ -2263,10 +2268,8 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
> memcpy(&dev_info->default_txconf, &internals->default_txconf,
> sizeof(dev_info->default_txconf));
>
> - memcpy(&dev_info->rx_desc_lim, &internals->rx_desc_lim,
> - sizeof(dev_info->rx_desc_lim));
> - memcpy(&dev_info->tx_desc_lim, &internals->tx_desc_lim,
> - sizeof(dev_info->tx_desc_lim));
> + dev_info->rx_desc_lim = bond_lim;
> + dev_info->tx_desc_lim = bond_lim;
>
> /**
> * If dedicated hw queues enabled for link bonding device in LACP mode
>
next prev parent reply other threads:[~2019-01-07 18:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <yes>
2019-01-03 12:28 ` [dpdk-stable] [PATCH v2] eal: fix core number validation Hari kumar Vemula
2019-01-03 13:03 ` David Marchand
2019-01-07 7:05 ` Hari Kumar Vemula
2019-01-07 10:25 ` [dpdk-stable] [PATCH v3] " Hari Kumar Vemula
2019-01-10 10:11 ` David Marchand
2019-01-11 14:15 ` [dpdk-stable] [PATCH v4] " Hari Kumar Vemula
2019-01-11 15:06 ` David Marchand
2019-01-14 10:08 ` [dpdk-stable] [PATCH v5] " Hari Kumar Vemula
2019-01-14 10:28 ` Hari Kumar Vemula
2019-01-14 14:39 ` David Marchand
2019-01-17 10:11 ` [dpdk-stable] [PATCH v6] " Hari Kumar Vemula
2019-01-17 12:13 ` Hari Kumar Vemula
2019-01-17 12:19 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2019-01-17 12:32 ` David Marchand
2019-01-17 16:29 ` [dpdk-stable] " Thomas Monjalon
2019-01-17 16:31 ` Thomas Monjalon
2019-01-04 13:10 ` [dpdk-stable] [PATCH v2] " Hari kumar Vemula
2019-01-07 13:01 ` [dpdk-stable] [PATCH] net/bonding: fix create bonded device test failure Hari Kumar Vemula
2019-01-07 18:44 ` Chas Williams [this message]
2019-01-08 10:27 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2019-01-15 17:37 ` [dpdk-stable] " Pattan, Reshma
2019-01-28 7:28 ` [dpdk-stable] [PATCH v2] " Hari Kumar Vemula
2019-01-31 23:40 ` [dpdk-stable] [dpdk-dev] " Chas Williams
2019-02-05 13:39 ` [dpdk-stable] [PATCH v3] " Hari Kumar Vemula
2019-02-07 13:34 ` Ferruh Yigit
2019-01-08 6:18 ` [dpdk-stable] [PATCH] " Hari Kumar Vemula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69a66875-ec6c-f284-a5bc-78c10e987f68@gmail.com \
--to=3chas3@gmail.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hari.kumarx.vemula@intel.com \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).