* [dpdk-stable] [PATCH v2 2/3] net/ixgbe: fix fdir mask not be reset [not found] <1496259940-15547-1-git-send-email-qi.z.zhang@intel.com> @ 2017-05-31 19:45 ` Qi Zhang 2017-06-01 7:17 ` Lu, Wenzhuo [not found] ` <1496338605-7338-1-git-send-email-qi.z.zhang@intel.com> 1 sibling, 1 reply; 3+ messages in thread From: Qi Zhang @ 2017-05-31 19:45 UTC (permalink / raw) To: wenzhuo.lu, helin.zhang; +Cc: dev, Qi Zhang, stable When the last fdir flow be destroyed, the flag "mask_added" should be reset, so the remain mask info will not take effect when a new flow be added. Fixes: a14de8b498d1 ("net/ixgbe: destroy consistent filter") Cc: stable@dpdk.org Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> --- drivers/net/ixgbe/ixgbe_flow.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c index 2c09444..886180e 100644 --- a/drivers/net/ixgbe/ixgbe_flow.c +++ b/drivers/net/ixgbe/ixgbe_flow.c @@ -2641,6 +2641,8 @@ ixgbe_flow_destroy(struct rte_eth_dev *dev, struct ixgbe_eth_l2_tunnel_conf_ele *l2_tn_filter_ptr; struct ixgbe_fdir_rule_ele *fdir_rule_ptr; struct ixgbe_flow_mem *ixgbe_flow_mem_ptr; + struct ixgbe_hw_fdir_info *fdir_info = + IXGBE_DEV_PRIVATE_TO_FDIR_INFO(dev->data->dev_private); switch (filter_type) { case RTE_ETH_FILTER_NTUPLE: @@ -2693,6 +2695,8 @@ ixgbe_flow_destroy(struct rte_eth_dev *dev, TAILQ_REMOVE(&filter_fdir_list, fdir_rule_ptr, entries); rte_free(fdir_rule_ptr); + if (TAILQ_EMPTY(&filter_fdir_list)) + fdir_info->mask_added = false; } break; case RTE_ETH_FILTER_L2_TUNNEL: -- 2.7.4 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH v2 2/3] net/ixgbe: fix fdir mask not be reset 2017-05-31 19:45 ` [dpdk-stable] [PATCH v2 2/3] net/ixgbe: fix fdir mask not be reset Qi Zhang @ 2017-06-01 7:17 ` Lu, Wenzhuo 0 siblings, 0 replies; 3+ messages in thread From: Lu, Wenzhuo @ 2017-06-01 7:17 UTC (permalink / raw) To: Zhang, Qi Z, Zhang, Helin; +Cc: dev, stable Hi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, June 1, 2017 3:46 AM > To: Lu, Wenzhuo; Zhang, Helin > Cc: dev@dpdk.org; Zhang, Qi Z; stable@dpdk.org > Subject: [PATCH v2 2/3] net/ixgbe: fix fdir mask not be reset > > When the last fdir flow be destroyed, the flag "mask_added" > should be reset, so the remain mask info will not take effect when a new > flow be added. > > Fixes: a14de8b498d1 ("net/ixgbe: destroy consistent filter") > Cc: stable@dpdk.org > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <1496338605-7338-1-git-send-email-qi.z.zhang@intel.com>]
* [dpdk-stable] [PATCH v3 2/3] net/ixgbe: fix fdir mask not be reset [not found] ` <1496338605-7338-1-git-send-email-qi.z.zhang@intel.com> @ 2017-06-01 17:36 ` Qi Zhang 0 siblings, 0 replies; 3+ messages in thread From: Qi Zhang @ 2017-06-01 17:36 UTC (permalink / raw) To: wenzhuo.lu, helin.zhang; +Cc: dev, Qi Zhang, stable When the last fdir flow be destroyed, the flag "mask_added" should be reset, so the remain mask info will not take effect when a new flow be added. Fixes: a14de8b498d1 ("net/ixgbe: destroy consistent filter") Cc: stable@dpdk.org Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> --- drivers/net/ixgbe/ixgbe_flow.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c index 60ca8d8..4e64d8d 100644 --- a/drivers/net/ixgbe/ixgbe_flow.c +++ b/drivers/net/ixgbe/ixgbe_flow.c @@ -2639,6 +2639,8 @@ ixgbe_flow_destroy(struct rte_eth_dev *dev, struct ixgbe_eth_l2_tunnel_conf_ele *l2_tn_filter_ptr; struct ixgbe_fdir_rule_ele *fdir_rule_ptr; struct ixgbe_flow_mem *ixgbe_flow_mem_ptr; + struct ixgbe_hw_fdir_info *fdir_info = + IXGBE_DEV_PRIVATE_TO_FDIR_INFO(dev->data->dev_private); switch (filter_type) { case RTE_ETH_FILTER_NTUPLE: @@ -2691,6 +2693,8 @@ ixgbe_flow_destroy(struct rte_eth_dev *dev, TAILQ_REMOVE(&filter_fdir_list, fdir_rule_ptr, entries); rte_free(fdir_rule_ptr); + if (TAILQ_EMPTY(&filter_fdir_list)) + fdir_info->mask_added = false; } break; case RTE_ETH_FILTER_L2_TUNNEL: -- 2.7.4 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-02 0:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1496259940-15547-1-git-send-email-qi.z.zhang@intel.com>
2017-05-31 19:45 ` [dpdk-stable] [PATCH v2 2/3] net/ixgbe: fix fdir mask not be reset Qi Zhang
2017-06-01 7:17 ` Lu, Wenzhuo
[not found] ` <1496338605-7338-1-git-send-email-qi.z.zhang@intel.com>
2017-06-01 17:36 ` [dpdk-stable] [PATCH v3 " Qi Zhang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).