patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH] net/virtio: restore some optimisations with AVX512
@ 2022-04-11 15:04 David Marchand
  2022-04-19  9:12 ` Maxime Coquelin
  2022-05-05 19:56 ` Maxime Coquelin
  0 siblings, 2 replies; 3+ messages in thread
From: David Marchand @ 2022-04-11 15:04 UTC (permalink / raw)
  To: dev; +Cc: stable, Maxime Coquelin, Chenbo Xia, Marvin Liu

Those optimisations were only enabled with make builds, fix the meson
part.

Fixes: 77d66da83834 ("net/virtio: add vectorized packed ring Rx")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/virtio/meson.build | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/virtio/meson.build b/drivers/net/virtio/meson.build
index 01a333ada2..d78b8278c6 100644
--- a/drivers/net/virtio/meson.build
+++ b/drivers/net/virtio/meson.build
@@ -30,11 +30,11 @@ if arch_subdir == 'x86'
                           c_args: [cflags, '-mavx512f', '-mavx512bw', '-mavx512vl'])
             objs += virtio_avx512_lib.extract_objects('virtio_rxtx_packed.c')
             if (toolchain == 'gcc' and cc.version().version_compare('>=8.3.0'))
-                cflags += '-DVHOST_GCC_UNROLL_PRAGMA'
+                cflags += '-DVIRTIO_GCC_UNROLL_PRAGMA'
             elif (toolchain == 'clang' and cc.version().version_compare('>=3.7.0'))
-                cflags += '-DVHOST_CLANG_UNROLL_PRAGMA'
+                cflags += '-DVIRTIO_CLANG_UNROLL_PRAGMA'
             elif (toolchain == 'icc' and cc.version().version_compare('>=16.0.0'))
-                cflags += '-DVHOST_ICC_UNROLL_PRAGMA'
+                cflags += '-DVIRTIO_ICC_UNROLL_PRAGMA'
             endif
         endif
     endif
-- 
2.23.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/virtio: restore some optimisations with AVX512
  2022-04-11 15:04 [PATCH] net/virtio: restore some optimisations with AVX512 David Marchand
@ 2022-04-19  9:12 ` Maxime Coquelin
  2022-05-05 19:56 ` Maxime Coquelin
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2022-04-19  9:12 UTC (permalink / raw)
  To: David Marchand, dev; +Cc: stable, Chenbo Xia, Marvin Liu

Hi Marvin,

On 4/11/22 17:04, David Marchand wrote:
> Those optimisations were only enabled with make builds, fix the meson
> part.
> 
> Fixes: 77d66da83834 ("net/virtio: add vectorized packed ring Rx")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   drivers/net/virtio/meson.build | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/virtio/meson.build b/drivers/net/virtio/meson.build
> index 01a333ada2..d78b8278c6 100644
> --- a/drivers/net/virtio/meson.build
> +++ b/drivers/net/virtio/meson.build
> @@ -30,11 +30,11 @@ if arch_subdir == 'x86'
>                             c_args: [cflags, '-mavx512f', '-mavx512bw', '-mavx512vl'])
>               objs += virtio_avx512_lib.extract_objects('virtio_rxtx_packed.c')
>               if (toolchain == 'gcc' and cc.version().version_compare('>=8.3.0'))
> -                cflags += '-DVHOST_GCC_UNROLL_PRAGMA'
> +                cflags += '-DVIRTIO_GCC_UNROLL_PRAGMA'
>               elif (toolchain == 'clang' and cc.version().version_compare('>=3.7.0'))
> -                cflags += '-DVHOST_CLANG_UNROLL_PRAGMA'
> +                cflags += '-DVIRTIO_CLANG_UNROLL_PRAGMA'
>               elif (toolchain == 'icc' and cc.version().version_compare('>=16.0.0'))
> -                cflags += '-DVHOST_ICC_UNROLL_PRAGMA'
> +                cflags += '-DVIRTIO_ICC_UNROLL_PRAGMA'
>               endif
>           endif
>       endif

I wonder how this was not spotted by the Intel performance lab?
Is that these optimizations do not bring performance gains, or it is not
benchmark-ed?

Anyway:

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/virtio: restore some optimisations with AVX512
  2022-04-11 15:04 [PATCH] net/virtio: restore some optimisations with AVX512 David Marchand
  2022-04-19  9:12 ` Maxime Coquelin
@ 2022-05-05 19:56 ` Maxime Coquelin
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2022-05-05 19:56 UTC (permalink / raw)
  To: David Marchand, dev; +Cc: stable, Chenbo Xia, Marvin Liu



On 4/11/22 17:04, David Marchand wrote:
> Those optimisations were only enabled with make builds, fix the meson
> part.
> 
> Fixes: 77d66da83834 ("net/virtio: add vectorized packed ring Rx")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   drivers/net/virtio/meson.build | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 

Applied to dpdk-next-virtio/main.

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-05 19:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-11 15:04 [PATCH] net/virtio: restore some optimisations with AVX512 David Marchand
2022-04-19  9:12 ` Maxime Coquelin
2022-05-05 19:56 ` Maxime Coquelin

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git