From: "Singh, Aman Deep" <aman.deep.singh@intel.com>
To: Adham Masarwah <adham@nvidia.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <talshn@nvidia.com>, <tamerh@nvidia.com>,
<idanhac@nvidia.com>, <stable@dpdk.org>
Subject: Re: [PATCH] app/testpmd: fixed using strtoull with 64-bit variables
Date: Fri, 11 Mar 2022 15:10:33 +0530 [thread overview]
Message-ID: <6c5c6289-16ce-80cd-0f79-5624ab734e40@intel.com> (raw)
In-Reply-To: <20220310175023.2552-2-adham@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
On 3/10/2022 11:20 PM, Adham Masarwah wrote:
> Replaced using strtoul with strtoull when converting to
> 64-bit mask field.
> In Windows strtoul returns 32-bit values which cause an
> issue with show RSS reta.
>
> Fixes: 66c594904ac ("ethdev: support multiple sizes of redirection table")
> Cc:stable@dpdk.org
>
> Signed-off-by: Adham Masarwah<adham@nvidia.com>
> ---
Acked-by: Aman Singh <aman.deep.singh@intel.com>
As Windowuses the|LLP64 data model.|
> app/test-pmd/cmdline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index b4ba8da2b0..efa02bd301 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -3127,7 +3127,7 @@ showport_parse_reta_config(struct rte_eth_rss_reta_entry64 *conf,
> return -1;
> }
> for (i = 0; i < ret; i++)
> - conf[i].mask = (uint64_t)strtoul(str_fld[i], &end, 0);
> + conf[i].mask = (uint64_t)strtoull(str_fld[i], &end, 0);
>
> return 0;
> }
[-- Attachment #2: Type: text/html, Size: 3133 bytes --]
next prev parent reply other threads:[~2022-03-11 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 17:50 Adham Masarwah
2022-03-10 17:50 ` Adham Masarwah
2022-03-11 9:40 ` Singh, Aman Deep [this message]
2022-03-14 20:25 ` Thomas Monjalon
2022-03-13 12:45 ` [PATCH v2] app/testpmd: fix show RSS RETA on Windows Adham Masarwah
2022-03-13 12:57 ` [PATCH v3] " Adham Masarwah
2022-03-13 13:21 ` Tal Shnaiderman
2022-03-14 20:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c5c6289-16ce-80cd-0f79-5624ab734e40@intel.com \
--to=aman.deep.singh@intel.com \
--cc=adham@nvidia.com \
--cc=dev@dpdk.org \
--cc=idanhac@nvidia.com \
--cc=stable@dpdk.org \
--cc=talshn@nvidia.com \
--cc=tamerh@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).