patches for DPDK stable branches
 help / color / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: Ori Kam <orika@mellanox.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 19.11] eal/ppc: fix bool type after altivec include
Date: Tue, 02 Jun 2020 14:29:46 +0100
Message-ID: <6d394b9c1d962a15d589e42c6dccc3fda45f4de3.camel@debian.org> (raw)
In-Reply-To: <AM6PR05MB517609FE65D92FA3721130D2DB8B0@AM6PR05MB5176.eurprd05.prod.outlook.com>

Hi,

Yes, it's part of your patch. Probably some build files machinery
missing. I do not have a ppc setup either.

On Tue, 2020-06-02 at 11:27 +0000, Ori Kam wrote:
> Hi Luca,
> Off list.
> 
> Can you please see that the rte_altivec.h file was added?
> I don't have a setup with ppc. 
> 
> Thanks,
> Ori
> 
> 
> > -----Original Message-----
> > From: Luca Boccassi <bluca@debian.org>
> > Sent: Monday, June 1, 2020 1:07 PM
> > To: Ori Kam <orika@mellanox.com>; David Christensen
> > <drc@linux.vnet.ibm.com>; Beilei Xing <beilei.xing@intel.com>; Qi Zhang
> > <qi.z.zhang@intel.com>; Matan Azrad <matan@mellanox.com>; Shahaf Shuler
> > <shahafs@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>;
> > Maxime Coquelin <maxime.coquelin@redhat.com>; Tiwei Bie
> > <tiwei.bie@intel.com>; Zhihong Wang <zhihong.wang@intel.com>
> > Cc: stable@dpdk.org
> > Subject: Re: [PATCH 19.11] eal/ppc: fix bool type after altivec include
> > 
> > On Sun, 2020-05-31 at 15:36 +0000, Ori Kam wrote:
> > > [ upstream commit f5bf02df3145f95b1ee8ed9dee67f4222ac42c8c ]
> > > 
> > > The AltiVec header file breaks boolean type. [1] [2]
> > > 
> > > Currently the workaround was located only in mlx5 device.
> > > Adding the trace module caused this issue to appear again, due to
> > > order of includes, it keeps overriding the local fix.
> > > 
> > > This patch solves this issue by resetting the bool type, immediately
> > > after it is being changed.
> > > 
> > > [1]
> > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.dpd
> > k.org%2Farchives%2Fdev%2F2018-
> > August%2F110281.html&amp;data=02%7C01%7Corika%40mellanox.com%7C30
> > f4a48b032b46dbb97408d8061390af%7Ca652971c7d2e4d9ba6a4d149256f461b
> > %7C0%7C0%7C637266028392843046&amp;sdata=fJAaZN9tNjycMH30Gwh8ILZ
> > %2FjuiYgBVN%2BwdAn6GAbcY%3D&amp;reserved=0
> > 
> > This patch breaks all ppc64 builds:
> > 
> > [  136s] In file included from /home/abuild/rpmbuild/BUILD/dpdk-
> > 1591003733.2dff15dd5/lib/librte_eal/common/eal_common_options.c:27:
> > [  136s] /home/abuild/rpmbuild/BUILD/dpdk-1591003733.2dff15dd5/ppc_64-
> > power8-linux-gcc/include/rte_memcpy.h:12:10: fatal error: rte_altivec.h: No
> > such file or directory
> > [  136s]  #include "rte_altivec.h"
> > 
> > --
> > Kind regards,
> > Luca Boccassi

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-31 15:36 Ori Kam
2020-06-01 10:07 ` Luca Boccassi
2020-06-02 11:27   ` Ori Kam
2020-06-02 13:29     ` Luca Boccassi [this message]
2020-06-02 14:13       ` Ori Kam
2020-06-02 14:25 ` David Marchand
2020-06-03  8:46   ` Luca Boccassi

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d394b9c1d962a15d589e42c6dccc3fda45f4de3.camel@debian.org \
    --to=bluca@debian.org \
    --cc=orika@mellanox.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox