From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEB52A0513 for ; Tue, 2 Jun 2020 15:29:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A71981BF59; Tue, 2 Jun 2020 15:29:49 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 17D121BF59 for ; Tue, 2 Jun 2020 15:29:48 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id c71so2928765wmd.5 for ; Tue, 02 Jun 2020 06:29:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=n61pofvqvyDgoXXUKMqgjxdHVTCQmYF7nDUkipIJBus=; b=pqrWCtWhSgTF9a/6THy0vDvlyTJSHtFvogtldpwo/WQbAiriLY+90ltI19ZlEE+fay Hv+lh24/jDqoGwCeZulfuz+KApqUDheNZg69i7I41wTfKv7bDa4oXw/V8ZEju8Sc2tol DXVo7ulyOd7e6xwnDnkH1Uz2q3GYYpHXbk2Go0A4kvOPnxCjodsVtQTqZJHn/vRK6nZS jgG2DPesx+2vsaW7YupHzLBjUmincWkg4GmVMs7gNRRaXj++WdtjTCgtGdatopdz/+Rv 02+Kgg7CgCFc8UeLXcdGjtK4ui5EwooNzgpIoW5IeMuG51Kp1d6sys48eaBeg70vgE4X Elqg== X-Gm-Message-State: AOAM530WxlKi4XHfLwqa5CZ2DhzOXaTUupWyrkSGzoGOk9pWV9Fv+VaF B716Q/GIyVeE7FYWI9AsduQ= X-Google-Smtp-Source: ABdhPJwKI757lYhsdHDtz8UxhTxBaxRIcnzZHMPq7/Jj17wwG0jI4gLejro7K3tzb1xnh2zyr/3d0w== X-Received: by 2002:a1c:22d7:: with SMTP id i206mr4087798wmi.186.1591104587735; Tue, 02 Jun 2020 06:29:47 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id l204sm3935720wmf.19.2020.06.02.06.29.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2020 06:29:47 -0700 (PDT) Message-ID: <6d394b9c1d962a15d589e42c6dccc3fda45f4de3.camel@debian.org> From: Luca Boccassi To: Ori Kam Cc: "stable@dpdk.org" Date: Tue, 02 Jun 2020 14:29:46 +0100 In-Reply-To: References: <1590939369-60764-1-git-send-email-orika@mellanox.com> <652e8efbfbefc802ae148ef869a2ef11ff4f0939.camel@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 19.11] eal/ppc: fix bool type after altivec include X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, Yes, it's part of your patch. Probably some build files machinery missing. I do not have a ppc setup either. On Tue, 2020-06-02 at 11:27 +0000, Ori Kam wrote: > Hi Luca, > Off list. >=20 > Can you please see that the rte_altivec.h file was added? > I don't have a setup with ppc.=20 >=20 > Thanks, > Ori >=20 >=20 > > -----Original Message----- > > From: Luca Boccassi > > Sent: Monday, June 1, 2020 1:07 PM > > To: Ori Kam ; David Christensen > > ; Beilei Xing ; Qi Zhang > > ; Matan Azrad ; Shahaf Shuler > > ; Slava Ovsiienko ; > > Maxime Coquelin ; Tiwei Bie > > ; Zhihong Wang > > Cc: stable@dpdk.org > > Subject: Re: [PATCH 19.11] eal/ppc: fix bool type after altivec include > >=20 > > On Sun, 2020-05-31 at 15:36 +0000, Ori Kam wrote: > > > [ upstream commit f5bf02df3145f95b1ee8ed9dee67f4222ac42c8c ] > > >=20 > > > The AltiVec header file breaks boolean type. [1] [2] > > >=20 > > > Currently the workaround was located only in mlx5 device. > > > Adding the trace module caused this issue to appear again, due to > > > order of includes, it keeps overriding the local fix. > > >=20 > > > This patch solves this issue by resetting the bool type, immediately > > > after it is being changed. > > >=20 > > > [1] > > https://eur03.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fmai= ls.dpd > > k.org%2Farchives%2Fdev%2F2018- > > August%2F110281.html&data=3D02%7C01%7Corika%40mellanox.com%7C30 > > f4a48b032b46dbb97408d8061390af%7Ca652971c7d2e4d9ba6a4d149256f461b > > %7C0%7C0%7C637266028392843046&sdata=3DfJAaZN9tNjycMH30Gwh8ILZ > > %2FjuiYgBVN%2BwdAn6GAbcY%3D&reserved=3D0 > >=20 > > This patch breaks all ppc64 builds: > >=20 > > [ 136s] In file included from /home/abuild/rpmbuild/BUILD/dpdk- > > 1591003733.2dff15dd5/lib/librte_eal/common/eal_common_options.c:27: > > [ 136s] /home/abuild/rpmbuild/BUILD/dpdk-1591003733.2dff15dd5/ppc_64- > > power8-linux-gcc/include/rte_memcpy.h:12:10: fatal error: rte_altivec.h= : No > > such file or directory > > [ 136s] #include "rte_altivec.h" > >=20 > > -- > > Kind regards, > > Luca Boccassi