From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26AEAA0093 for ; Fri, 11 Mar 2022 09:02:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20F6B40042; Fri, 11 Mar 2022 09:02:35 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 37ED040042; Fri, 11 Mar 2022 09:02:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646985753; x=1678521753; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=mfvsRucSn/ZbTdgReLu2AoN52932dXlgZxKLbErEcC8=; b=bKFCPoZTSqmLm9/JtImqtTabOnEMGL3PKErX+MKTE0CABS/qNml6TYJv 60/UbQkDMQn+ofLIyd6SNpzTr/KYex+8ycjgBxwQwalMe37b042D9AL9x do5sGI9DodrqX5T5FfQiDmiSFC5tjslMBfJ9cyMQsOus4PvEEHGMscj/b 5bnEP+ogmJWF09fY4dg9fzj8qGcJpE/b120Sv1tVcH1stfpJbH5xIGGTj /BNLLG71Cld9wPGe785upURf/vdcMK3aV6E/dhXhm7gcqYKea7j4AplJ1 Lv8DVHyvv2h0uiF+aZCc0dCvXv3x+tt2JcEU9QuKzaianbSQD+91B121c A==; X-IronPort-AV: E=McAfee;i="6200,9189,10282"; a="255472840" X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208";a="255472840" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2022 00:02:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,173,1643702400"; d="scan'208";a="644856826" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 11 Mar 2022 00:02:32 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 11 Mar 2022 00:02:31 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Fri, 11 Mar 2022 00:02:32 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Fri, 11 Mar 2022 00:02:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fKaCuuZ6usHs/FD3FveH4hnesVcUE4Eoe1qTy2U05Ggvz/+TjQFSRh9EiACUIDB0+xSBQez0FGpTuU41TMj6gwKzI2VuA2eFxasDu93v2DrbHxpwGDDZcMuNpXYMaU0Kt9d391SuopmKkwbtDwscONvz1rZPWOQd79vV5bBjNKTJTD2OxBmk6/0NA5XhnGsN5G4mcXkr4Faf5Vo88a4oA7ezVOkgNpbmripIx8sD+jNIlmYYLadIPNMGevVIxVauXsQfY/udDfIkG1bacKcQi4wVrELg+usfAph+SnayajzP0ySNowf5qjUHkzTKS+ZL8EKx1Z6btlsSO5q1EPLbPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/XnJHeAJUvPW/r8bBcFw0NzmSZqzb6S6MQHIgKdmB4U=; b=UFQQ8RmktmCOpC2a2q4j6jfYILsis497cZvF5pmVbMu+x7VPVyaQj5VulOxbmGWkEztdRNovJDWL3bfald+pnSLvEz3X1PrCqDuuGZTq5OdavT4A7T0fHuXNF0Tbm189cU+hL0QkYIUbdOEVhr/qsA1+Ur+h0F+y3rqSxWwPZ1ditKYFZGQjm2drPj5C44l18GNwZPWCawgmVN+N3X6IFf6hclJzbkeYU851XQ/5crlVCyr3kwtVPZoxutXPMNx8fOxrq1LhKeChxXzVc99qLLAsJN+p4b+EE0l+R9qCd0QGiwyXoXayxCqqp77dWz+uEzt/omRpIg5l1iAoL7ux4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by MW3PR11MB4732.namprd11.prod.outlook.com (2603:10b6:303:2c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.16; Fri, 11 Mar 2022 08:02:28 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::bcb3:2b8:38c7:1567]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::bcb3:2b8:38c7:1567%3]) with mapi id 15.20.5061.022; Fri, 11 Mar 2022 08:02:28 +0000 Message-ID: <6d546177-6bb7-5e0b-817a-7e2551d7a0fb@intel.com> Date: Fri, 11 Mar 2022 13:32:16 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments Content-Language: en-US To: "Liu, KevinX" , "Zhang, Qi Z" , dev , "Yigit, Ferruh" CC: "Yang, Qiming" , "Yang, SteveX" , "Xing, Beilei" , "Li, Xiaoyun" , dpdk stable , "Zhang, Yuying" References: <20211224150925.3296471-1-kevinx.liu@intel.com> <20211229093702.1930214-1-kevinx.liu@intel.com> <20211229093702.1930214-3-kevinx.liu@intel.com> From: "Singh, Aman Deep" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BM1PR01CA0143.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::13) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c3f91231-7e76-43ce-99b4-08da03357c0f X-MS-TrafficTypeDiagnostic: MW3PR11MB4732:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sySuuEEXxSiIujOzKTnxTeY/ia7sQWTHVnz3U7YwAiwXX9NtTYyWQsXpM9BCiFEwy5FuiU4DxO3S71aGmm/fZElK26BebVpzaMYYmQ83CISkgot1vQbljX4x+zMFNmjU9etnrYpXzTlZeLmUDN8J1ncKIO/CUe3QVzwmadTNzU9zEoDl7YTJFRdhVAnCAamLFOY6DigF9mn2LIn/2ZWIPRN2ZtPn2LGvgshUetKwbxl8GV3SdtXihlbz2qwm2E1u/azMzvaVaMRDZG0rVCvUgsRNxUGeNizTuZPV3MVe9x0fn9xrgGXcUG4zCnxctCVCRbdVXkRspmmQN4voBJYEONoFwDRVJIelKLZAmkTSpzxX15XbZH7mGxscqIf/s8IfoQ6E1hU2jxPz83oSb0348bnMOCBMGXdVwP06svi0dfl5WAHUTKXH/mp8sNw3k1bNke1a3o9jeFKxxXd+p9D08PNLYb6ASP73FHxZwIRLKSYRMx0xLBIX4zX7vgzdGGOl/InKajBwpvrNYOD420mhZFqDEMP6ljhJGYY2EvJyTjZp9vuiyuvQ9evaw5QCZtisI8+icJNTIfNb7109j8KQGJxZCZre2cTALMWDgvkwFdt4CpTuLOF5zITpxMoqLj1bAoa2yxJV9oyNH9gL7h5LxSNRkRtjuTxFvE/0p3gx1HLGYFJlCrpK5DJrSQVxu0cmKz85Cnu5vVMbiUnDef6xNR9gfWv+XyzVV3BgcAPAbhM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6486002)(83380400001)(508600001)(5660300002)(8936002)(450100002)(6506007)(6512007)(6666004)(53546011)(2906002)(107886003)(4326008)(8676002)(66946007)(66556008)(66476007)(2616005)(186003)(26005)(86362001)(82960400001)(38100700002)(6636002)(36756003)(31696002)(316002)(31686004)(110136005)(54906003)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cytVck44OHVJQmhaSmI3N3k0bk5RTTMvaU9hSXppTjVod055eVVCQjJjMUhi?= =?utf-8?B?cm1JM3BueXlJd0Q5WDhPU0FWaFZQdlJxQXJ4ckF5WCtudE5zeGRjVWpBOWxr?= =?utf-8?B?YVBueWJvY2xMU1UxM3ZxeVZxOE84TWtuZjdObno2RE1YS3dLMzdpVEFTMGVJ?= =?utf-8?B?NWVUeHRHNWEyNVRqZzNwbWxhV1lsNHdHMzFhdHZkOWpTeitvcFY1eXVTRlJT?= =?utf-8?B?Z0tkWmkrbHhZTFJLaEV5ZHRXM3JkVnhNdjlSMEg4bDFWalRZekoydm91VlJE?= =?utf-8?B?NnZ3ZldvaE1VV0N4aldrQld4T3pCNWdCR2UyT1kvODNReDJ5Wnp5ZEN2Wko3?= =?utf-8?B?YXlOZWZYUFpDejdlTjRYWFl4NktCanZqVlZFY0h1SDRScllYTGxGUlEzR1k4?= =?utf-8?B?c1BkcGM4bDRUVUlRU1JsSUl3ZUVXTTRCTG9TVnJLcFp1R2VLTTVvc1hNYkJH?= =?utf-8?B?cDRTY1B0YXFLUkJWeFpja2gxTkJPVUpIdWFMcFQ2M2JoVFl5b3VzMDdSU3dx?= =?utf-8?B?TFpaeVpKNFdMN2JoVU5uQ2pVei82dWQwNVpQR1BrYzd2TE14UTIrK21kSzVo?= =?utf-8?B?Y0c3c3JiTGNjbHBlcWk1K2E2SXZBZzR3aTkzT0F4cUhhMk9DSkFOR0d5OXU3?= =?utf-8?B?QTYzK1BNU3l6T1J2VEVkc2pZQlVQT3JDdnFjMzQ3ZFdwZktEN216WFAzVnNF?= =?utf-8?B?cmZvMWlpVXgzNVdUZ2ZwY2J0UXpPc1h4NXFNRlBHOXBoYlJsWis5OFFtY0dL?= =?utf-8?B?S3V5cEdpZXlHUEplai9LRE1FckZybjNJUTc3VXNBL3RDY2V6S1pCdzQ1VE5P?= =?utf-8?B?VG5qc3dCRm1NRWcrL051eEliS29PcHZBMnQ2bVFkbFU1Nm1YMUVrSmgrVkl5?= =?utf-8?B?b0U5cTFHT0V6VGZyaGl2WHVySWxndkliaHlkYzYzZDI4RTdkTWowQU1OcGg0?= =?utf-8?B?RmtsSWtiUU00aGY0VmxWWlVDSlFvVWRqTXRsd2ZnYW9HQW4wL1dNTTBCNHA4?= =?utf-8?B?TjgvM1E3b0hqUUEyK1JvNmJ5bTE2LzZoMTkxaWhNU092L0RkRXAydy8vR3pL?= =?utf-8?B?NW5lT00rZk1paDJBcE1Jc0t6NGtmdlN4VlVaVkV6S0xBcFBWVWIyeEYzN3Fv?= =?utf-8?B?R2FhWmhNTElsOXQweWk3R2FubUtyQ2xCMmZKZ2l5YlkzOWpGVFNNVEs5RnBs?= =?utf-8?B?bHZWbnZBN3J6TUFWekMrdklSMEtJRkJvMXF3SWVpVkMrcTlhSWVhTzQwb2NN?= =?utf-8?B?ak1mQ1NYQnFEb2RrM01KUnpaL1Z3ajNDaDBnMVl0OXFtdncyVVUvNFlqWUlu?= =?utf-8?B?NHFkcVgxSEJRakx0OVNrOW9EVW5iK2Rzc2JtMnRvbkE4QVVlRC9jdzUzdHl1?= =?utf-8?B?KzlrY3dRZGg1VHZPbHlzL05NL3NxMFVIUldDaEMrd05YTVd3cWd6RllBZ1BJ?= =?utf-8?B?V1orbXB3YU5xWkJTUGU5cmFuenlhMVNzNE15c0lSM1V2cFJBbU13dG5xQ1Rr?= =?utf-8?B?MWxUZWNoZERSSFZDeVFDS01hNTRYaGtDSzRKM1hXVHRBV2s0VVVvY1BxSDdI?= =?utf-8?B?Rmphcy9sTVpxRGhENEROU09EK080ZHpWZ0VhY2RhUWVFQ2E3dW1CVDVCaWo4?= =?utf-8?B?TDRoME9jWlppWktZeEYwZ3NsQUJhZ2tFeDJhUk40TDJrcFlMY2xHTm9MTyt5?= =?utf-8?B?RVZTV2FWaFRNUHpPZkdZQWF3Y3pwV3U5S0Vvb1VBdytCNk02dG9xeGVzYmFx?= =?utf-8?B?TTVxMHlBYTlXOGJ4TUtMYzFZbHcySzRRREgrL29sRkNadkdNVjBrRnVyaHUr?= =?utf-8?B?bEFTNmQ1Q0lNZjR3Y3ZuOG9ESnZVSUY3azB3TFZlWS9DNlJDc1NscUNwR1hl?= =?utf-8?B?TWhOOXlpL1FPM0dFSGFnbitGWitHRHVjMWR2SkdJL0xYNmlMTm8rSzhhaTda?= =?utf-8?B?ZkFBN1pTNkFtRXJ4UkVMMm9nYms0U2VFQ2xZOFlhTTlSVWx0aEpxZjN0K2dM?= =?utf-8?B?ZnB5RVJQbTJwU2xjTUdwc1YvVzNXcUtsbG5jYmwySHZxaFNHaExTejFLM3lR?= =?utf-8?B?MGJpMHJRVXd4VW1Xd0NFMTJkRGlWcVlIUEhHclh1SGpLVXlueXNhYTNQc292?= =?utf-8?B?cjc0UUlIQzhjUkRoUmhWeWFpZTlqc1VjMnZkVnRHU2VuL3VEMlY3Tk9KcE1p?= =?utf-8?B?Y1dweWh6d2tXellPRzEyazU4QUtBV1FNNThtRmJ6ak5qbDNVU3FTamY3WmhV?= =?utf-8?Q?a17cslBaAMKL5uLUPXxhEkp2VyK/VXUD83w0l2VA8s=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: c3f91231-7e76-43ce-99b4-08da03357c0f X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 08:02:28.0580 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1H+SRfWmpwLd7dBBCMBevW7IoOq5LVU4JNIPL0nFe531TowKXRriDU1rw6Y7Zpz3LiId+X2hrUZkfIiJnann/C4vZp44W5uuCjHWTy58SlQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4732 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Kevin, On 3/11/2022 12:34 PM, Liu, KevinX wrote: > Hi, Ferruh > > Yuying has already reviewed it days ago. > If you can, I hope you can change the status as soon as possible and try to merge the code in RC4. > Thank you. > >> -----Original Message----- >> From: Zhang, Yuying >> Sent: 2022年3月3日 14:30 >> To: Zhang, Qi Z ; Liu, KevinX ; >> dev >> Cc: Yang, Qiming ; Yang, SteveX >> ; Yigit, Ferruh ; Xing, Beilei >> ; Li, Xiaoyun ; dpdk stable >> >> Subject: RE: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi- >> segments >> >> LGTM. >> >>>> -----Original Message----- >>>> From: Liu, KevinX >>>> Sent: Wednesday, December 29, 2021 5:37 PM >>>> To: dev@dpdk.org >>>> Cc: Yang, Qiming ; Zhang, Qi Z >>>> ; Yang, SteveX ; Yigit, >>>> Ferruh ; Liu, KevinX ; >>>> stable@dpdk.org >>>> Subject: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in >>>> multi-segments >>>> >>>> Testpmd forwards packets in checksum mode that it needs to calculate >>>> the checksum of each layer's protocol. >>>> >>>> In process_inner_cksums, when parsing tunnel packets, inner L4 >>>> offset should be outer_l2_len + outer_l3_len + l2_len + l3_len. >>>> >>>> In process_outer_cksums, when parsing tunnel packets, outer L4 >>>> offset should be outer_l2_len + outer_l3_len. >>>> >>>> Fixes: e6b9d6411e91 ("app/testpmd: add SW L4 checksum in multi- >>>> segments") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Kevin Liu >> Acked-by: Yuying Zhang >> >>>> --- >>>> app/test-pmd/csumonly.c | 6 +++--- >>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index >>>> 02bc3929c7..c235456e58 100644 >>>> --- a/app/test-pmd/csumonly.c >>>> +++ b/app/test-pmd/csumonly.c >>> >>>> @@ -513,7 +513,7 @@ process_inner_cksums(void *l3_hdr, const struct >>>> testpmd_offload_info *info, ol_flags |= >> RTE_MBUF_F_TX_UDP_CKSUM; } >>>> else { if (info->is_tunnel) -l4_off = info->l2_len + >>>> +l4_off = info->outer_l2_len + >>>> info->outer_l3_len + >>>> info->l2_len + info->l3_len; This seems OK. A similar miss is present for TCP case also. Can you please do the same for that. Line 537 >>>> else >>>> @@ -536,7 +536,7 @@ process_inner_cksums(void *l3_hdr, const struct >>>> testpmd_offload_info *info, ol_flags |= >> RTE_MBUF_F_TX_TCP_CKSUM; } >>>> else { if (info->is_tunnel) -l4_off = info->l2_len + >>>> info->outer_l3_len + >>>> +l4_off = info->outer_l2_len + info- >>>>> outer_l3_len + >>>> info->l2_len + info->l3_len; >>>> else >>>> l4_off = info->l2_len + info->l3_len; @@ - This change might not be required. As for normal packet (non-tunnel case) l4_off = info->l2_len + info->l3_len;  should be valid. Please re-check. >>>> 625,7 +625,7 @@ process_outer_cksums(void *outer_l3_hdr, struct >>>> testpmd_offload_info *info, if (udp_hdr->dgram_cksum != 0) { >>>> udp_hdr->dgram_cksum = 0; udp_hdr->dgram_cksum = >>>> get_udptcp_checksum(m, outer_l3_hdr, >>>> -info->l2_len + info->outer_l3_len, >>>> +info->outer_l2_len + info- >>>>> outer_l3_len, >>>> info->outer_ethertype); >>>> } >>>> >>>> -- >>>> 2.33.1