From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA6EEA0524 for ; Fri, 4 Jun 2021 08:35:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AAA04003C; Fri, 4 Jun 2021 08:35:40 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 1D94E4003C for ; Fri, 4 Jun 2021 08:35:38 +0200 (CEST) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FxCcc1CJmzYqkr; Fri, 4 Jun 2021 14:32:48 +0800 (CST) Received: from dggema767-chm.china.huawei.com (10.1.198.209) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 4 Jun 2021 14:35:32 +0800 Received: from [10.66.74.184] (10.66.74.184) by dggema767-chm.china.huawei.com (10.1.198.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 4 Jun 2021 14:35:32 +0800 To: Christian Ehrhardt CC: dpdk stable , Xiaoyun Li References: From: Huisong Li Message-ID: <6e45c5cc-1643-910e-5963-dfa20b4d134c@huawei.com> Date: Fri, 4 Jun 2021 14:35:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.66.74.184] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggema767-chm.china.huawei.com (10.1.198.209) X-CFilter-Loop: Reflected Subject: Re: [dpdk-stable] "app/testpmd: verify DCB config during forward config" is incompatible with the 19.11.x series X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 在 2021/6/4 13:01, Christian Ehrhardt 写道: > On Fri, Jun 4, 2021 at 3:52 AM Huisong Li wrote: >> >> 在 2021/6/1 19:24, Christian Ehrhardt 写道: >>> Hi, >>> this commit was targted at the stable series: >>> >>> commit 43f1f8261136852357057b78aa49d354beaf3931 >>> Author: Huisong Li >>> Date: Wed Apr 28 14:40:44 2021 +0800 >>> >>> app/testpmd: verify DCB config during forward config >> The above patch does not need to be applied to 19.11.x, it is ok. >>> As part of that it removes pt_id as it was the last user. >>> But this does not work out without the following also in place. >>> >>> commit 08dcd187068666c96e8a16604a1c96160ed310e9 >>> Author: Huisong Li >>> Date: Wed Dec 2 20:48:55 2020 +0800 >>> >>> app/testpmd: fix queue stats mapping configuration >>> >>> Since the latter is rather massive I have for now dropped 43f1f8261 >>> from the queue for 19.11.9. >>> Please consider creating a backport or letting me know that this change >>> isn't meant to be applied to 19.11.x >>> >> BTW, the first patch does not conflict if the second patch is applied to >> 19.11.x first. > Hi Huisong Li, > Yes it would apply, but it would not build. > On 19.11 there would still be uses of portid_t pt_id left and since > in this patch it was removed from start_packet_forwarding it breaks > the build. > Just adding back the variable as a backport without further > investigation if that really would work out well and some testing > seemed too risky. > The "portid_t pt_i" is just a local variabl. If it is still be used in start_packet_forwarding() on19.11, let's just leave it where it is. I don't think it affects anything. If that might be a bit risky, we can ignore this patch.