From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF843A034C for ; Wed, 23 Feb 2022 15:01:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB4F6411B2; Wed, 23 Feb 2022 15:01:38 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 39501411B2; Wed, 23 Feb 2022 15:01:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645624897; x=1677160897; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=RV6Lpz9rGK7kPb3Oi9dwJANWsq1qOo74QF1oH/VXPk4=; b=FrQgbtF2kZwBllAZwya6LH8e2sKtQT25kX/tU1r+xOLheRnxuEvu2QWN k5Cf7yZsSBO1djIaHJjkCj46X4kQ5dqU+9ljL4lVQ7gm3MSiWwV/qHPZa jY7mMWhMDN+haLf5xG8tAtH7nNcMIrswsNP+PX5LDLcMcq+VgMz+/lnSV hqyZyXEUa0/Dy9uO2FvXFr9ZWZmNpNxYVUQo1cJgK6tsr3hXTrVKdl9Ag PfgURrV3y5SnBBn+prbXJoXCwe3NENkGyfmt3s3bKWWnk3ZUZrAm5H0Go 5zFx5gQTAItW/Xz1YTWOIn+2SDmQQjrKvmziq611F6dSZBjn7r05hQk2w A==; X-IronPort-AV: E=McAfee;i="6200,9189,10266"; a="252160726" X-IronPort-AV: E=Sophos;i="5.88,391,1635231600"; d="scan'208";a="252160726" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 06:01:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,391,1635231600"; d="scan'208";a="543322746" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga007.fm.intel.com with ESMTP; 23 Feb 2022 06:01:36 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 23 Feb 2022 06:01:35 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 23 Feb 2022 06:01:35 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 23 Feb 2022 06:01:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AlyNOi+3g5Hk5V38m9UhM3LgTFQP3cpvlFltKEAi8Ui4xM2TRiMBaCtWhDSxE7FgEWfvohXQkY3gZLJ/wWpoaGhVD8LHQqgZkvFcqkJdogrc396Osp5++1AVaJI813j8O52bds8leo7lV3QyfBtZGDPdHRv8tkDggmfxI4dFW53/nYgjGJdhxACOhIEZyhJY1fedPC+jrJKU0ZhklmVc6cuVpUJ2OEREU9JM7Hf6cNwNzfWaknp3DXBYSDzFItL+OnUFKqVeipeW6DGhiNyOmcQm3gEJH+Uue+FpdnBdN6M7/kgr+nD8q2MPRsWSWP1EvhcL+A4KufZTULJqoEI8iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+4xfs+dkHLRcF+IIBu6NSWzQNOAxvcWn2n9JPT/YP7I=; b=TrW8yYV59DhuxRkhJ2rNCh7OlS7ngLEb9YNiRro0Pq2lybDz/iH+1l2JRSR94dOaLGT1/IiJygomGUQAHOFR6ZgFlK7NcUdiVj0cIoV46Mxxv58VwHIRC+7w86LH9CEqkpFdtEJLigoKMet6fHYiT22fY3zJWVTpFbv3lYFoOJ4FT/fONcnSfTemClNGrsf+uaNvIiCkb/m2+NFXhQGzPNCVf7XOxX/pF04HhEzFdP2lNuJY7lHOY+otQaONubaJsQYIyhqt219Vu4clOH73jM8XL2mksc46gYX7q4JVwatKmfm14yNUdOLkoYYgo8U3FuGGAywx7YDnLAhfkPk3AQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MWHPR11MB1615.namprd11.prod.outlook.com (2603:10b6:301:c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb 2022 14:00:59 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.027; Wed, 23 Feb 2022 14:00:59 +0000 Message-ID: <6e932425-f978-e5cb-d6d2-2cfdb916acaf@intel.com> Date: Wed, 23 Feb 2022 14:00:53 +0000 Subject: Re: [PATCH v2 2/2] net/txgbe: fix debug log Content-Language: en-US From: Ferruh Yigit To: Jiawen Wu , CC: References: <20220223102857.24816-1-jiawenwu@trustnetic.com> <20220223102857.24816-3-jiawenwu@trustnetic.com> X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0023.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::35) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 78784138-d93a-48a7-251e-08d9f6d4eb62 X-MS-TrafficTypeDiagnostic: MWHPR11MB1615:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s3j2e8ebimmRAZthwAHaZneByw6S4wACgKK0S0K/ppF6thWK0VyPSoJsXu16uP9DPt7wstqEN/sX4ZRSysdPE3rgD8Y9y1sXJikGSet525Nevsub9kNoY2N25pWS2/kQ33MSKrRJcaZbVCG3nK6yzQoG8AFJkDUF1uFvhuonJ0nBymbNNn8qzrTYs1WB1v9JpPiFtZecuRmrlMFMOS0le1e6DvpuFy2u6WUFRem/ZqNt+nxDUNVQVfWlCGKmRqFxnvt/hFI0WGx9Ce7ZbezkH3600rhyOh1t2UzbT12N0KfbYEP+jSXLkWYcTHFw9MzLuaDch1dtgwQ5kj0JnQAaKpgLNWYAYHodF/OuP9pzRyGhF3Y2HkdNRkrY6BUz/Bc5wxI54nHE8dadrYQkA7HSV4dVKTNqiNWMIZ4ThcjnR05a/S1s4Lb7IQdirS50PBHLAS1AUk2PLpm9nHXzRcjNwFg7l8ZVtt5Ta1GhGfSpPC2vOKddJl/aEWOH/q0N244UWaDW8554czN8SD7v9nBWUq66O5EhUtM6HaNs89pskHaJkKwp4YBYTtOjyAk0/hswUjvThc5xDB2f7cQkS/3FvW/45jPjCndUnVEHU1VDU9uIa+qhYEo2lxf6Z/3p2LaEKHZ+a20tjobdJui4UeeTrNSoj9whON6k0jZhWT6FqODJyJClMpro4craHJqU1pXFUJ/v3rMvKNkjm35fbdyOSQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(6506007)(26005)(6666004)(38100700002)(82960400001)(6512007)(53546011)(2616005)(316002)(66556008)(66476007)(4326008)(8676002)(66946007)(36756003)(508600001)(8936002)(6486002)(5660300002)(83380400001)(2906002)(44832011)(86362001)(31696002)(31686004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?alk1ejFudkhPU0wxTXNZYWRxNk5hVzZGQWtCUjVPMG1CczhGN0ZsbWhUU2pO?= =?utf-8?B?V3FwanFrekkyRVZySHBTN2V5VGY1bDlET3NTTi9hcDhiT3VRNzRaRWRBNkpX?= =?utf-8?B?QkpPZzNxOFZUcTltd21PdllWenMyWmpVRmRpVWpYNzYzcUUxMmdISWp3YjIy?= =?utf-8?B?am1XdTM2TFhtRDdWRUVOVThEWUZQZTZEWUJuMkZtQ3lkZ1pOVTJPWTRMWDlW?= =?utf-8?B?WXRWOE1meE5CZnJJZFlieTF0RkFyYlFUcjUxckxiR0NhM3A0U0NaWVZNbW40?= =?utf-8?B?cjVucitIdERjL0RYRW93eTAvc29WSWp6UnNlWFVyUXFTcDFOOEtldHpERWRq?= =?utf-8?B?RFQwRUc2dFdKWW1PWHZFWUJKNUFGTWtRdG5rdWJZYWh0dHRsVkpGanREb2Fx?= =?utf-8?B?WWxad296RU1JSGFCekxOQng5U29rcVh3Si9tZzNRbFRwVGIrNmFmb1ZJUVEx?= =?utf-8?B?MTlTWCtGNThiTVFGMnZNMUFZSW5KdVJES013emJtQTVOK01uaWt1aFpPMi9p?= =?utf-8?B?YXFIcjE2LzFnREt2aUF1YXZKT01YNS9ObzVVN3l1NjI3RlRMcC94eDJQdU1X?= =?utf-8?B?L2JScmh0QlpKdVVpNXhiaGQ3R1J5K2VRQytRM2N0aWFKa3RJN21XQVBwMGZE?= =?utf-8?B?MjlGVFhSZ3YrQU9HMG4yVnhaaWgyNDhkTStGUlpmN3IrSlkrbStXL0N5a09M?= =?utf-8?B?ZEdQSnluaFVVRnlGQ1M1dXFXWU9WMUVCUURwV3Fub0NmY2FSMWNyLzNwOHZ3?= =?utf-8?B?d1V6LzRkVkljR0tUTjdpRHNSYmh6d3hNOThPQlBHMGZ5aDcrVW1LbllzaWNz?= =?utf-8?B?ZTlrVGljYURuZkdwd3NuS2x0c01Vek8wbkJMRE5RbVppT1FmbHdPbGwyUHUv?= =?utf-8?B?Uy9nU1MrQnNlQlBDaUtkZGpYSlo0cU9QK05GZWEwNGE2TjBNNUtxV0g5OWlO?= =?utf-8?B?K0lQeTJFQkZZOWJhYkRkaEwwekVMZi9BYUNSczZzeFA2ZFo4aXBjc2pJOU80?= =?utf-8?B?Y0U2Q3hLaC84RGRNeW5aQkdhRm94OVlteERaWVdybFljcjVKS2E2N2hmc21u?= =?utf-8?B?YWFld3FDc1ZOY0lBUldxZ1l2dnM1NHNoeHVmSnNiRjZBcU4vNUZoSHRTRjV0?= =?utf-8?B?LzlvNXlCY2R4bWhqTDlYWGxiVHNSMWl1ZUp0WGkzWG1lOFBQSmlWazZFbytt?= =?utf-8?B?aEJGblF5eFFpbGh3QVdmdVloOTNRbDZDNnYvWjIzQlBMRExZVTg2SGRFekt2?= =?utf-8?B?aVE0NWVWU0hJMFcrS3FHZFFTTlcrcWgyNDBrM0tYdUVpejloT2R5eWdpYmpR?= =?utf-8?B?a0I3WFB6U1ZFcFEzdldKZm5YR2swS3Nyd0dBSndKNUxGWENMOWhXLzcwaWJs?= =?utf-8?B?OWdIamdBQnZtb2t4MWZ4WS9BeDJMT3B3SjVBNWx5T25walBBZzFwVENrS2lu?= =?utf-8?B?TG5VQytwb29aWGVDNk9LZnVLbmtqS2VRM0hLL25uMWRQUmJiTXdhaVJoZUc0?= =?utf-8?B?Ry9LR3o1S0pZYW5HVjRmRTJ5RE5pK2czTUhhalYxOHA2b0hIV0hWNm9jR1FP?= =?utf-8?B?QjFId2JGSUhFWm5hK2hYZVRRVkVsZ1VPYURWZW15NUR0a1Vpa09EbkViWlRG?= =?utf-8?B?d1dPaDNTdkhZbjBRMWFWdE9NNzZzU09RRXN1OWlLNGJENCt0ZWFpNmFTcHVS?= =?utf-8?B?cElpQzI5ajNHaTl4Q3pHKzdkUFdrelhFSWtPS2NoaGdLVTA5V0RNV1VvUlpQ?= =?utf-8?B?dDhXWDNoNUczZU83TUVwb1hXZGtEK1Mzcm1PVTNkZUEwS1FQakwzeEJQQlo0?= =?utf-8?B?MnA3R3RqUjNVdEVXeEZoWElPVFJRV2l6Ky9MK09wSmZSYU9mWWllMmhVVkQr?= =?utf-8?B?dFVCLzRmNVBtbzNNa3JVeGxMaEkvY1EyKzFNanRYSUM3R1RFNUc4czBDVmlt?= =?utf-8?B?cW9MdkxoMGl5NGFuRms2dStrY0tNTmNVdEFnL2p5MlVkeHovVmtSK0ZyOXNa?= =?utf-8?B?cVQ2eVdOUWRNd2doR29iZ2R2Y3dmbUFUN0FvcnZHZUdOTEl5NEVJaTgybjEz?= =?utf-8?B?MldHVTdoajZpQUxyTzNpT1NtblRsUktJcjh0bWJYQVE1TCt4a3d0WHIzeW84?= =?utf-8?B?QWppN1IvZkxKK1cwazZDbGNPaHRkMytvQUpya1lHMHlDNGVsa2RXdzM5dWJC?= =?utf-8?Q?y+a+DePUgefqVT07A1jK1gM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 78784138-d93a-48a7-251e-08d9f6d4eb62 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 14:00:59.4424 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J22TnRHC4CrsD1eeBeReuoAsZ6PXGzSsYjgK8PV2Mgo/4ZQZBfs/rmrB//vj/7x5PSb6+wf6yL0didAilLHzjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1615 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 2/23/2022 12:49 PM, Ferruh Yigit wrote: > On 2/23/2022 10:28 AM, Jiawen Wu wrote: >> Remove 'DEBUGFUNC' due to too many invalid debug log prints, unify the >> DEBUG level macros. >> >> Fixes: 7dc117068a7c ("net/txgbe: support probe and remove") >> Cc:stable@dpdk.org >> >> Signed-off-by: Jiawen Wu >> --- >>   drivers/net/txgbe/base/meson.build    |   2 +- >>   drivers/net/txgbe/base/txgbe_eeprom.c |  41 ++---- >>   drivers/net/txgbe/base/txgbe_hw.c     | 202 ++++++-------------------- >>   drivers/net/txgbe/base/txgbe_mbx.c    |  38 ----- >>   drivers/net/txgbe/base/txgbe_mng.c    |  21 +-- >>   drivers/net/txgbe/base/txgbe_osdep.h  |   1 + >>   drivers/net/txgbe/base/txgbe_phy.c    |  84 ++--------- >>   drivers/net/txgbe/base/txgbe_vf.c     |  12 +- >>   drivers/net/txgbe/txgbe_logs.h        |   7 +- >>   9 files changed, 79 insertions(+), 329 deletions(-) >> >> diff --git a/drivers/net/txgbe/base/meson.build b/drivers/net/txgbe/base/meson.build >> index 7a30191472..09da79af40 100644 >> --- a/drivers/net/txgbe/base/meson.build >> +++ b/drivers/net/txgbe/base/meson.build >> @@ -22,6 +22,6 @@ foreach flag: error_cflags >>   endforeach >>   base_lib = static_library('txgbe_base', sources, >> -    dependencies: static_rte_eal, >> +    dependencies: [static_rte_eal, static_rte_ethdev], > > Is this because of 'RTE_ETHER_ADDR_PRT_FMT' macro? > If so dependency should be 'static_rte_net', not ethdev. fixed in next-net while merging.