From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 177BAA034E for ; Wed, 9 Feb 2022 02:42:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 084064067E; Wed, 9 Feb 2022 02:42:29 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 4A4104067E; Wed, 9 Feb 2022 02:42:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644370947; x=1675906947; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=R1l4lIR2OS4l7Yb/fVD6+3CnOlUo4V7EGSWlL7PG1z0=; b=fqoacmqxKPMCPueSmEzvcUzPaSYhrHgYVyXbXH9rE9lfiuaMbg7ckS38 B3rskVLKaskU0Fam2l0eL94siBvTTfOfXz9inPfNlOu0kepPH02hhSa6p ULplKowRrDqRRQFnWyCFWmFd9ehMlrndIFkhSwHgLdOUNgig79K4Or3/N mbk9TeNKyLL+m6NF4ZV06d808lq7JlugJA4jJ9spITsdbF69vK92D5bIC 2SWoP4AsOvhoQk68lvVUv+P1QBgASOFmD/tO54DKMx6vC12RtPcgA0B0Z 9GPWTn/EB9eXEh68hHYjlBWPQy8MTPF8TF4mN0MJuvWdyYdKYMNTZxQrF w==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="248857778" X-IronPort-AV: E=Sophos;i="5.88,354,1635231600"; d="scan'208";a="248857778" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 17:42:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,354,1635231600"; d="scan'208";a="482156513" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 08 Feb 2022 17:42:26 -0800 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 17:42:25 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 09:42:18 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2308.020; Wed, 9 Feb 2022 09:42:18 +0800 From: "Zhang, Qi Z" To: "Yang, SteveX" , "dev@dpdk.org" CC: "Yang, Qiming" , "stable@dpdk.org" Subject: RE: [PATCH v1] net/ice: fix dereference before null check Thread-Topic: [PATCH v1] net/ice: fix dereference before null check Thread-Index: AQHYG/0/yHQ1YlFUZkWNc/gvT3dhA6yKdGCA Date: Wed, 9 Feb 2022 01:42:18 +0000 Message-ID: <708b7e590f74420fa79395f44f79f56b@intel.com> References: <20220207082558.1349140-1-stevex.yang@intel.com> In-Reply-To: <20220207082558.1349140-1-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Yang, SteveX > Sent: Monday, February 7, 2022 4:26 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX ; > stable@dpdk.org > Subject: [PATCH v1] net/ice: fix dereference before null check >=20 > This patch fixes coverity issue by assigning the address of the "info->da= ta" > without "info" pointer check. >=20 > CID 375065: Null pointer dereferences (REVERSE_INULL) Null-checking > "info" suggests that it may be null, but it has already been dereferenced= on > all paths leading to the check. >=20 > Coverity issue: 375065 > Fixes: fd8480e61490 ("net/ice: support module EEPROM") > Cc: stable@dpdk.org >=20 > Signed-off-by: Steve Yang Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi