From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5DCD43EA2 for ; Thu, 18 Apr 2024 14:30:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFB1F402CC; Thu, 18 Apr 2024 14:30:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B496440042 for ; Thu, 18 Apr 2024 14:30:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713443457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zZyg3WXZq6MfLiNvFW452kOSo0Bmw39nlf772u02tWE=; b=Xu+mKuO1VU3W9p/F0tHx/YE4SdTRL7fQO1j8PVzHrfQtaIRtCDU8SIAoK/JcT4Acli2Mu5 ZctwgQfEte9wSIllJ04IYlU6zQ1cr7A5aAxoSg2vBPj+9fgG7aakCksfO0spvQFkp177WW Z0PvtkVUhtj5bIzfplYQePibq+Ffg/0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-249-35VX0RmJNXm13uOww4nP6g-1; Thu, 18 Apr 2024 08:30:55 -0400 X-MC-Unique: 35VX0RmJNXm13uOww4nP6g-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-343d3e1ff1eso602013f8f.3 for ; Thu, 18 Apr 2024 05:30:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713443455; x=1714048255; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zZyg3WXZq6MfLiNvFW452kOSo0Bmw39nlf772u02tWE=; b=RaA0ot5Iq8jT1O6xzQTCUFA8/Q0rX/MF4vGNE2NlomJWSFIekc8A0jGEFO2NfHRuAc bnQTjSZpcXTDX5PkZsyx3+XFehL04K4ibHRvy/fqyNa+dZjqCgq6ON0XycKAG7NU0fFK OFRb+uxfNhINRozJgdJahvzDVsCH9NYPP2ly2B1q0slGfTX0nHO23C72qAZegiL8gz4/ Rb/DOXYaa5fDiG9X5+g+MyStdfy8Ev/bS0hPSXPCqElo0V0JdljUW8b5pvW/vj4y/Jxy QCdkruY47Smuz7m76VVarGIdSSn1dCSB3eRK2SwlE40y9gW5bqodSXHW7TYXyH+kHN/J FNTA== X-Forwarded-Encrypted: i=1; AJvYcCVf2yGNd/8M+o7h+5E5+zjdrEy1q3b0b/Ir4+cGWlRf8AjpWms9iq6c2FLZO7ABrvbrPBWeyoXwQyJJQ6oMjmc= X-Gm-Message-State: AOJu0YyJUC0Zc1GfbXPqh+kAFMh+F3Z4hRUDDlMkD4Xbx3D20uY27o/o 6LrOhPMrjg+InTu6CWq7gW9qMNGU91NtNNKw68lMrd/QhukgnRdCR3Mya9R/vR2/rSS7Ji7S+uh 5F+1ZfPSEoJvYbWrXdPZ3kpxvIkvBlbyoB7qgIjE9RJwK X-Received: by 2002:a5d:6e09:0:b0:346:c746:28a5 with SMTP id h9-20020a5d6e09000000b00346c74628a5mr1735461wrz.56.1713443454824; Thu, 18 Apr 2024 05:30:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4B5+7lOyvJ69bvGbyfIg+srtJxWxiiwYA7ea0Yrjq4JK0FFepOnGPS0pOHM/t8L1eRnMOvQ== X-Received: by 2002:a5d:6e09:0:b0:346:c746:28a5 with SMTP id h9-20020a5d6e09000000b00346c74628a5mr1735439wrz.56.1713443454484; Thu, 18 Apr 2024 05:30:54 -0700 (PDT) Received: from [192.168.0.36] ([78.17.184.177]) by smtp.gmail.com with ESMTPSA id lv11-20020a170906bc8b00b00a555eaf25c7sm809274ejb.123.2024.04.18.05.30.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Apr 2024 05:30:54 -0700 (PDT) Message-ID: <70c587b1-0141-40f2-9a30-f65ee346b97d@redhat.com> Date: Thu, 18 Apr 2024 13:30:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 21.11] net/af_xdp: fix leak on XSK configuration failure To: Yunjian Wang , stable@dpdk.org Cc: ciara.loftus@intel.com, qi.z.zhang@intel.com, xudingke@huawei.com References: <1712577789-21352-1-git-send-email-wangyunjian@huawei.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <1712577789-21352-1-git-send-email-wangyunjian@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 08/04/2024 13:03, Yunjian Wang wrote: > [ upstream commit 955acb9594cec548ae57319bfc99d4297d773675 ] > > In xdp_umem_configure() allocated some resources for the > xsk umem, we should delete them when xsk configure fails, > otherwise it will lead to resources leak. > > Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") > > Signed-off-by: Yunjian Wang > Reviewed-by: Ciara Loftus > Acked-by: Ferruh Yigit > --- > drivers/net/af_xdp/rte_eth_af_xdp.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Thanks Yunjian. I have pushed to 21.11 branch. Kevin.