From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA1ED42DF7 for ; Fri, 7 Jul 2023 11:35:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE02E4303D; Fri, 7 Jul 2023 11:35:58 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2073.outbound.protection.outlook.com [40.107.243.73]) by mails.dpdk.org (Postfix) with ESMTP id 498E740685; Fri, 7 Jul 2023 11:35:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WsvcSx0NT3t9E8BMRNdm0Oz3iAXe5DY+wObxiXMu713ibGsd1PsSBGqsrL79BKtgedRsyBX2cD2pxf+eAvdTopTaJbThcjiDFaLIIFTQyaUgm7tvBAchiEQwbM9EZVFi2Q3XGLDGKhekQullYdCNj6Uj1dFTCZLxJEUvIWrGUwXu4UQzXQkdpqDoShhYhAOH+JDbMoIsbcS3Pd0EG0aWPkVIzLnh3B/fqfcf6eybPaTmQBSkuFBd8DFUqN/kUS0evfyzvA5JcOQaAlNku4i5v724GnM5fUSfGKdCJQGaY/tOs5N+zp6CU3jkHtTjNkcZg5PahY/KOOzKdsylEkiYlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fVby5xatrD7DudFzIr4iHCElXg2hR7VqkFiD89rr5vA=; b=dhRn/NLsTBUv5s+uf9SXhwpAj5bUiYHBlMDDYFqWOlxhZToLFp45jZe7OMSO33favJCbKA4LHwLnMmMDIlxU9/q8PMmt/zqV7X8IBPSJYGbD85arlFOZ7Fco5mnUsNST1zN4JcdqZUyXd2sIPQdjH7vkyIfVKomcztsHUTWYeQ95gf5tiQC4Pttax28ybrjjjKFl0ViziLEY6AT2fNwXMOp9pcJKPyY0umSqPUkHbbXJt/+67M0ZcIWJaBTCo/g4mArEC/+mrh8aTWkvrw1BjbzsSLh4hMIhova2AYqH86ix04thZ1J7ERqgCG2/xDUdYCIDT8p+dAmDfEDn8AejPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fVby5xatrD7DudFzIr4iHCElXg2hR7VqkFiD89rr5vA=; b=igN1egFJWgxg2TI/2qXTv5zB75LXO17Kt5I2MNqe+AQhYl2GcWrkN/eejgulxy9HEp0YrIxqim5xI3t3rE48AkDI/dKWZEKp/XgWhNUYGdt3T0rEC8b01o2b2BnRYan+TIiyVA+ao9jwOXbC6W9ExQTZGrXU40IZPp614dv3Vfk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4250.namprd12.prod.outlook.com (2603:10b6:5:21a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.25; Fri, 7 Jul 2023 09:35:53 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8%3]) with mapi id 15.20.6565.019; Fri, 7 Jul 2023 09:35:53 +0000 Message-ID: <70e6a9c5-7ba2-d978-6f68-154aaf6d9436@amd.com> Date: Fri, 7 Jul 2023 10:35:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2] net/failsafe: link_update request crashing at boot Content-Language: en-US To: Vipul Ashri , =?UTF-8?Q?Ga=c3=abtan_Rivet?= Cc: dev@dpdk.org, stable@dpdk.org References: <20211021115139.2634-1-vipul.ashri@oracle.com> <20211021214215.1633-1-vipul.ashri@oracle.com> <87c84612-4116-4fe7-a711-f5f364513c3d@www.fastmail.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DUZPR01CA0345.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b8::28) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4250:EE_ X-MS-Office365-Filtering-Correlation-Id: 406760b5-7b5f-459a-f53e-08db7ecd8e77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KkH/m5zNVQgybG74tXWadg5EDJj7rMlFZKDStlofneCTlq1xXj9Bbns5AZJ+nW3eBxeHwVD/W5x8pLxWGSM3cP3Y3K2k/nlmOciRz52r3PyQgl6mU4TyycVcsY+v9MJwPSGgWc9TNJUn7sB9rRzgaYXXjRd9U3laiGljX6oH5Z/O+KrQz4AcEq6LHhecFWiUxD6jaYy/QVYgx2hV+tASPTJUCCNV0BKGWKk/JBt8wMXICjvo4xHaeXPxbfgi6+z0CpJyLiT53FiO6o6Du8LE9bcvkG7MohNgcZBiWgwb4FyERMqvu0l/tQacsvVpfvSXLdHc+hSk6IhQSeGVmD7N6QiO/fKG2pPyZdUloJpF2DgPp7AfroXT4johujdbvyofnLK+9OU44rmKsxHEMM2a01jxFW/R4oQqkjqikeY0rUwWHeim/0QAHybxKfGLZ+daFK8uf7EcPKSJHxAocEMqWhZ/h0yJekp2p3tfkyENJCp00//a02z4OBd0mKwSYr9W+o0fdc6QYpB7CF79aAj8o0h+RVXpxTxRRy5k/+bCCFJipJfuGKQ2APGDg14frJJEngFwwEKa4AdRavCBLSHOql/bMetMki3XbiRy/Z64v85CtEHNilRfK6SLsi1EtGVtfEtx/KoTpNfSYzeQ/w5ZajLjAfFjB2sq5YWot6U0sX7TzVsGi67jBsXQbV3e5g4jur4p2TYyU0YzAwoD6aUkEA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(376002)(396003)(39860400002)(136003)(346002)(451199021)(6666004)(6486002)(478600001)(110136005)(19627235002)(5660300002)(8676002)(8936002)(2906002)(36756003)(31696002)(44832011)(38100700002)(66556008)(66476007)(66946007)(4326008)(316002)(41300700001)(26005)(86362001)(6506007)(66574015)(83380400001)(31686004)(186003)(53546011)(2616005)(6512007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjdvTXEzaExrdnV6SFVRZ1B6cmZVZ3FqTUxTM2hHWDZkbmg3aG9zeXpXWUMz?= =?utf-8?B?cXJlVHhheDRLNlErbDU3bnFJaHBYaFd0aWV2RlRCK3ludUVKWFNiOWgvYXV5?= =?utf-8?B?c2xIMVlUc3ZrR2VOSDE2RUw0VTJwYjRMODNKTERXc1g5UzBONi9LWDlxbDVw?= =?utf-8?B?Zk9maW8xQUVra2NoZTVrWnNVNFBSc2VlV3pRVS94Z1JlUE5YcUpVMEdpRU9x?= =?utf-8?B?bS9JMHdBQ2FuRklCRFJjWmtsdkIxOVNnZkNSQXZEa2E0dklrK0xpemhIU0F5?= =?utf-8?B?eE1CNE12bVM0djJFMFdBcjJYTnJOYTBoNVorMWt3SCtvQ0dxSnI2VjdOWHRF?= =?utf-8?B?WStyZjFkSGNwWEdzV3dwR3JKeVVvZXFCZ2p6UloyUDZNK3J1RVhQcE43ZHlt?= =?utf-8?B?Vi9KQlIxeFAzUVc1bTFTTGkyeVNMd2Y1Mm5saVdNSGJ4c2dNUVBkWnZqQUhs?= =?utf-8?B?M2lFdWk2QkZXYkwyQmc5Szkxb3B0R09PVGJhRG5RbjFkdWxzTU11bk9vZmdn?= =?utf-8?B?YitWVGluTDAvbUpaZUpEUTRqSlA3aytWZGdPNE5iTVlyZkRnQ1hQa3RuL0FY?= =?utf-8?B?MUpWWHZMeEhpTFF3cW02UGhuN3pKbUlSSUFJYnhoOE9TNyt4ZjZoU1ZMYXBN?= =?utf-8?B?eU5hanRCUVZlNVdBWkRHQm5HQ0h3M0ZZRE5zbzVsa2orL1VYVVAzWVh5T2NG?= =?utf-8?B?a1paS1V2U3BIZ3dWT2laclArMGExUjZ2M3Rac1U3ZnQxekZQa1BPa0UzM3p4?= =?utf-8?B?WnJ3d1dqOGZaQ01Hcld2ZE1IWkhvdkR5T3NHWkFwdTAwSzZMQ0JrdURvZFcr?= =?utf-8?B?UHhIOVpqVmVSUk9XWFpWWHNramsxQTJwNWVJakZsVnNRL3JwNkdOczBvc1N0?= =?utf-8?B?dWRJZkFqTzFBYTNVS2tTSmsyay80WVBXSmtySDByU1hTVENoUEZJeFlSbVRQ?= =?utf-8?B?Vk45NXRpQ09KaGdNaUlRc3E0Ni90Z0pNVmh5Wnd6L1FWc0pkaTYxalp2UU1u?= =?utf-8?B?OHlSWDI5MUVjQWpQWkozMFdoQ3hUMFhVajd6OXlXbmFuOGMzNjRoY2MzNWQw?= =?utf-8?B?b0dIQ0FPV0p5amFEMXBSMTVZZWVnaVdVLzFxM3NJWmljaHFvUVNMell4bzBP?= =?utf-8?B?QUx6eWhaK1YrSW1WZDlUak12dXNGcnVXU0lNeHU2UGFtZzk4ZXhMWno0ZW41?= =?utf-8?B?QUJxR240bVRQQ1dSMTJoZ0U3bHd2ZFFsRUQ2dFhyYVY5QXlUY043cUJ6WW9h?= =?utf-8?B?b3R3RmdrQWhHT3Z3Zk9SU25VbkdvRDlWVlFpc2laUmVQTy8yejJPZ3pQN0Ji?= =?utf-8?B?WkVwZHpQNEpKV2l4eVo0aU9sRHR1YXNZZkZOb2p2V3JoR0ZyZ213STVNcEhx?= =?utf-8?B?UFVoUjBoUHNBejllMUpWckU1MSsxdFhrcThoN2pXRy81L1F2N0NFSHQ5ZW01?= =?utf-8?B?YUdBTGVsT1ZkU1gzaU5Qa1BZbHZqMUVOTE5FUmkzYWdmdmpBQ05TRXBBbUJn?= =?utf-8?B?SVc5N29Fc3pWWWQvVlM2ay9UUzRyN3MrUythaE1NS2s0cFhWUk1hbTBtL3dQ?= =?utf-8?B?d05Db1F3NU81Y0htQitxcWwvSVlRaG5yUkNXVjZZNGJyZWNybVVoWFR5MUJS?= =?utf-8?B?eEhmY0pPbEZyVzYxMm1kNUFOTmhCMnV0dWVjZHhmOXJTMUtiRmZBVGxiaW8w?= =?utf-8?B?Z1pndnV6dmZDYUJSTjZQZWp2K29URUVhY3RtNXVMRUFVSFZwdnA1TElyKzE3?= =?utf-8?B?MitnWGZZZVBXWXNYczRaVWdzWWV5R284MDUyNEs4ZWpDRTRlb1VGcy9Majly?= =?utf-8?B?SkJ0cTJVeGlMUXBNM1BCN25CUHdNa1BxRmVUcWNvSDkzWkVlOElCSHdxNnBi?= =?utf-8?B?QlZvYnA3Z0hCY0hqakxDWUR6UUsvS09ZOFVJNFFNWlZjT0hsWVBGQm1oeUw0?= =?utf-8?B?MzRZR2FGRmhpZXVldzRBQWRiSk9IVG4zckNLNzVpLzNoOGJ6dVBaZks1QzF4?= =?utf-8?B?TmJ4SHBmQlQ2ZjlkclFuNE1nalF3ek81TEZRdEppUmJYZ3paUnZyeDZyeHky?= =?utf-8?B?b281cW9zUE43bHJpbllhcGY0UllOV0pPTG9WWnNRTzcwY1ZML3dzN1pFTDBv?= =?utf-8?Q?6KKp97zQ3TrCgJh5jZO5rSRrs?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 406760b5-7b5f-459a-f53e-08db7ecd8e77 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2023 09:35:52.8912 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fqgJvE7bQ/8ymXOr4K7Qaw7xV/5oOtWty21iY2dcYbBVG8Btt9eEqn+unpo74Cwg X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4250 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 2/15/2022 4:24 PM, Vipul Ashri wrote: > On 11/22/2021 3:53 PM, Gaëtan Rivet wrote: >> Could describe in more detail the execution? >> In particular, setting the EAL log-level to debug with the option: >> ' --log-level pmd.net.failsafe:debug ' >> for example while using testpmd or your DPDK app. >> It should show ethdev level accesses to the sub-devices, and error values. >> >> Best regards, > > Hi Gaetan > > Sorry for very late reply, we were busy working on 21.11 integration. > > Although we have adopted this code internally for us but I am sharing the patch to opensource for community benefit. > > This is specific case of AZURE setup with our very customized complex environment. > > Let me share the logs with trace-back first > ================================================================================================================== > SECONDARY PROCESS > timestamp=1633598184 > TCZ0.0.0 Cycle 152 (Build 1832) > signal 11 (Segmentation fault), address is 0x31117bbce6c8 from 0x47d08b1 > > [bt]: ( 1) _Z18snprintf_backtraceRPciiP9siginfo_tPv      (+   0xf4) - sp = 0x7fffef3fd110, ip = 0x3acdc54 > [bt]: ( 2) _Z13crit_err_hdlriP9siginfo_tPv               (+  0x159) - sp = 0x7fffef3fdc20, ip = 0x3acdf29 > [bt]: ( 3) _ZN13SignalAdapter12handleSignalEiP9siginfo_tPv (+  0x104) - sp = 0x7fffef3fdf00, ip = 0x274d4c4 > [bt]: ( 4) _L_unlock_18                                  (+   0x2c) - sp = 0x7fffef3fdf80, ip = 0x7ffff7bce630 > [bt]: ( 5) rte_eth_dev_attach_secondary                  (+   0x21) - sp = 0x7fffef3fec50, ip = 0x47d08b1 > [bt]: ( 6) rte_eth_from_ring                             (+ 0x3438) - sp = 0x7fffef3fec80, ip = 0x4e49da8 > [bt]: ( 7) _init                                         (+ 0xa1b8) - sp = 0x7fffef3feec0, ip = 0x12e0368 > [bt]: ( 8) local_dev_probe                               (+   0xac) - sp = 0x7fffef3feef0, ip = 0x478fd2c > [bt]: ( 9) rte_uuid_unparse                              (+  0x274) - sp = 0x7fffef3fef30, ip = 0x47a3e94 > [bt]: (10) rte_eal_vfio_get_vf_token                     (+   0xd7) - sp = 0x7fffef3ff110, ip = 0x47b04b7 > [bt]: (11) eal_hugepage_info_read                        (+  0x602) - sp = 0x7fffef3ff170, ip = 0x47b2cd2 > [bt]: (12) start_thread                                  (+   0xc5) - sp = 0x7fffef3ff220, ip = 0x7ffff7bc6ea5 > [bt]: (13) clone                                         (+   0x6d) - sp = 0x7fffef3ff2c0, ip = 0x7ffff004096d > EAL: Fail to recv reply for request /var/run/dpdk/oracusbc/mp_socket:eal_dev_mp_request > EAL: Cannot send request to primary > EAL: Failed to send hotplug request to primary > net_failsafe: Failed to probe devargs net_tap_vsc0 > EAL: Fail to recv reply for request /var/run/dpdk/oracusbc/mp_socket:eal_dev_mp_request > EAL: Cannot send request to primary > EAL: Failed to send hotplug request to primary > net_failsafe: Failed to probe devargs net_tap_vsc1 > EAL: No legacy callbacks, legacy socket not created > EAL: Drop mp reply: eal_dev_mp_request > ================================================================================================================== > PRIMARY PROCESS > timestamp=1633598196 > TCZ0.0.0 Cycle 152 (Build 1832) > signal 11 (Segmentation fault), address is 0x38 from 0x9d8fbe > > [bt]: ( 1) _Z18snprintf_backtraceRPciiP9siginfo_tPv      (+   0xf4) - sp = 0x7fffecf41150, ip = 0x100dd44 > [bt]: ( 2) _Z13crit_err_hdlriP9siginfo_tPv               (+  0x159) - sp = 0x7fffecf41c60, ip = 0x100e019 > [bt]: ( 3) _ZN13SignalAdapter12handleSignalEiP9siginfo_tPv (+  0x104) - sp = 0x7fffecf41f40, ip = 0xff4894 > [bt]: ( 4) _L_unlock_18                                  (+   0x2c) - sp = 0x7fffecf41fc0, ip = 0x7ffff61d9630 > [bt]: ( 5) failsafe_eth_dev_close                        (+  0x65e) - sp = 0x7fffecf42c90, ip = 0x9d8fbe > [bt]: ( 6) rte_eth_link_get_nowait                       (+   0x6a) - sp = 0x7fffecf42cf0, ip = 0x62fa0a > [bt]: ( 7) _ZN11StatsThread9statsLoopEP10CustomObject      (+  0x33e) - sp = 0x7fffecf42d20, ip = 0xedea2e > [bt]: ( 8) _ZN11StatsThread9statsLoopEP10CustomObject      (+  0x8dc) - sp = 0x7fffecf42d90, ip = 0xedefcc > [bt]: ( 9) ThreadFunction                                (+   0xe6) - sp = 0x7fffecf42db0, ip = 0x7ffff6b477e6 > [bt]: (10) start_thread                                  (+   0xc5) - sp = 0x7fffecf42de0, ip = 0x7ffff61d1ea5 > [bt]: (11) clone                                         (+   0x6d) - sp = 0x7fffecf42e80, ip = 0x7ffff0a6b96d > > ================================================================================================================== > DPDK 20.11.2 > core mask is 00000000000000000000000000004000 > DPDK Custom Process initialized with 2 ports > the min max TxQ is maxTxQueues 16 > Using 1 RxQs for port 0 (# F-core=1) > Using 1 RxQs for port 3 (# F-core=1) > Core 14 (port=0, rxQ=0) kni_ring=(nil) > Core 14 (port=3, rxQ=0) kni_ring=(nil) > Core 14 txN = 0 > Thread for core 14 using ring from usbc of 0x31117b29bb00 > Ring size must be powers of 2, adjusting from 8196 to 16384 > Thread for core 14 using ring from MEDIA of 0x31117b27b840 > Encaps Memory Zone= 48044 sizeof encaps = 60 > Trace Memory Zone= 272 > Policy Memory Zone= 8196 sizeof policy = 240 > link status for port 0 is 1 > link status for port 3 is 1 > PORT 0 supports 16 rx queues and 16 tx queues (driver_name = net_failsafe, driver_type = 16) > PORT 0 is polling for link-change, interrupts disabled > [DPDK] tap_flow_create(): Kernel refused TC filter rule creation (17): File exists > [DPDK] net_failsafe: Failed to create flow on sub_device 1 > add_flow(): create() fails for port 0; Reason: overlapping rules or Kernel too old for flower support > Error adding broadcast flow > PORT 3 supports 16 rx queues and 16 tx queues (driver_name = net_failsafe, driver_type = 16) > PORT 3 is polling for link-change, interrupts disabled > [DPDK] EAL: Failed to hotplug add device on primary > [DPDK] tap_flow_create(): Kernel refused TC filter rule creation (17): File exists > [DPDK] net_failsafe: Failed to create flow on sub_device 1 > add_flow(): create() fails for port 3; Reason: overlapping rules or Kernel too old for flower support > Error adding broadcast flow > Cmd Thread is available > Capture object initialized > init :Stats Thread is available > ifLinkUpdate: Sending OperStatus for port=0 stat=1 > ifLinkUpdate: Port 0 Link Change - speed 40000 Mbps - full-duplex > [DPDK] EAL: Fail to recv reply for request /var/run/dpdk/oracusbc/mp_socket_2934_298e9db8d1:eal_dev_mp_request > [DPDK] EAL: rte_mp_request_sync failed > [DPDK] EAL: Failed to send hotplug request to secondary > [DPDK] EAL: Fail to recv reply for request /var/run/dpdk/oracusbc/mp_socket_2934_298e9db8d1:eal_dev_mp_request > [DPDK] EAL: rte_mp_request_sync failed > [DPDK] EAL: Failed to hotplug add device on primary > [DPDK] Invalid port_id=2 > [DPDK] net_failsafe: Operation rte_eth_stats_get failed for sub_device 1 with error -19 > > There is some race at secondary process and primary got crashed because its data-structures and partially filled. > Let me know if you need GDB analysis, I can share with next reply if you are still unsatisfied. GDB analysis will be bigger. > Thanks! > > Hi Gaëtan, This is a very old patch, I don't know if it is still valid or if Vipul still pursues the issue, but do you need more data or do you have comment on how to proceed?