From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 00D987EDF;
 Wed, 26 Apr 2017 22:07:53 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga105.fm.intel.com with ESMTP; 26 Apr 2017 13:07:52 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.37,255,1488873600"; d="scan'208";a="850156258"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.58.98])
 ([10.254.58.98])
 by FMSMGA003.fm.intel.com with ESMTP; 26 Apr 2017 13:07:50 -0700
To: Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org
Cc: stable@dpdk.org
References: <1493202427-25078-1-git-send-email-alejandro.lucero@netronome.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <70f8576a-226f-f46c-e2db-de6794915181@intel.com>
Date: Wed, 26 Apr 2017 21:07:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.0.1
MIME-Version: 1.0
In-Reply-To: <1493202427-25078-1-git-send-email-alejandro.lucero@netronome.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] nfp: fix mbuf releasing when
	segments
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Apr 2017 20:07:54 -0000

On 4/26/2017 11:27 AM, Alejandro Lucero wrote:
> If segments are used, just mbufs previously linked to head descriptor of
> a mbuf chain are released. Other tx descriptor are used for the mbuf chain
> but they keep their linked mbufs without releasing them. It is not a fatal
> issue because sooner or later those descriptors will be head descriptors or
> just used for a single mbuf packet, then those linked mbufs will be released.
> However, this leads to apps needing bigger mbufs pools and some confusion
> about memory requeriments. Indeed, because larget pools, some performance
> impact could also be exptected due to cache misses.
> 
> With this patch all tx descriptors will release linked mbufs inside the
> xmit function, and rte_pktmbuf_seg_free is used instead of rte_pktmbuf_free.
> 
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>

Applied to dpdk-next-net/master, thanks.