From: Thomas Monjalon <thomas@monjalon.net>
To: "Power, Ciara" <ciara.power@intel.com>
Cc: dev@dpdk.org,
"andrius.sirvys@intel.com" <andrius.sirvys@intel.com>,
"robin.jarry@6wind.com" <robin.jarry@6wind.com>,
"Pattan, Reshma" <reshma.pattan@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Laatz, Kevin" <kevin.laatz@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] usertools: fix telemetry python3 compatibility
Date: Sun, 16 Feb 2020 22:25:19 +0100 [thread overview]
Message-ID: <7158825.SKYDtnEIZr@xps> (raw)
In-Reply-To: <9061c5b6ad93430c86382f8d7661175b@intel.com>
24/01/2020 11:11, Laatz, Kevin:
> > The client script for use with the telemetry library did not support
> > Python3, as the data being sent over the socket was in string format.
> > Python3 requires the data be explicitly converted to bytes before being
> > sent. Similarily, the received bytes need to be decoded into string
> > format.
> >
> > Fixes: 53f293c9a783 ("usertools: replace unsafe input function")
> > Fixes: fe35622659ed ("usertools: fix telemetry client with python 3")
> > Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry")
> > Fixes: 4080e46c8078 ("telemetry: support global metrics")
> > Cc: andrius.sirvys@intel.com
> > Cc: robin.jarry@6wind.com
> > Cc: reshma.pattan@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
> > Reviewed-by: Robin Jarry <robin.jarry@6wind.com>
> >
> <snip>
>
> Acked-by: Kevin Laatz <kevin.laatz@intel.com>
Applied, thanks
prev parent reply other threads:[~2020-02-16 21:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 17:24 [dpdk-stable] [PATCH] usertools: add " Ciara Power
2020-01-19 21:48 ` Thomas Monjalon
2020-01-20 8:47 ` Robin Jarry
2020-01-21 17:03 ` [dpdk-stable] [PATCH v2] usertools: fix " Ciara Power
2020-01-24 10:11 ` Laatz, Kevin
2020-02-16 21:25 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7158825.SKYDtnEIZr@xps \
--to=thomas@monjalon.net \
--cc=andrius.sirvys@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=reshma.pattan@intel.com \
--cc=robin.jarry@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).