From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: "david.marchand@redhat.com" <david.marchand@redhat.com>,
"stable@dpdk.org" <stable@dpdk.org>
Cc: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
Subject: Re: [PATCH 20.11] net/mlx5: do not close stdin on error
Date: Sat, 27 Nov 2021 14:37:18 +0000 [thread overview]
Message-ID: <717979526cc8e6e491b930499bd295f97624513c.camel@nvidia.com> (raw)
In-Reply-To: <20211112084435.26358-1-david.marchand@redhat.com>
On Fri, 2021-11-12 at 09:44 +0100, David Marchand wrote:
> [ upstream commit 7f49dafe0534b8a8614492c052d7fbe2e87dc6ae ]
>
> If for any reason, a socket could not be opened, mlx5_pmd_socket_init()
> could close the 0 fd (which is valid, and has a fair chance to be stdin),
> since server_socket == 0 from the variable being in .bss.
>
> Fixes: e6cdc54cc0ef ("net/mlx5: add socket server for external tools")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Reviewed-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> ---
Applied to 20.11.4 list, thanks!
prev parent reply other threads:[~2021-11-27 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 8:44 David Marchand
2021-11-27 14:37 ` Xueming(Steven) Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=717979526cc8e6e491b930499bd295f97624513c.camel@nvidia.com \
--to=xuemingl@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dkozlyuk@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).