* [PATCH] net/nfp: fix callback function pointer of disabling promisc
@ 2023-06-08 3:07 Chaoyong He
2023-06-08 14:50 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Chaoyong He @ 2023-06-08 3:07 UTC (permalink / raw)
To: dev; +Cc: oss-drivers, niklas.soderlund, Qin Ke, Chaoyong He, stable
From: Qin Ke <qin.ke@corigine.com>
The callback function of promiscuous_disable in nfp_flower_pf_repr_dev_ops
and nfp_flower_repr_dev_ops should be nfp_net_promisc_disable, not
nfp_net_promisc_enable, fix it.
Fixes: 39d82d2 ("net/nfp: fix promiscuous mode for representor port")
Cc: Chaoyong He <chaoyong.he@corigine.com>
Cc: stable@dpdk.org
Signed-off-by: Qin Ke <qin.ke@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
drivers/net/nfp/flower/nfp_flower_representor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c
index 6b4ba5b9a2..3225a4b84a 100644
--- a/drivers/net/nfp/flower/nfp_flower_representor.c
+++ b/drivers/net/nfp/flower/nfp_flower_representor.c
@@ -518,7 +518,7 @@ static const struct eth_dev_ops nfp_flower_pf_repr_dev_ops = {
.stats_reset = nfp_flower_repr_stats_reset,
.promiscuous_enable = nfp_net_promisc_enable,
- .promiscuous_disable = nfp_net_promisc_enable,
+ .promiscuous_disable = nfp_net_promisc_disable,
.mac_addr_set = nfp_flower_repr_mac_addr_set,
.fw_version_get = nfp_repr_firmware_version_get,
@@ -540,7 +540,7 @@ static const struct eth_dev_ops nfp_flower_repr_dev_ops = {
.stats_reset = nfp_flower_repr_stats_reset,
.promiscuous_enable = nfp_net_promisc_enable,
- .promiscuous_disable = nfp_net_promisc_enable,
+ .promiscuous_disable = nfp_net_promisc_disable,
.mac_addr_set = nfp_flower_repr_mac_addr_set,
.fw_version_get = nfp_repr_firmware_version_get,
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/nfp: fix callback function pointer of disabling promisc
2023-06-08 3:07 [PATCH] net/nfp: fix callback function pointer of disabling promisc Chaoyong He
@ 2023-06-08 14:50 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2023-06-08 14:50 UTC (permalink / raw)
To: Chaoyong He, dev; +Cc: oss-drivers, niklas.soderlund, Qin Ke, stable
On 6/8/2023 4:07 AM, Chaoyong He wrote:
> From: Qin Ke <qin.ke@corigine.com>
>
> The callback function of promiscuous_disable in nfp_flower_pf_repr_dev_ops
> and nfp_flower_repr_dev_ops should be nfp_net_promisc_disable, not
> nfp_net_promisc_enable, fix it.
>
> Fixes: 39d82d2 ("net/nfp: fix promiscuous mode for representor port")
> Cc: Chaoyong He <chaoyong.he@corigine.com>
> Cc: stable@dpdk.org
>
> Signed-off-by: Qin Ke <qin.ke@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-08 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-08 3:07 [PATCH] net/nfp: fix callback function pointer of disabling promisc Chaoyong He
2023-06-08 14:50 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).