* [dpdk-stable] [PATCH] ethdev: fix endian annotation for spi item
@ 2019-08-20 13:45 David Marchand
2019-08-23 10:17 ` Andrew Rybchenko
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2019-08-20 13:45 UTC (permalink / raw)
To: dev
Cc: ian.stokes, i.maximets, stable, Adrien Mazarguil,
Thomas Monjalon, Ferruh Yigit, Andrew Rybchenko
spi should be set with network endian values.
While 0xffffffff == htonl(0xffffffff), this missing annotation is caught
by sparse when compiling ovs (dpdk-latest branch).
Fixes: d4b684f7197a ("net: add ESP header to generic flow steering")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/librte_ethdev/rte_flow.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
index b66bf14..354cb1d 100644
--- a/lib/librte_ethdev/rte_flow.h
+++ b/lib/librte_ethdev/rte_flow.h
@@ -935,7 +935,7 @@ struct rte_flow_item_esp {
#ifndef __cplusplus
static const struct rte_flow_item_esp rte_flow_item_esp_mask = {
.hdr = {
- .spi = 0xffffffff,
+ .spi = RTE_BE32(0xffffffff),
},
};
#endif
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH] ethdev: fix endian annotation for spi item
2019-08-20 13:45 [dpdk-stable] [PATCH] ethdev: fix endian annotation for spi item David Marchand
@ 2019-08-23 10:17 ` Andrew Rybchenko
2019-08-27 13:15 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Rybchenko @ 2019-08-23 10:17 UTC (permalink / raw)
To: David Marchand, dev
Cc: ian.stokes, i.maximets, stable, Adrien Mazarguil,
Thomas Monjalon, Ferruh Yigit
On 8/20/19 4:45 PM, David Marchand wrote:
> spi should be set with network endian values.
> While 0xffffffff == htonl(0xffffffff), this missing annotation is caught
> by sparse when compiling ovs (dpdk-latest branch).
>
> Fixes: d4b684f7197a ("net: add ESP header to generic flow steering")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH] ethdev: fix endian annotation for spi item
2019-08-23 10:17 ` Andrew Rybchenko
@ 2019-08-27 13:15 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2019-08-27 13:15 UTC (permalink / raw)
To: Andrew Rybchenko, David Marchand, dev
Cc: ian.stokes, i.maximets, stable, Adrien Mazarguil, Thomas Monjalon
On 8/23/2019 11:17 AM, Andrew Rybchenko wrote:
> On 8/20/19 4:45 PM, David Marchand wrote:
>> spi should be set with network endian values.
>> While 0xffffffff == htonl(0xffffffff), this missing annotation is caught
>> by sparse when compiling ovs (dpdk-latest branch).
>>
>> Fixes: d4b684f7197a ("net: add ESP header to generic flow steering")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-27 13:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20 13:45 [dpdk-stable] [PATCH] ethdev: fix endian annotation for spi item David Marchand
2019-08-23 10:17 ` Andrew Rybchenko
2019-08-27 13:15 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).