From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix ixgbe private API calling
Date: Wed, 11 Jan 2017 16:19:05 +0000 [thread overview]
Message-ID: <727ff859-107b-74c3-1110-7ed8bdbc70f6@intel.com> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C224D1CD35@IRSMSX108.ger.corp.intel.com>
On 1/11/2017 3:47 PM, Iremonger, Bernard wrote:
> Hi Ferruh,
>
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Wednesday, January 11, 2017 3:27 PM
>> To: Iremonger, Bernard <bernard.iremonger@intel.com>; Lu, Wenzhuo
>> <wenzhuo.lu@intel.com>; dev@dpdk.org
>> Cc: Wu, Jingjing <jingjing.wu@intel.com>; stable@dpdk.org
>> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix ixgbe
>> private API calling
>>
>> On 1/11/2017 3:20 PM, Iremonger, Bernard wrote:
>>> Hi Wenzhuo,
>>>
>>> <snip>
>>>>> Subject: [dpdk-dev] [PATCH] app/testpmd: fix ixgbe private API
>>>>> calling
>>>>>
>>>>> Some ixgbe private APIs are added to expose ixgbe specific functions.
>>>>> When they're used by testpmd, there's no check for if the NICs are
>> ixgbe.
>>>>> Other NICs also have chance to call these APIs.
>>>>> This patch add the check and the feedback print.
>>>>
>>>> I am not sure that testpmd is the right place to do this.
>>>> The rte_pmd_ixgbe_* functions are public API's which can be called by
>>>> other applications.
>>>> The checks should be in the rte_pmd_ixgbe_* API's
>>>
>>> It is useful to handle the return code -ENOTSUP in testpmd.
>>>
>>
>> Makes sense, and I think it is good idea to add them in your patch, since it
>> introduces returning -ENOTSUP, would you mind sending a new version of
>> your patch with this update?
>> So we can drop this patch completely.
>>
>> Thanks,
>> ferruh
>>
> I don't think this patch should be dropped.
> Testpmd is already handling -EINVAL and -ENODEV.
> It makes sense for it to handle -ENOTSUP for the cases in the patch.
This patch adds driver check [1] before ixgbe APIs, since now that check
is done within ixgbe APIs by your patch. Why do we need this patch at all?
[1]
if (strstr(dev_info.driver_name, "ixgbe") != NULL)
>
> Regards,
>
> Bernard.
>
next prev parent reply other threads:[~2017-01-11 16:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 2:47 [dpdk-stable] " Wenzhuo Lu
2017-01-11 10:27 ` [dpdk-stable] [dpdk-dev] " Iremonger, Bernard
2017-01-11 15:20 ` Iremonger, Bernard
2017-01-11 15:26 ` Ferruh Yigit
2017-01-11 15:47 ` Iremonger, Bernard
2017-01-11 16:19 ` Ferruh Yigit [this message]
2017-01-11 16:29 ` Iremonger, Bernard
2017-01-11 18:07 ` Ferruh Yigit
2017-01-12 1:08 ` Lu, Wenzhuo
2017-01-12 10:08 ` Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=727ff859-107b-74c3-1110-7ed8bdbc70f6@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).