From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D1D1A054A for ; Tue, 6 Dec 2022 11:13:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 577E541611; Tue, 6 Dec 2022 11:13:11 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2077.outbound.protection.outlook.com [40.107.244.77]) by mails.dpdk.org (Postfix) with ESMTP id 0706A40687; Tue, 6 Dec 2022 11:13:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UAbLHaJLAebVrKTEXSIZK4wRqmLf7fpxG56GAnsyFKk04QQO1EQXu3EItoZuXpyqxyHezsxRxaSqDNzqpmTzq8LUZ0WAmlNW3+fxocr4s6xlbHgg3P1w8/UunQifyBDFDtYozwbQGptPsMrihcoapQCV+AlEkx4CjFuo3DFdO++qm3u4sPYeI6kqk0h5YWB/uWJM3EJkjAiDMI+N4CafUQIua/hBx914cpy/NNWKnzgeJ1KKA+3JI2OcFijBITe2vuMAoTYiEZ8BfRa1wYff0r5mX5XMhRumEWt2LbfwVA91Jp30qNVK/zCo1k+FsuG23KRS4yHD59FfNPpFBe/XEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bmpef0kUzFyMs+OqIOl/g8dHI5J71KckgjUa7fOdeWM=; b=m93na/P9qfT9oipmixdmlHfROy2m/dkBhDURrcd3lCosAaNa11pU66nOr+KWixcA6qRtQ8Zofx2Dcw9nn8bvYeIxxGgMQBwWsoWLuj/yPYMWxx9diEfq4lKO8StKTpZQUuy5YUYPXMlb+mkF4spHo2XlZcJchr+Y4gnyAiaFJEBM3QuqFLH18yDg1p2OAka2LOHoYuwLfSo5/GsweQJBn+2bFwpjjhAfbupK3oATXGN0bsbV3CMqb30H6f+yGC27K9/zLbUTk3Bx4u/YNL5tgBFh447lpgpcfjUT+a88WY/gRF3Ny3WPAggqkfeDXnsrV8Fa2ElofXMn3ortm/lI7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bmpef0kUzFyMs+OqIOl/g8dHI5J71KckgjUa7fOdeWM=; b=u5O8n17WKwqHRUqm11oChKUZOnty7It4JGKqJwPn50CgjHEejJWav/wGv7/oGCD9fauMja3vkx7/SvCXZA28S0NW3cj8or/VriELgxyGf/25PDqqJHE/xriDecZbFESa0c0iDBWWwwBhvXSZOO3z/eBMKM41XybA9Lj+DwgJw44= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY5PR12MB6201.namprd12.prod.outlook.com (2603:10b6:930:26::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Tue, 6 Dec 2022 10:13:06 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%8]) with mapi id 15.20.5880.014; Tue, 6 Dec 2022 10:13:06 +0000 Message-ID: <734b4cca-331a-9a6e-8300-3bf024e326d9@amd.com> Date: Tue, 6 Dec 2022 10:12:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted To: Thomas Monjalon , David Marchand , Akhil Goyal Cc: "ci@dpdk.org" , Andrew Rybchenko , Ajit Khaparde , Qi Zhang , Jerin Jacob Kollanukkaran , Raslan Darawsheh , Maxime Coquelin , "Xia, Chenbo" , Luca Boccassi , Kevin Traynor , Christian Ehrhardt , "Xueming(Steven) Li" , "dev@dpdk.org" , "stable@dpdk.org" , Bruce Richardson , Michael Santana , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= , Aaron Conole References: <20221129140032.35940-1-david.marchand@redhat.com> <1923653.yKVeVyVuyW@thomas> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <1923653.yKVeVyVuyW@thomas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0079.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY5PR12MB6201:EE_ X-MS-Office365-Filtering-Correlation-Id: 4dddfbe7-3385-400f-bc44-08dad772772c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 68GyeHqo/rxYHUbnAoemtxPKe6LFliqy49dIhSuVRAMmbVf3GGaFLGExW7/HUVEarwRl+7G36sgKyYUWNmouF+QRfHUgGAT/F1/Oz/cB2p2FMsnDg8Z2DXOiYEBJYSawrARMii+dFJS/GQocFjBFzQiT83e3Up7LtDtkcWdAXRUO0ha4+dBrni278BnY7a9+0KvUWjduqeTPq1+dg1vGCdGI5PPXxGKDHFNDjWwSgH9ATQLnTsulma2Faw6eL2vQU8QP4bFoHyHOWYr180S1iwdI3jdjoliY3PFlnxe1Up11f8gF7DdSE5enjcT+RdnZAcPpmnAU75ZV6R+ux0hx3ZTsISq8o3y78zADtGtDuVzHcPoOb0Vg7UBkkoXaYPXWyJt4e2PhaFlAfU4xL/zZjXoDG89IJVfaq2qAqrsRboTWOP5SdjrMasle7WB2tXGvwrm23eaSEsbjkO5NTUsIBw8wswTiUa+TzCShCgnnXGh1fbJTdTyKmL/InOFxbEHfHw1mZ6si7y6oeszr5g803XqLrSjkz74BtbF2tEyGrUuDofGIHA3EUyv5UAd1KxYoGhQ7VQ2gDZpbIE/9C0oeT0LB0IeUtfeHyq4pE8eXttqety8t3xM4dpRfN55fzUp8oCXCIvS0odcwGpeHjHDw0Iu+DhL7KykK1Zm/khK0pMJB/WcibIv5PVC6nECx66i4R2zCvsS1UY1xXoL4Ga7dJ11aDsx5CyK3DglUDOIhEDw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(346002)(396003)(376002)(39860400002)(366004)(451199015)(31686004)(66899015)(186003)(316002)(54906003)(6486002)(478600001)(110136005)(36756003)(86362001)(31696002)(38100700002)(83380400001)(6512007)(6506007)(2616005)(26005)(53546011)(6666004)(2906002)(7416002)(5660300002)(44832011)(4326008)(41300700001)(8676002)(8936002)(66946007)(66476007)(66556008)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGVCdHNhRlJoR1hVTGsrRnd4QWhhZWR0TlBnbUxXTmZSd1JaWmVlREkwVC9I?= =?utf-8?B?ZzVrK1VsY1Q3RVFDL1Y0QnB5NG9rSk40RzRiVlBLMHlQOXM1dS9lbkdUcmVn?= =?utf-8?B?TVk1cnFMY0xhZzJFK2R6ekZBM2o2c3U2cG9DOE9IbHZWMlpwL2VZa3dhQnlP?= =?utf-8?B?ZnNLUlhoR2hBUmt4Ung2YmxxNllqdG54QWF3Z0hheHdVZ3NOQXN0UndnNVc2?= =?utf-8?B?TkFBNFM3NytXMlVSZVlXK3YxNlRLdytCQXI1RkxzUTJkOU50UjE0WGRyN3Ro?= =?utf-8?B?MmRoQU1BRXROY1F1SDRGbEp3d2t4UEJLNUY0UGJoZnBNb1F3T2xOT3VpT1p3?= =?utf-8?B?OUVSV1MxNE04VDBzQm5hMEplME5TVnZwL2F3dnQwNnoxdUl5d0RuUkd2MEwz?= =?utf-8?B?ZXlUaFkvK0YwL21TUTRpanlyaWFVWGFZbUNGSEZ3MUplaTlHY3hONnNULzhW?= =?utf-8?B?enp2S0N0ZDJlSEFBZWRHd2ZxVXVJRWVYRVZibVJXTnQydC9mTHYwcUZxUXg5?= =?utf-8?B?WXpCZG5VaE9PNDl6TmV6TWNnYTVKVFJXN3dkR1RZOFAzRzJJWUtYdTVxZTkv?= =?utf-8?B?SjNwdTQrU1VGeWp5WGxIT1lneWVxOG9lUm9rbURPb1Z3L1BVNzZibTk1R1ZJ?= =?utf-8?B?cEJ4Zm1KV0FtVXoxUnFXS2RhdjJVa05QcmxFQnZMR1BMMVhpekVyd1g4RlI0?= =?utf-8?B?UVlBVEd5VWVLV1Flci92QmU4b3JOVjdTeGZlUHprOVlZMmVyMW1qc1NIeTkz?= =?utf-8?B?dEZwSHI2ZU1TeG11MjBCMmMzZ1pBTHd5SjQvRUlQc3ZWMzdvSUhYMXk0Wjls?= =?utf-8?B?SjlyQmhTcENRYktCWHNiYWRhTFl5SSthL3dzdWpNbzIrSXFkakFlaTdCTUZZ?= =?utf-8?B?akJ0MDVXNWVMRHZHdy80U3p0U0swTUVFMmhNWG5oK3dOb0NZdzREelpwSHVp?= =?utf-8?B?dGptSGJrRGwzRFB0YkJxZlVDZDJOc2RYbDBDdHJhcHJjVU9LOG0xVlVSTFF4?= =?utf-8?B?OEFJODBXd3lNWGtIYVN2aUlHSWtHaVhwLzRDbUczU3MzUlpDZW5JNDJLdTRL?= =?utf-8?B?RkFsQ1ZXYWVWM2pSV2ZJMllaMkZ6bkxjRnAwemEyMnRYWTY1b0xwemorUWc5?= =?utf-8?B?RS9Vanp6TkZkUWRLSlg0SGlLWUovV0VPMm04alNXTkFiWEU5czhUV3IzQVQz?= =?utf-8?B?UTRqb0hjSDg0WThxZGVtVHBGS1dLUU4vNlZyTTdCOGswZWNJUEExR3g2TWlX?= =?utf-8?B?Q0xQQkplZEVWbUwxVW9zM2YxZjhwS3dHNEpudEJxZ0RBaHRCVXVJL0poRjlK?= =?utf-8?B?K28yNkYwK016eWdndW00NmpHYjFLUzJ4QWtMVWMvajB1bWxoYWxib0xJMU1L?= =?utf-8?B?d3ZLY3E4UndvNDQrc0JqM2dEVUNXZWZmZ29CR0tiUlFoei9wQStGcTFCN0tW?= =?utf-8?B?M29rZnhxSWlwdDUzampPMFI2UTdUbEZOWnMyK01YQkZHb2I0VUE0TDdvOEh6?= =?utf-8?B?NjdGK3dlNko3WDZKRWNJeHU5WFVTUmxsZjNWMzg4ZHNJTGtJcGJtUnhISzA5?= =?utf-8?B?SmlHMjlhOFgrNGlUc1RIR0tJY1RCUjBkcUJGOWhvOUIwU0dCQW03N0NCc1Jo?= =?utf-8?B?VWJGYW5kTjF3eVA3N0FDa29pQkF2R2wzRG1xYjIrd2JVd09WSUM5a2hxYThE?= =?utf-8?B?azZHODVOaWdRR1BrZlc0THVsZEFCL2x6ZFlnOTFkZk9Oc1ZNYTBOTlJOYWpx?= =?utf-8?B?WkhJa3FNMzJxclRaMWJxci9RM3Fsc0s2N3BxSld6bVdta0lHZTFnbHJEUlp5?= =?utf-8?B?em1tc1ZHQTJtK2tjWXdCbkI0YWk3cHNUbGE0ejVweUEvQjRDWGp1ZURyODl2?= =?utf-8?B?cWN1aHFjUFZUbFJlOUJlNndwV09INUg2YjBVQXQwMmZxYTUxOGtRUjN6SnlV?= =?utf-8?B?S0k3NGxKb0lqM1h6Z25wMEIzRjRaMnBJT0Q2ZHRiNXNteEcveldTdGU1VTNG?= =?utf-8?B?d0JMOFRwNUk1dVByMFE0eGlXRFcyR3dFOVhjUmVMYlU4WnBzOVBnYy9DRXg2?= =?utf-8?B?a25jNUROL0pjaGJaTU5ZVGllOHpnL1h6NEJkb2U4d0pVaFRaOURSR21rY25o?= =?utf-8?Q?AGrwnqWutghZhe1i8T+Iv7mlw?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4dddfbe7-3385-400f-bc44-08dad772772c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2022 10:13:06.4665 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HSb6lLK+iG3dqJdCxaXbebTAnoS5UtTalYFFYln9vxRMK8Dw5kPoBpFSxWRF9Bmp X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6201 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 12/5/2022 3:37 PM, Thomas Monjalon wrote: > 05/12/2022 14:47, Akhil Goyal: >>> On Mon, Dec 5, 2022 at 11:44 AM Akhil Goyal wrote: >>>>> Please, maintainers and CI teams, when you enable ABI checks in the >>>>> main branch, or in the 22.11 LTS branch, use the dpdk-stable 22.11.1 >>>>> tag as a reference. >>>>> Thanks. >>>> >>>> Should we also add a tag on main repo, as new development does not happen >>>> on stable tree? >>> >>> You can fetch the v22.11.1 tag from the stable tree. >> Yes, that is an obvious option. >> But adding a tag on same repo is more convenient from developer point of view. >> However, it is my personal view, others may differ. > > From developer point of view, you should use devtools/test-meson-builds.sh > which does the "git clone" for you. > > This is what I have in ~/.config/dpdk/devel.config > export DPDK_ABI_REF_DIR=$root/dpdk-build/abiref > export DPDK_ABI_REF_VERSION=v22.11.1 > Does it help to update 'test-meson-builds.sh' to use an environment variable to select which repo to clone? If so, I can send a patch for it.