From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org, Ori Kam <orika@nvidia.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Wei Zhao <wei.zhao1@intel.com>
Subject: Re: [PATCH] app/testpmd: remove useless pointer checks
Date: Tue, 29 Mar 2022 11:26:30 +0200
Message-ID: <7495551.lvqk35OSZv@thomas> (raw)
In-Reply-To: <20220324161503.13047-1-david.marchand@redhat.com>
24/03/2022 17:15, David Marchand:
> Parameters to this static helper can't be NULL.
> str has already been dereferenced in caller.
> dst and size point to variable in stack.
The same function is copy/pasted in several places.
Why simplifying only this one? because of its static nature?
Shouldn't we make it a common function as other string helpers?
next prev parent reply other threads:[~2022-03-29 9:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 16:15 David Marchand
2022-03-29 9:26 ` Thomas Monjalon [this message]
2022-05-12 7:19 ` David Marchand
2022-05-20 15:04 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7495551.lvqk35OSZv@thomas \
--to=thomas@monjalon.net \
--cc=aman.deep.singh@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
--cc=xiaoyun.li@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
patches for DPDK stable branches
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
stable@dpdk.org
public-inbox-index stable
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://inbox.dpdk.org/inbox.dpdk.stable
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git