From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BBE8A0562 for ; Thu, 1 Apr 2021 13:39:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 666131410AD; Thu, 1 Apr 2021 13:39:27 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id C19B64067B; Thu, 1 Apr 2021 13:39:24 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 3F5265C014E; Thu, 1 Apr 2021 07:39:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 01 Apr 2021 07:39:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= OqCppIsX8ZayK7cYTtnH9XWXqmuCV3ALol2TbwdpW/0=; b=dDv1yzJl4T0UoM7u 0DdvUAgtv4Q/FdDGvYCEHLVstMx7xfvvIiJDRkV8R2GByOJWB3+FcKU2dcWmgTfJ /kBtsO0cCevW/8nkRmG7EcEZtbMJD6BlNW/vfq+whA9XE9CEqznc+b+9zk3WDe9w wPYSy+l1tJOv3bp4X0DsK6J9EtnpIfLJCnFXnzU1g3IG45HcSTHPWLwKB9v1usi2 NI54g8bybO8DL6TTSTOs5P1cN2Bw/90zR6hZeOIeCkNgzHAgv3YQkGJ1bUOHrVnk c0GXkKvCrOpmpgamZucwEU5plRrWvHlm1jd9H8RVz6nhFBPpARg7DezX/xlzahvb UYQbrQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=OqCppIsX8ZayK7cYTtnH9XWXqmuCV3ALol2TbwdpW /0=; b=L0a//bT5ueqzlhXXv2jbfDuvDBo/a5aBkP8rP5/y+c7AxWMxJ6GUPv3u/ VWx0r+8LVTYdXQTyjGPwjhXmcMQL25V14A6jr/qdXJ62zfjlqbysrEHtP+62ocRB WqMRdABIBHw1/U6mmYPrywrtI+0MT6JgF1FlJAuh5oI3NeV+fTgLxP1UZaVuvvnu SOBUxKl5cH1nlUKWHY5cDUMdoS6RqS/egtSP2QchzCAUdB5LlsDeaSa1CUTv0h4o yO6p563okdP4lRhsEtXr4BNZfceDshZOTmvjXjoLR62bj2sC6rlph25zm1ewUL4X FnpsLdw/Q3/ErGm9q54nNd/NeXXlw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeigedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0835F1080054; Thu, 1 Apr 2021 07:39:22 -0400 (EDT) From: Thomas Monjalon To: Eli Britstein Cc: dev@dpdk.org, Gaetan Rivet , Asaf Penso , Ori Kam , stable@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com Date: Thu, 01 Apr 2021 13:39:21 +0200 Message-ID: <7504044.RxHU5scrEf@thomas> In-Reply-To: <20210401074913.16563-1-elibr@nvidia.com> References: <20210401074913.16563-1-elibr@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] doc: add Linux rawio capability requirement in mlx5 guide X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" +Cc mlx5 maintainers About the title: "rawio" is not a word. "raw IO" would be better. 01/04/2021 09:49, Eli Britstein: > For an application to be able to create "transfer" rte_flows for mlx5 What is "tranfer" rule? rte_flows does not exist. You probably mean rte_flow rule. > devices, it should have cap_sys_rawio capability. > Document it. > > Fixes: f772cc424c45 ("doc: add required Linux capabilities in mlx5 guide") > Cc: stable@dpdk.org > > Signed-off-by: Eli Britstein > Reviewed-by: Gaetan Rivet [...] > In order to run as a non-root user, > -some capabilities must be granted to the application:: > +some capabilities must be granted to the application, while others are If you wish to show that all are not a must, better to replace "must be granted" by "may be required". > +optional for some use cases. Capabilities can be set for example using Please start new sentence on next line. > +the setcap utilitiy:: typo: utility > > - setcap cap_sys_admin,cap_net_admin,cap_net_raw,cap_ipc_lock+ep > + setcap cap_net_admin,cap_net_raw,cap_ipc_lock,cap_sys_admin,cap_sys_rawio+ep > > Below are the reasons of the need for each capability: > > -``cap_sys_admin`` > - When using physical addresses (PA mode), with Linux >= 4.0, > - for access to ``/proc/self/pagemap``. > - > ``cap_net_admin`` > For device configuration. > > @@ -477,6 +475,14 @@ Below are the reasons of the need for each capability: > ``cap_ipc_lock`` > For DMA memory pinning. > > +``cap_sys_admin`` optional > + When using physical addresses (PA mode), with Linux >= 4.0, > + for access to ``/proc/self/pagemap``. > + > +``cap_sys_rawio`` optional > + For the application to be able to apply rte_flow flows in transfer > + mode. "For the application" looks useless. We don't apply "rte_flow flows" but "flow rules". What is "transfer mode"? It is not mentioned elsewhere in this doc. How this capability is related to dv_esw_en? Do we need it in case of trusted VF?