From: Ferruh Yigit <ferruh.yigit@amd.com>
To: David Marchand <david.marchand@redhat.com>,
Sunyang Wu <sunyang.wu@jaguarmicro.com>
Cc: dev@dpdk.org, orika@nvidia.com, stable@dpdk.org,
Joey Xing <joey.xing@jaguarmicro.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] lib/ethdev: modified the definition of 'NVGRE_ENCAP'
Date: Mon, 27 Nov 2023 10:42:22 +0000 [thread overview]
Message-ID: <75bac5b7-d776-4add-81b5-2e3babfd76a7@amd.com> (raw)
In-Reply-To: <CAJFAV8zLtCbQNewrHO7p4VZNm1uYQ=fm7VrSBPU72Ds+pJnoVg@mail.gmail.com>
On 11/24/2023 1:36 PM, David Marchand wrote:
> On Fri, Nov 24, 2023 at 4:31 AM Sunyang Wu <sunyang.wu@jaguarmicro.com> wrote:
>>
>> Fix the issue of incorrect definition of 'NVGRE_ENCAP', and
>> modified the error comments of 'rte_flow_action_nvgre_encap'.
>>
>> Fixes: c2beb1d ("ethdev: add missing items/actions to flow object converter")
>> Fixes: 3850cf0 ("ethdev: add tunnel encap/decap actions")
>
> Please use the format for Fixes tag described in the contributing guide.
>
> Fixes: c2beb1d469d2 ("ethdev: add missing items/actions to flow object
> converter")
> Fixes: 3850cf0c8c37 ("ethdev: add tunnel encap/decap actions")
>
>> Cc: stable@dpdk.org
>
> Copying more maintainers.
> Apart from readability, I think this patch does not fix any real bug, does it?
>
It is a genuine fix, that used struct was wrong, but as size of both
structs are same, practically functionality should be same.
I think risk is low with this patch and we can get it even at this stage
of release, but also it is safe to postpone it to next release. I leave
decision to David.
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
>>
>> Signed-off-by: Joey Xing <joey.xing@jaguarmicro.com>
>> Signed-off-by: Sunyang Wu <sunyang.wu@jaguarmicro.com>
>
>
next prev parent reply other threads:[~2023-11-27 10:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 3:30 Sunyang Wu
2023-11-24 13:36 ` David Marchand
2023-11-27 10:42 ` Ferruh Yigit [this message]
2023-11-28 11:57 ` Ori Kam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75bac5b7-d776-4add-81b5-2e3babfd76a7@amd.com \
--to=ferruh.yigit@amd.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=joey.xing@jaguarmicro.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=sunyang.wu@jaguarmicro.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).