From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E8B0433E4 for ; Mon, 27 Nov 2023 11:42:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E40F40649; Mon, 27 Nov 2023 11:42:33 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2081.outbound.protection.outlook.com [40.107.243.81]) by mails.dpdk.org (Postfix) with ESMTP id DEF8F40150; Mon, 27 Nov 2023 11:42:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lDG1kypSlUQRBqN5C9BaMeihPxeCWpJZDkrZZSLxMxWWL8kblDZhUgTXQibpC99GFKylGasDxlNqXoMakdZNndchX2Z+jd/gF/cfWdBz/NYMGdwCrm3tFBPWXtRzSlU8GOEqbIKFSq42oMUMj042rGPRpF8EPJtmMo0dSCX5wDp5cFe709jn+im7RXr1mYcw5IQrADJR3DxH4P836o3stzZw9rXxFMLol0vqugHY6mAOCSh2CgCg/U8Jj2CRlv0t6ljWjitG5pTCD6UNKc3LR2UxOndJjMTQQLJEV5l3LlSGzqO/wQc7uzkMbuc0pj4u15t9Jp84NM/iWxKOIl4TUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3JrKBiulo7RFfdrvCeC+eENQoZqsaE4BS6OuPUnVqLQ=; b=faILlwH90WaQWWzR7bjrcLu+xkpYFC4xJDxxppJrYrDayVXur3ZMQyJ1URdIKHgzz0prAblPl4QQhwf3VdfWyc6VdqAvG2RIlSdp9LhgnLk55NPL1teqmJ0M76I5dzWBRryVtQ2h2gQLNXEZ3UOqeGjXhMPe2UbbjmO3SIENh2XtPBa12Tee6Fcgl15YpulLzVAAPo+d7dCJfye2zoBOgq4V2LtUA6Zj7jP1T6BmMgtdCj+qRce7HrRgIJ6j3YUTPUMD0tna3ia95c9mmuyVFo/X3dXvp8tiWGWfQ93Oay/tz1eSRM1POiJFaNrxncESY9mHY+7DGc8PODXMJuSstQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3JrKBiulo7RFfdrvCeC+eENQoZqsaE4BS6OuPUnVqLQ=; b=qTfyrNa1HsSkqME/i/Z/WzKHMPZs+ya4A/hJkaL0hl5mLzv+Na4N374VbpeLT9OWH5aigAovS4hJxJsnCwSr7gRtHhOiGcyzVijUgkivmhxepu446TruLo22pNwj9g628tzMAiX8gh3HW1+uy/jCo8t2BJEmQzyC7BWoFmowjlo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW4PR12MB7437.namprd12.prod.outlook.com (2603:10b6:303:21a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Mon, 27 Nov 2023 10:42:27 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7025.022; Mon, 27 Nov 2023 10:42:27 +0000 Message-ID: <75bac5b7-d776-4add-81b5-2e3babfd76a7@amd.com> Date: Mon, 27 Nov 2023 10:42:22 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] lib/ethdev: modified the definition of 'NVGRE_ENCAP' Content-Language: en-US To: David Marchand , Sunyang Wu Cc: dev@dpdk.org, orika@nvidia.com, stable@dpdk.org, Joey Xing , Thomas Monjalon References: <20231124033059.22972-1-sunyang.wu@jaguarmicro.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0188.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW4PR12MB7437:EE_ X-MS-Office365-Filtering-Correlation-Id: 478a6614-9db7-4096-00d8-08dbef358c95 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eOOJTaKPBOiGylhwA9IdPUqiq8/20RWpiGZW7Oh+k0li9jX3RvSN1Qvk8R/2UbMIDtZgnmDCkLHayPrdMEfcKG1bL+b3Elk4fBqJXh33L40cvjZQDWlmgRGHCDRmcXnQZRlCvpg54+eMTRzbb2V6hMObQWCltqpeA6JCY0W9s1TFu/4V7KG8EmuIRusESzGuBwVTH7D95Xz3bWQWvLnXTAcU7MMBGikGa5MBIFuOZzIcIp3BiU88PYuvGAgIsBQsg4MHss2jk115hSO0jZOpJ2MrC8ujXq7vGDQ8rUoogd4pAvfl16ttCZ0W2+O24znz7mj0iWm/3tz+Zy4ki6CffVvCWMhLMksO8hN3RrWEGU1AVynxJLyqK40X5GrxgYI+BiVoTdk4O1o8KYID45qGMy82HMxLZ1Af/LBSDugrTlhvveeCj42pLWPfLAPbopT/ySBgjsZGRQjCNFMyp7tLjJVY/YWtHbJ5MsQ/ZRmmx6SHGke1VYzSn7ufl1ZH8clsrXre/eOKmJlwl1RGxaUNR7knMvaMnkTd1tJhYCq9eCgSlMxONVVwptC/neFvTo9E7YgMoaKXQcWiy4cZ1VhiHmBJ98DaaK7TAqS/pqZ1oSnUF7A5amTLjqqxiZjmj1NtGwsCVDZrkatpLGKwx7OEHw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(39860400002)(366004)(396003)(136003)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(38100700002)(41300700001)(36756003)(31686004)(86362001)(2906002)(83380400001)(5660300002)(26005)(44832011)(2616005)(31696002)(6512007)(53546011)(6506007)(6666004)(8676002)(4326008)(8936002)(478600001)(6486002)(66946007)(110136005)(54906003)(66476007)(66556008)(316002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzVaTzJpWFZxeFZ6QVFCdmRJcFE4MTJOMFZmeTN2SWxjRVJFSEo4bEdzUE9I?= =?utf-8?B?Wksxb3lHeGFNNTdsOHgva2RTaWYyVWYxWW1QWG84LzZLZjNtY3hhdGQxMTJa?= =?utf-8?B?VVd1ZngyVXZYTUdXVzMvUWhBRGozUHkzV3R0cXVrRTRZTVlxSm5oYWU5YzVp?= =?utf-8?B?QWVUZEkzV3BjNXcvTFhnOWJvcVR6WEl2VXBESzFnUzhQaW4vMTlKbTJXOVhi?= =?utf-8?B?MG1tRjRFRWx3eGFKb25JdEN3c3FBQ0xRSzdCWHBEUFE2Z2JyVjVIS2YxeWo5?= =?utf-8?B?Q2tSdE11dytUSDlqd3lpa0k1cEk3Ync3S0Y1YzlOcXJCZVAxWm1YOFJDb3NN?= =?utf-8?B?SCtCUUlLcmk2L3VsTHMzL050akpIeFIza0xoZDF5WWhVamQ4NTRYZ2k2eTZX?= =?utf-8?B?R1hLOUs3OVpYdWRrQ09BdGFOMEtBQWpCQjBjb1A3WTFQQ3BPemRsVXNyZmxF?= =?utf-8?B?cGVFb0NZUkpMUlpLcmpWaGhqc2lzdUgwdWwrVTZNQ2lJUVRXb0VYYjBnQ3Vv?= =?utf-8?B?NS9XYUdUWFVuNGZrOFNYck5aV3NEZEQvdmVqYUZnUHBIUlFSWVpZVlBXK00w?= =?utf-8?B?RUE2MDBRZUJkdFprRE5xOFIwSVVoV2lPTy9zU3FkSWRKUCtzNDV2U2NJaUh1?= =?utf-8?B?MVRxVzEycUlqeURZSTdwU2pCR3FJVUhBN2RNMjJHeWtCNzZvU2Y0ZlZZcTdO?= =?utf-8?B?L3gyK2ovQWN1ZUhzdkpvdk5BVkNLRXFvaktYZE10MTYvUzBSRExKWTJZL21v?= =?utf-8?B?cWtXaGJpNEhWczBoQUlGc3dabkVEbFVzZFFrVUhxempRMFZlNmlTNGxWVHRl?= =?utf-8?B?bFFQME1ROFVyRUh4SGNIUk9KMGswNmdEK1ZaUHJOcnU2SVBZSTZDWkMvUjA2?= =?utf-8?B?bDNzeTdXdmlHYThGQllTYnhBUlJRNi83T3cwSTB3Z3VCUGwzZDNQbXJud0pM?= =?utf-8?B?cGZzWUhmL09ubVp4dG9sTUVhUGduVVhkcVNnWWVCRTA2VU9icW1oZXZXNE1N?= =?utf-8?B?eXVvRG5pRzlGeCs0Qlo0TGNGK3pRMzdsV2FlUVFHd0NtR1BUekdDeWhLNUJG?= =?utf-8?B?MTI2VHJuenJITmZHaVh4T0kzMk1ON0NuU0FkUlZ3THFGTnl4a1NXNDNlNjZP?= =?utf-8?B?VjY5Q3djb3JHSnJMM2RpY04yTDNsSDZjTEdjejVpMVpRbFE5RkxQYjROMXd1?= =?utf-8?B?Q3hCajF3YytTYWtTUEx5TjNsNWlPd2dHZGNqVTZQV1p0RTBiemE1ZnZET2Jq?= =?utf-8?B?LzZDS0lzL04zbUhXcm5YS0dBWkxiS0VpRUY0YnZSUHg4M3h5aEYvNkVUSThI?= =?utf-8?B?RTRhOFR0QW1QUjFaaTB1SkZLMEZBVUF3OVJISWVKdmJZSkZLdGpGaGpObmRB?= =?utf-8?B?SjIyZ3lVdDRYckxLR3ZzdmY4Q0ZwZ2dVaGlYOEV3cDl6c3JTSEVJNExEWnR1?= =?utf-8?B?dnkxbWt5eUY2anJoTkVNbllKMS9mM1pacGJ2eTBGMWUzcDlKVWtDWWdvQ1Zl?= =?utf-8?B?TTE4RnYzeHdXc0VBWkFGd2JoUHBhU2RPc1dsQlpkZ1pnSE1EK2JPTFJTa3d4?= =?utf-8?B?cHJkMXR6eWgzNXlBbHRROEJJeEErOExWV2RkeFd4KzVZMlVXZ28zWHBiZ1B4?= =?utf-8?B?ejVBNzMvZmZManZickt0YWtwd0FtRjk0ZS9CL2YwRmNsVDhaaXRKeFJZMkxL?= =?utf-8?B?MGUzaUpMb1YzUm5MaEZJdlA2a01MR1VYR1QwbkpXRGZIZE5WQVhaRTYxMkhP?= =?utf-8?B?ZWRqRVp5cWxpSjhtNlNjODByY1pXWXRncDdqUG51VGFaMWR0WVRjNFNaa2lV?= =?utf-8?B?SmNxK1oxUzA4UlNIam5WWkRyNEhLR3ZQbHpOTkhSZmFKWjg2VjBSa1NtZHhp?= =?utf-8?B?VUFRWnE1UTRvT1F5RWw3blA0UGNYN3ZaN1RXTHVZZm44M1d2U2JycHZoT0g0?= =?utf-8?B?K01nNWNhL05UT1NOektwQ0M0K00ySHYxNHp0MlNwK0pHRlZLNTBra0J0MVFl?= =?utf-8?B?K2tXRDlyV2tDRE10WmkwaVRZNHdwNkxDbm5LMi9DWVMwZG1LbGdJdlhwRThQ?= =?utf-8?B?WmV1c2tUOVUyU2ZmaW1oMjJ4dyswbVdGMnlpRnYwdHk2aTF1RlV0cC9CT2ZY?= =?utf-8?Q?tRdo=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 478a6614-9db7-4096-00d8-08dbef358c95 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 10:42:27.7120 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z10cHpeWXAYh60sChZqJELOV+r7M+okmuXXs++Jw4zRWdp3xeWLNjhZWFbegdvIF X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7437 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 11/24/2023 1:36 PM, David Marchand wrote: > On Fri, Nov 24, 2023 at 4:31 AM Sunyang Wu wrote: >> >> Fix the issue of incorrect definition of 'NVGRE_ENCAP', and >> modified the error comments of 'rte_flow_action_nvgre_encap'. >> >> Fixes: c2beb1d ("ethdev: add missing items/actions to flow object converter") >> Fixes: 3850cf0 ("ethdev: add tunnel encap/decap actions") > > Please use the format for Fixes tag described in the contributing guide. > > Fixes: c2beb1d469d2 ("ethdev: add missing items/actions to flow object > converter") > Fixes: 3850cf0c8c37 ("ethdev: add tunnel encap/decap actions") > >> Cc: stable@dpdk.org > > Copying more maintainers. > Apart from readability, I think this patch does not fix any real bug, does it? > It is a genuine fix, that used struct was wrong, but as size of both structs are same, practically functionality should be same. I think risk is low with this patch and we can get it even at this stage of release, but also it is safe to postpone it to next release. I leave decision to David. Reviewed-by: Ferruh Yigit >> >> Signed-off-by: Joey Xing >> Signed-off-by: Sunyang Wu > >