From: "Guo, Jia" <jia.guo@intel.com>
To: "Zhang, AlvinX" <alvinx.zhang@intel.com>,
"Liang, Cunming" <cunming.liang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Zhang, AlvinX" <alvinx.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] test: fix buffer overflow
Date: Fri, 15 Jan 2021 08:59:17 +0000 [thread overview]
Message-ID: <75f952994d984b3e80d80d97c872492a@intel.com> (raw)
In-Reply-To: <fd7c47772cb04534b159fb81e5771d33@intel.com>
Acked-by: Jeff Guo <jia.guo@intel.com>
> -----Original Message-----
> From: Guo, Jia
> Sent: Friday, January 15, 2021 4:31 PM
> To: 'Zhang,Alvin' <alvinx.zhang@intel.com>; Liang, Cunming
> <cunming.liang@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>;
> stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] test: fix buffer overflow
>
> Hi, Alvin
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Zhang,Alvin
> > Sent: Wednesday, November 25, 2020 5:46 PM
> > To: Liang, Cunming <cunming.liang@intel.com>
> > Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>;
> > stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] test: fix buffer overflow
> >
> > From: Alvin Zhang <alvinx.zhang@intel.com>
> >
> > The Tx buffer may overflow when there is more than one port.
> >
> > Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> >
> > Fixes: 002ade70e933 ("app/test: measure cycles per packet in Rx/Tx")
> > Cc: stable@dpdk.org
> > ---
> > app/test/test_pmd_perf.c | 18 ++++++++----------
> > 1 file changed, 8 insertions(+), 10 deletions(-)
> >
> > diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c index
> > 4db816a..3a248d5 100644
> > --- a/app/test/test_pmd_perf.c
> > +++ b/app/test/test_pmd_perf.c
> > @@ -606,10 +606,10 @@ enum {
> > static int
> > exec_burst(uint32_t flags, int lcore) {
> > - unsigned i, portid, nb_tx = 0;
> > + unsigned int portid, nb_tx = 0;
> > struct lcore_conf *conf;
> > uint32_t pkt_per_port;
> > - int num, idx = 0;
> > + int num, i, idx = 0;
> > int diff_tsc;
> >
> > conf = &lcore_conf[lcore];
> > @@ -628,16 +628,14 @@ enum {
> > rte_atomic64_set(&start, 1);
> >
> > /* start xmit */
> > + i = 0;
> > while (num) {
> > nb_tx = RTE_MIN(MAX_PKT_BURST, num);
> > - for (i = 0; i < conf->nb_ports; i++) {
> > - portid = conf->portlist[i];
> > - nb_tx = rte_eth_tx_burst(portid, 0,
> > - &tx_burst[idx], nb_tx);
> > - idx += nb_tx;
> > - num -= nb_tx;
> > - }
> > -
> > + portid = conf->portlist[i];
> > + nb_tx = rte_eth_tx_burst(portid, 0, &tx_burst[idx], nb_tx);
> > + idx += nb_tx;
> > + num -= nb_tx;
> > + i = (i >= conf->nb_ports - 1) ? 0 : (i + 1);
>
> If conf->nb_ports = 1, after the above assign, the i should be 1 and is that
> your expected?
Please ignore above comment, this code should be works.
>
> > }
> >
> > sleep(5);
> > --
> > 1.8.3.1
next prev parent reply other threads:[~2021-01-15 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 9:46 [dpdk-stable] " Zhang,Alvin
2020-11-26 9:30 ` [dpdk-stable] [dpdk-dev] " Ling, WeiX
2021-01-15 8:31 ` Guo, Jia
2021-01-15 8:59 ` Guo, Jia [this message]
2021-01-19 10:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75f952994d984b3e80d80d97c872492a@intel.com \
--to=jia.guo@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).