Re: [PATCH v2 1/2] net/ice: fix Tx offload path choice

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 3/4/2022 3:31 AM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: Xu, Ting <ting.xu@intel.com>
>> Sent: Friday, March 4, 2022 11:19 AM
>> To: Liu, KevinX <kevinx.liu@intel.com>; dev@dpdk.org
>> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Yigit, Ferruh
>> <ferruh.yigit@intel.com>; Liu, KevinX <kevinx.liu@intel.com>; stable@dpdk.org
>> Subject: RE: [PATCH v2 1/2] net/ice: fix Tx offload path choice
>>
>>> -----Original Message-----
>>> From: Kevin Liu <kevinx.liu@intel.com>
>>> Sent: Wednesday, December 29, 2021 5:37 PM
>>> To: dev@dpdk.org
>>> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
>>> <qi.z.zhang@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Yigit,
>>> Ferruh <ferruh.yigit@intel.com>; Liu, KevinX <kevinx.liu@intel.com>;
>>> stable@dpdk.org
>>> Subject: [PATCH v2 1/2] net/ice: fix Tx offload path choice
>>>
>>> Testpmd forwards packets in checksum mode that it needs to calculate
>>> the checksum of each layer's protocol.
>>>
>>> When setting the hardware calculates the outer UDP checksum and the
>>> software calculates the outer IP checksum, the dev->tx_pkt_burst in
>>> ice_set_tx_function is set to ice_xmit_pkts_vec_avx2.
>>> The inner and outer UDP checksum of the tunnel packet after forwarding
>>> is wrong.The dev->tx_pkt_burst should be set to ice_xmit_pkts.
>>>
>>> The patch adds RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM to
>>> ICE_TX_NO_VECTOR_FLAGS,set dev->tx_pkt_burst to ice_xmit_pkts.After
>>> the tunnel packet is forwarded, the inner and outer UDP checksum is correct.
>>>
>>> At the same time, the patch of "net/ice: fix Tx Checksum offload" will
>>> cause interrupt errors in a special case that only inner IP and inner
>>> UDP checksum are set for hardware calculation.The patch is updating
>>> ICE_TX_NO_VECTOR_FLAGS, the problem can be solved, so I will restore
>>> the code modification of that patch.
>>>
>>> Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path")
>>> Fixes: 295968d17407 ("ethdev: add namespace")
>>> Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Kevin Liu <kevinx.liu@intel.com>

<...>

>>
>> Acked-by: Ting Xu <ting.xu@intel.com>
> 
> Applied to dpdk-next-net-intel.
> 

Converting Qi's implicit ack to explicit (as ice maintainer):
Reviewed-by: Qi Zhang <qi.z.zhang@intel.com>

And updating it in next-net.