From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC142A0353 for ; Fri, 4 Mar 2022 12:52:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E08A4427C5; Fri, 4 Mar 2022 12:52:58 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 51FB04013F; Fri, 4 Mar 2022 12:52:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646394776; x=1677930776; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=Ct6Zw5cD2x7tvoxR0Yju2vQYmtNRFaQxvLDpbHJRHsM=; b=ACqmlKD9+1pZvulLu3ANPmzsMGIOxkhKX8XF0tbKMyMlONDUp4qhNX3I vMLuojMjLidwdDAUBvZVTEkHQl7ElY0Z+uxEOggl2obpmhG9IcXdoVt+G berE9a/W+CS7GZyPjky7L8EKy5YFb75Kqno+y5wjiDSTfWJ9fJhx2SL64 G/lPlNBLNvLkxPYeNkthuXl+gxqso1/NUeAAWuiEP3v6hRcFfwnFpBogT jn+f7avcuqCKjGx+rYvQ7GCS2KCJMK9HsxJnDUF+mMkD/MihikFQd5TCB BbNpXt2mGL/IUIyyNVYJwiPusJ7ol0j8fkuEaeD85uM93lKWeCpuCc/6x A==; X-IronPort-AV: E=McAfee;i="6200,9189,10275"; a="241382976" X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="241382976" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2022 03:52:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="546207839" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 04 Mar 2022 03:52:54 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 4 Mar 2022 03:52:54 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Fri, 4 Mar 2022 03:52:54 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Fri, 4 Mar 2022 03:52:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HOQrrCT4BJVeP93H8lzEAGIaJaLlG6C3i4oshpINBmiAWzfxyt4zKaUxMTZbytgvlmS3Xiuvj6IdVAg0/OW6VTiGerGm/aeLfr1zqKMeXAxC4Y3/58Y/ARp6Z3BBOcmEDD4382iBfJemNjgLS+xWZCeqSJp6yD5740V+wMhZczPDgN0Nn2WS2ckxaRdZB7HMcrfs6p2pT6zramPat8uMVqhWiDWydCBAJdM1UXupq/55ufSH6IANX0fli7eY0NsVbUlPEjxyTcMnWujetuhBpr6E01P3PK8QVQMzrIGRG3DmficXu21nmI+O5KXc/uKAWj0+0jWW8hFFCS33Cov+qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/lX+tsSxeA1/XN2fwDKQ7+6EMaNY5kMei5sXfOJayec=; b=XGY+RyE6yM7D7eI4P//ecBEqF5F7Nxj8VvEt7Z2aXWTi7V4uVY1To/8i+7I9Sqosej21IydQr5s4VD40ueu5wAoqBl7rUsLk/nM5wtxpJtgVl363ibhP2O+LwVkwpikoaVqiW1G+W9egSw+dRq5//1wfHsRXo7UtgQKSpdp5+c1zdfC2gRcDCubRvu44nIPFmz8NpQSFxr+6GLEzgmMnVXLXSAgjoRbDLTahXyu0+XeWWmvkhk+4ZS0XMx0bkXYtx/rJztA2VBXJ4qcC8Im+SLzwxUSfKNSgNasgPIM/Z6Q3KIXjPbc6zze4zlsqKUmZojTwpCxXEfOIysNrxvCY8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SA0PR11MB4749.namprd11.prod.outlook.com (2603:10b6:806:9a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Fri, 4 Mar 2022 11:52:52 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%7]) with mapi id 15.20.5038.017; Fri, 4 Mar 2022 11:52:52 +0000 Message-ID: <7616e174-0257-ddb7-1ba8-00a19fe74b77@intel.com> Date: Fri, 4 Mar 2022 11:52:46 +0000 Content-Language: en-US To: "Zhang, Qi Z" , "Xu, Ting" , "Liu, KevinX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Yang, SteveX" , "stable@dpdk.org" References: <20211224150925.3296471-1-kevinx.liu@intel.com> <20211229093702.1930214-1-kevinx.liu@intel.com> <20211229093702.1930214-2-kevinx.liu@intel.com> <894899b025bc41a29aeff249740a7f92@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v2 1/2] net/ice: fix Tx offload path choice X-User: ferruhy In-Reply-To: <894899b025bc41a29aeff249740a7f92@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0237.eurprd04.prod.outlook.com (2603:10a6:10:2b1::32) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 20954d99-0807-46af-6f81-08d9fdd5834a X-MS-TrafficTypeDiagnostic: SA0PR11MB4749:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CPpRJZxvAmUy6oU+CPHe7PRcU3aNnN2JPfSJBPpi8ERoycTQMZJKLd5RRPHmjNhWHHE4VSkhbpEnrKe9dSWvjuKvgH6eGlAZnlmU311+vQOO+1ZvqNRFr3+jHgR0QOKgwetEgABAtYMalP5c0A4TKMrQ802Z577IpznOoijjGhEe3C50oiwWY0jh+wxmSHuQJ5N5ZTFqMsx/rFAMniJTdVY4ziVpe0r/LjyLStKWFKnBamPoRaL0C2tCd3+Dzyex+F+3ilbsq86XIG9SusRX6XEoZQUUryiW+XM22HrqQlm99eVLwrhsaeMKQYbp9YB4+4M0f04otxDNGNtrjfDhcPDajLmTX5ZM8Uq7Wabh5b39WphH8SDR+CWLG7j0uRrtfctdahvMQj9Fyvp9Ng/I9ecCmtLN1rJICuuBX67bIkLlxaqjv0yIZZp8dh6VAGlXcnl3z6my9va80YN/ujn41nWiIzjMbbye7XGPIU9irE5rR+dmnMyJmhUjmj1cMa6HrOijX8vIuXYXMxeH62IYOgVGGT6/Tq8i8xp9ukNZjR1GY712wSgaKce3Tg0NHmDa4HCONzmrHR++QSFYjfXKiWY+NWraPorT2FffgI0l6A2BejFmyPfMpDw//8jpAJVBtARyDt/HHwjVNMPdYqtx3Zoig4eEAV5QMUXXwaqO8UPLLGVC81fgHErSXZkaUIt3CtQaPQHVyOEKaEJkm8StEg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(2906002)(316002)(66556008)(450100002)(86362001)(31696002)(66946007)(4326008)(53546011)(31686004)(8676002)(2616005)(6506007)(6486002)(36756003)(5660300002)(6512007)(66476007)(44832011)(508600001)(6666004)(26005)(186003)(38100700002)(82960400001)(54906003)(8936002)(110136005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFExZEZoWXJrWkpsamJRbWZuc3VGR0dCL3BudmFsMW9FbUp4UWptNHlZRmg3?= =?utf-8?B?M3RpRjJZYXpITWV2SjIrWE9EVWE1N0MrQkV4ZHNKRDFqS3ZxdG9uYklHVE1x?= =?utf-8?B?VmJ1UGZXVTg5amtJQzVpTDJ4RnVQVkdFZms0WG1SQWdUNFZ6OUJuNFJXSXNq?= =?utf-8?B?RFJoQVM5S1pxRGMvN3dRYXkxaHFSNEZIK1RXMnRkdlJZWmFwK1g1bGhpWS8w?= =?utf-8?B?eHBERWNLRElYK2hJWThSd2pNNCs0dHU1dzBiOG5QWTRsSWhPUjRYRGlKQXQ1?= =?utf-8?B?NXNWOXcyb1JRSm82SzJWbXl1U3lEeTNOTnBONmp0Y2s0cmxpeTNwZjZOSkFQ?= =?utf-8?B?aUJYUVlWM0cza2lsbTdhT2RRbzBVaVkxUU9hMFpWRXY2SkVKY2J1T1p2QkVU?= =?utf-8?B?KzlOcWZRdTRCTXFtY2lLOGViRGg1VUVMZDBaMTh2MlFZSGZDcXcwZm00OEVp?= =?utf-8?B?UXVhVUJmN2hIaUs5T3hTVzR5SS8xcVJxYS8zcy9LRnYvVHNReHVMQzRIaWFZ?= =?utf-8?B?Y0dzdlZ3WTRoWVdHWTBZc3gvK2F6bmJ1QUJnYlQyL0U3Uzd6L0VleXNTM2xa?= =?utf-8?B?a01ESGtybEFPbkpheCtHZWMraEV6MTMyeGlEc1piUURGanpQUmF4R0ZNVEJB?= =?utf-8?B?MnJjeE1QTnAyd2ZvbVBYODdFOHpCcTdSSjU5Q201bVNWZjFzS29CL3VWUVRY?= =?utf-8?B?NDMxR1Fud3MyZTNVeDBLTjZFc2xJOWlnN1NDcUEyd3BSZUFxYlEvZk9KK3BT?= =?utf-8?B?YjFEVHNtcnVPeTJyRG9EYVAyU0k0YWp3b2crZmFFSmRua21seUZ3M3piTFVE?= =?utf-8?B?SlQ4Qi9KdURuNzY3enJvblN5SnpBNk1yOFRNY3c0NTlqc1drR2JyMkZPck13?= =?utf-8?B?dE1qYkY1a3E0R2RiaHJvREFNbnFFL25NSVh0M0lqYkFIT1ZGTll6VjZWcWFn?= =?utf-8?B?cUtTZ2U2Q0ZYYVl3WkZnRzRqeUtLK3hvM2FkSEI0ZGtrdU1SbU5Lay93N2JW?= =?utf-8?B?QXEzSC9rYmF3OFZiWUl0OGpoNk9mMnYxOEoxWDFwNmJ3UENrNXI0MDhIWTZY?= =?utf-8?B?WnJUd0pqa00vTWdQWE5rME5SQ210OUM0ZUQwTEMxb0JjMXdGanNzbkZ5MXk3?= =?utf-8?B?bVk4S25aNGFmOE96WHBsUXFKZHFvcUhINGg1V2xxaU1BZFBuY3g3V0hkaXBU?= =?utf-8?B?VE44M0xpbUEwRFIzZ083ckQ1RDBWTjRKc3BlbmFnei95VXR5UTFEdFRKMVZz?= =?utf-8?B?MXlmalRlUVVBMjUwZWdwWExnNmJzZmoxclF2UFQzUTNrOElKQkJTWVhIZEVx?= =?utf-8?B?Z3BvNk9mMEo3Q0ZjNXJEekIvYkRpcGxwM0RsOVFvTUNYYUVFOGppcmxObWth?= =?utf-8?B?SWxmY0szYmxXeUlBK2FXcWJsZUkxTFg1N09BS25CN3UyVHA1bml6N2N5MTBU?= =?utf-8?B?K05xKzZxVUpVU2tGaGpvVkdtQnR5RDh4cFcwQnZNRVNhdFpsSUloc3Bmd3p4?= =?utf-8?B?aUltRUsyek8xL0dPZjF0S291RlAwc0ZzcHpWYjFxSTRyMVVUMlQxSjI5dGVQ?= =?utf-8?B?dlloNmgyZFlqZlBpTTNhczNRN1BNSVFEcHVoL0R4V0JFZEJoWnpMU3lnUjdi?= =?utf-8?B?dVQvc0pYVVpmbHRKMmR5UlFOS280QjNTNSt2bm50cTlxWmhBNnZCSzhhOWM4?= =?utf-8?B?OWpXRWRNaUd6RXorSUdrc1hQbENUVWVhU2gxVHdjMGJibGRSUGZGeVcrbVRC?= =?utf-8?B?cExsYXIyUjNyU25NZVhHdWFtZVZkdHVJOUNoT043QmNqWGNHNThnZ1lBM3N6?= =?utf-8?B?WDdGUld4TEFWbUpDSXlMZG1jakJ5SXhQb1ZlazdpMTR5dndCeG4zTlNvNnZE?= =?utf-8?B?cXhaRk0vWm9HR2pFUVV1YnJOQkZTUmhySUw2RlNsRkxDd29KVStUcHp3SU9k?= =?utf-8?B?QjUwL3Zia21TcU5ZZ1ZMNFpvbW5rZFkySTUrWWdwaWJMM2FIelU1ajBpRzdK?= =?utf-8?B?YS9lTHMwSEkwaVJ3MTZJbWNOdXBYcjY3R2RrL0I1T25SVHRDaG1BeHk3NEpD?= =?utf-8?B?clhFU1BEZlJlcldmVytTQUh6Sm1GMzVlMUpNd3pXWXdKeWdyY2trY2JEVTJW?= =?utf-8?B?SURWblpYcFQzSTV4enpscFIySlJyd0M0NnE2U3RjMnhMbmNXKzFwVHM0aWZV?= =?utf-8?Q?Og6wLi/H6HdYgDGBe7NZeRc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 20954d99-0807-46af-6f81-08d9fdd5834a X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 11:52:52.4689 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dvCDngrlg4NZSsUW8cz5zNBreTWumV2U6q+hxTsTYYMlBk1v1TGLPsp7NU7lo1V1R0OhoTqgERF2rUgRd3fwQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4749 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 3/4/2022 3:31 AM, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Xu, Ting >> Sent: Friday, March 4, 2022 11:19 AM >> To: Liu, KevinX ; dev@dpdk.org >> Cc: Yang, Qiming ; Zhang, Qi Z >> ; Yang, SteveX ; Yigit, Ferruh >> ; Liu, KevinX ; stable@dpdk.org >> Subject: RE: [PATCH v2 1/2] net/ice: fix Tx offload path choice >> >>> -----Original Message----- >>> From: Kevin Liu >>> Sent: Wednesday, December 29, 2021 5:37 PM >>> To: dev@dpdk.org >>> Cc: Yang, Qiming ; Zhang, Qi Z >>> ; Yang, SteveX ; Yigit, >>> Ferruh ; Liu, KevinX ; >>> stable@dpdk.org >>> Subject: [PATCH v2 1/2] net/ice: fix Tx offload path choice >>> >>> Testpmd forwards packets in checksum mode that it needs to calculate >>> the checksum of each layer's protocol. >>> >>> When setting the hardware calculates the outer UDP checksum and the >>> software calculates the outer IP checksum, the dev->tx_pkt_burst in >>> ice_set_tx_function is set to ice_xmit_pkts_vec_avx2. >>> The inner and outer UDP checksum of the tunnel packet after forwarding >>> is wrong.The dev->tx_pkt_burst should be set to ice_xmit_pkts. >>> >>> The patch adds RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM to >>> ICE_TX_NO_VECTOR_FLAGS,set dev->tx_pkt_burst to ice_xmit_pkts.After >>> the tunnel packet is forwarded, the inner and outer UDP checksum is correct. >>> >>> At the same time, the patch of "net/ice: fix Tx Checksum offload" will >>> cause interrupt errors in a special case that only inner IP and inner >>> UDP checksum are set for hardware calculation.The patch is updating >>> ICE_TX_NO_VECTOR_FLAGS, the problem can be solved, so I will restore >>> the code modification of that patch. >>> >>> Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path") >>> Fixes: 295968d17407 ("ethdev: add namespace") >>> Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Kevin Liu <...> >> >> Acked-by: Ting Xu > > Applied to dpdk-next-net-intel. > Converting Qi's implicit ack to explicit (as ice maintainer): Reviewed-by: Qi Zhang And updating it in next-net.