From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 9DFEB3798;
 Fri,  1 Mar 2019 18:51:14 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 2B1C121C39;
 Fri,  1 Mar 2019 12:51:14 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Fri, 01 Mar 2019 12:51:14 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=u885C4IGJKT9qpHy+gkk74lmFD/RRz8xDR81ZNz8YZA=; b=OwJb4XQu7Khy
 B3UHRXnavunodc6xopMypKX1zkI3WmekkrVTWwR9COIMFxLrDAT6YuEc8pfINR38
 mOlm3vTyE4LnEWCxuCO0fUGvefvfnIX4qNoMf5uOujGWgeN7TXC+SypGS+8mag75
 OdWwtt5h2/7f5MuOy5OmRyy/ulQLpu4=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=u885C4IGJKT9qpHy+gkk74lmFD/RRz8xDR81ZNz8Y
 ZA=; b=CPcdrFy1spYSUYEDgbBWZR7N0YNR2zTYmW06ZW+xeMXRa3kz4XK91JmBf
 +ikX53rYi7OAHVSZ+6fJCmjVYWKh0hx7AzWMv69A9D1hJZ6nzbrrCbY1sHl7g8hQ
 yksO3Bxb/5giFg4ZRa0eZk2NxXsfq6y6M/Q3L1YMRh75ejvqF/lc0jbKRmhuZWwG
 HX3SxEMH4YZAhySZF+Uhf+xWDgiN0ewHcvtAgcHndjFpzcbBxy7f8Y9uHtGaQZ/r
 OLFFpDjOv07bvlLECttrAcIv++DhGR571NDlQxfoQWvsHbn74+oerMcp4gJRDGx0
 B3pUD6XwacY3ZsdpIVOhZLu7p8kwg==
X-ME-Sender: <xms:EXF5XKOyhaN1Gh8pQjWKPIUy5RN_AlGnbSqnk4DU07YhZdzVstKOKQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrvdehgddutdehucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf
 hppeejjedrudefiedrgedurdejtdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm
 rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:EXF5XDmxL0iw7jOFCJ5UDYK6GHgQu-eeRw3qzsN_gElK7TCFpxKyLg>
 <xmx:EXF5XHRhtXVxCfHq3nE9QqYxhuuQbZ1-RvlXZql78p4MbUBT09_2mA>
 <xmx:EXF5XKWyv0uRzhARBv7W8AJUxjF--UuOAE4fGkdi4Pb7OGgODHdd9g>
 <xmx:EnF5XKztNipMZkIhdOXsaaC-yEm0UL_49mY2KT8y6WPhvp8K_h4gKg>
Received: from xps.localnet (70.41.136.77.rev.sfr.net [77.136.41.70])
 by mail.messagingengine.com (Postfix) with ESMTPA id 2607510319;
 Fri,  1 Mar 2019 12:51:06 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Michael Santana <msantana@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org,
 Bruce Richardson <bruce.richardson@intel.com>,
 Van Haaren Harry <harry.van.haaren@intel.com>, ramirose@gmail.com
Date: Fri, 01 Mar 2019 18:51:02 +0100
Message-ID: <7663396.UzxFzaq1Qb@xps>
In-Reply-To: <1799922.WJ13kK0DMs@xps>
References: <20190214193547.30783-1-msantana@redhat.com>
 <20190301170806.3547-2-msantana@redhat.com> <1799922.WJ13kK0DMs@xps>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/2] Enable codespell by
	default. Can be disabled from config file.
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Mar 2019 17:51:15 -0000

01/03/2019 18:43, Thomas Monjalon:
> 01/03/2019 18:08, Michael Santana:
> > +# Enable codespell by default. This can be overwritten from a config file.
> > +# You can also enable codespell by setting DPDK_CHECKPATCH_CODESPELL to a valid path
> > +# to a dictionary.txt file if your dictionary.txt is not in the default location.

This line length won't pass chekpatch ;)

> Better to avoid "you" form in such comment.
> 
> > +DPDK_CHECKPATCH_CODESPELL=enable

It will override the value if passed with an environment variable.
You should do the same as for DPDK_CHECKPATCH_LINE_LENGTH.

> >  # Load config options:
> >  # - DPDK_CHECKPATCH_PATH
> >  # - DPDK_CHECKPATCH_LINE_LENGTH
> > +# - DPDK_CHECKPATCH_CODESPELL
> >  . $(dirname $(readlink -e $0))/load-devel-config
> >  
> >  VALIDATE_NEW_API=$(dirname $(readlink -e $0))/check-symbol-change.sh
> > @@ -13,6 +18,12 @@ length=${DPDK_CHECKPATCH_LINE_LENGTH:-80}
> >  
> >  # override default Linux options
> >  options="--no-tree"
> > +if [ "$DPDK_CHECKPATCH_CODESPELL" == "enable" ]; then
> 
> This is a bashism.
> Standard sh uses a simple =
> 
> No need for a v4, I can fix it.

Because of the required change for the env var case,
please do a v4.