From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F219AA00C3 for ; Tue, 20 Sep 2022 13:03:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D18A740E0F; Tue, 20 Sep 2022 13:03:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A445640DFB for ; Tue, 20 Sep 2022 13:03:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663671809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r632oAX6GgWcV1K07GKwDmInCYTyTZS40jtdll8lsmQ=; b=C+knLYMPax+d9lMAeStJO9jUX+69YaSt8TS9b3RPv7ssYBqseE/B2VIuFFtz3oUcDTIjCC DFYbAfhXlvXymv7MsDOYaBRN2GlJh+09K0ZvKzVhYrBIHBdi6g8LdM483NJkYco7rXnTAW jpbGa/sxd3iA+HsoQ1svUEQvWGep8HQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-248-aHWatHDtM72HxyzmFcoauQ-1; Tue, 20 Sep 2022 07:03:27 -0400 X-MC-Unique: aHWatHDtM72HxyzmFcoauQ-1 Received: by mail-wr1-f71.google.com with SMTP id d9-20020adfa349000000b0022ad6fb2845so996927wrb.17 for ; Tue, 20 Sep 2022 04:03:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=r632oAX6GgWcV1K07GKwDmInCYTyTZS40jtdll8lsmQ=; b=7hZOXGtTgPW8kByZN+f/vctk+M7qqr9dr/5lFpB6pO/e3f60bRow1RPGP7ujbpJU2E 77HmJPd0C9wQZGPtJMe+GCepYzSCJK4BtIwMHsQiyvkDaNmj3sh3bajp7d8Z7VL5HaYn KDI2FF9qVEa7STo9xihF5EsCGuHfZarJYDIsakwZGG/4h90vbpyCNeBNJfoijmGUBeTp Cj+u7iGdUfS8qOsJoISzfHmp21etgWh9DMVn+e1anmdqoEbF/hicyJ3jEk5xwrbyvGpf Tqh4nL6dbWHH+gS9wiNxnuF0P24o027+mn6erb8wCmtM8etaL9fZ9XqJ28mINCmIz/OD jlWQ== X-Gm-Message-State: ACrzQf3bg2w17fA0BDWXi8TAQEfkn+2RzARKg3vq08A58sRKXh1IwyKm QzQ2mViCHWVB/3WnxY/uT8XaO0oO8mggh9p8gXLsyDNHwuOfinIfCt3+GJgKqt57KrVrhOTqVl8 aWzkE2KU= X-Received: by 2002:a05:6000:704:b0:22b:1995:b348 with SMTP id bs4-20020a056000070400b0022b1995b348mr1123870wrb.399.1663671806677; Tue, 20 Sep 2022 04:03:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Hx/p0VMAv///5twaw1JaFAKX7qBRY43PnhyzP7ZK1+4YaL6CLsVh9qDT48E72o0PIF2VT9w== X-Received: by 2002:a05:6000:704:b0:22b:1995:b348 with SMTP id bs4-20020a056000070400b0022b1995b348mr1123859wrb.399.1663671806479; Tue, 20 Sep 2022 04:03:26 -0700 (PDT) Received: from [192.168.0.36] ([78.16.251.119]) by smtp.gmail.com with ESMTPSA id s13-20020adff80d000000b0022ae401e9e0sm1322329wrp.78.2022.09.20.04.03.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 04:03:26 -0700 (PDT) Message-ID: <7671019d-fff8-5e7f-1d92-f53d8ffc8032@redhat.com> Date: Tue, 20 Sep 2022 12:03:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 To: Maxime Coquelin , "stable@dpdk.org" , Luca Boccassi , Christian Ehrhardt , Xueming Li Cc: Michael Phelan References: From: Kevin Traynor Subject: Re: Early backport of Vhost regression fix in LTS branches In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 20/09/2022 10:36, Maxime Coquelin wrote: > Hi LTS maintainers, > > We have discovered a regression causing deadlock in application using > the Vhost library (when vIOMMU is used & NUMA reallocation happens). > > The faulty commit [0] got backported in all maintained LTS branches, > following minor releases are impacted: > - V21.11.1+ > - V20.11.5+ > - V19.11.12+ > > The fix for this regression is already in main branch, and will be part > of next v22.11 release. > > Discussing with Kevin, he suggested the fix to be backported early to > all the LTS branches. > This issue is a deadlock likely to occur with an application such as OVS, that uses vIOMMU vhost ports and a multi-NUMA system. In normal circumstances, for example with OVS, we could just recommend users not to upgrade to the latest DPDK LTS releases until the issue is fixed. Where this one gets tricky is that the latest LTS releases contains CVE fixes. At the moment if a user wants the CVE fixes *and* the below deadlock fix, they will have to pick patches themselves. It might help some if the DPDK stable branches (which are still at last release point) backport the fix below early so a user can just pull the branch. > Below is the fix to be backported: > > ====================================================================== > commit 0b2a2ca35037d6a5168f0832c11d9858b8ae946a > Author: David Marchand > Date: Mon Jul 25 22:32:03 2022 +0200 > > vhost: fix virtqueue use after free on NUMA reallocation > > translate_ring_addresses (via numa_realloc) may change a virtio > device and > virtio queue. > The virtqueue object must be refreshed before accessing the lock. > > Fixes: 04c27cb673b9 ("vhost: fix unsafe vring addresses modifications") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > Reviewed-by: Maxime Coquelin > ====================================================================== > > The fix can be backported without conflicts to all the LTS branches, > except for v19.11, for which the Vhost directory rename can cause > issues. It can be overcome using below command: > > git cherry-pick -Xfind-renames=5% 0b2a2ca350 > > Is that OK for you? > I can take care of it for all branches if other maintainers are busy and ok with that. thanks, Kevin. > Please let me know if any issue. > > Thanks, > Maxime > > [0]: https://git.dpdk.org/dpdk/commit/?id=04c27cb673b9 >