From: wangyunjian <wangyunjian@huawei.com> To: <dev@dpdk.org> Cc: <sthemmin@microsoft.com>, <jerry.lilijun@huawei.com>, <xudingke@huawei.com>, Yunjian Wang <wangyunjian@huawei.com>, <stable@dpdk.org> Subject: [dpdk-stable] [dpdk-dev] [PATCH] bus/vmbus: fix wrong allocation for device.name Date: Thu, 28 May 2020 20:03:07 +0800 Message-ID: <768c74d06680b93b2ce6bbf0813d1910666888dc.1590666521.git.wangyunjian@huawei.com> (raw) From: Yunjian Wang <wangyunjian@huawei.com> We do not need and should not allocate memory for device.name. The device.name should be set point to the devargs->name. Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Cc: stable@dpdk.org Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> --- drivers/bus/vmbus/linux/vmbus_bus.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/bus/vmbus/linux/vmbus_bus.c b/drivers/bus/vmbus/linux/vmbus_bus.c index 3c924ee..31d0dd3 100644 --- a/drivers/bus/vmbus/linux/vmbus_bus.c +++ b/drivers/bus/vmbus/linux/vmbus_bus.c @@ -242,9 +242,6 @@ return -1; dev->device.bus = &rte_vmbus_bus.bus; - dev->device.name = strdup(name); - if (!dev->device.name) - goto error; /* sysfs base directory * /sys/bus/vmbus/devices/7a08391f-f5a0-4ac0-9802-d13fd964f8df @@ -296,6 +293,7 @@ } dev->device.devargs = vmbus_devargs_lookup(dev); + dev->device.name = dev->device.devargs->name; /* device is valid, add in list (sorted) */ VMBUS_LOG(DEBUG, "Adding vmbus device %s", name); -- 1.8.3.1
next reply other threads:[~2020-05-28 12:03 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-28 12:03 wangyunjian [this message] 2020-05-28 16:12 ` Stephen Hemminger 2020-05-29 7:24 ` wangyunjian 2020-05-29 17:47 ` Stephen Hemminger 2020-06-01 2:02 ` wangyunjian
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=768c74d06680b93b2ce6bbf0813d1910666888dc.1590666521.git.wangyunjian@huawei.com \ --to=wangyunjian@huawei.com \ --cc=dev@dpdk.org \ --cc=jerry.lilijun@huawei.com \ --cc=stable@dpdk.org \ --cc=sthemmin@microsoft.com \ --cc=xudingke@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git