The driver type need to be checked in private API. The patch fixes the issue. Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting") Cc: stable@dpdk.org Signed-off-by: Guinan Sun <guinanx.sun@intel.com> --- drivers/net/ixgbe/rte_pmd_ixgbe.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c b/drivers/net/ixgbe/rte_pmd_ixgbe.c index 8bcaded6e..9bff557f9 100644 --- a/drivers/net/ixgbe/rte_pmd_ixgbe.c +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c @@ -522,6 +522,9 @@ rte_pmd_ixgbe_macsec_enable(uint16_t port, uint8_t en, uint8_t rp) dev = &rte_eth_devices[port]; + if (!is_ixgbe_supported(dev)) + return -ENOTSUP; + macsec_setting.offload_en = 1; macsec_setting.encrypt_en = en; macsec_setting.replayprotect_en = rp; @@ -542,6 +545,9 @@ rte_pmd_ixgbe_macsec_disable(uint16_t port) dev = &rte_eth_devices[port]; + if (!is_ixgbe_supported(dev)) + return -ENOTSUP; + ixgbe_dev_macsec_setting_reset(dev); ixgbe_dev_macsec_register_disable(dev); -- 2.17.1
On 05/22, Guinan Sun wrote:
>The driver type need to be checked in private API.
>The patch fixes the issue.
>
>Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting")
>Cc: stable@dpdk.org
>
>Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
>---
> drivers/net/ixgbe/rte_pmd_ixgbe.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c b/drivers/net/ixgbe/rte_pmd_ixgbe.c
>index 8bcaded6e..9bff557f9 100644
>--- a/drivers/net/ixgbe/rte_pmd_ixgbe.c
>+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c
>@@ -522,6 +522,9 @@ rte_pmd_ixgbe_macsec_enable(uint16_t port, uint8_t en, uint8_t rp)
>
> dev = &rte_eth_devices[port];
>
>+ if (!is_ixgbe_supported(dev))
>+ return -ENOTSUP;
>+
> macsec_setting.offload_en = 1;
> macsec_setting.encrypt_en = en;
> macsec_setting.replayprotect_en = rp;
>@@ -542,6 +545,9 @@ rte_pmd_ixgbe_macsec_disable(uint16_t port)
>
> dev = &rte_eth_devices[port];
>
>+ if (!is_ixgbe_supported(dev))
>+ return -ENOTSUP;
>+
> ixgbe_dev_macsec_setting_reset(dev);
>
> ixgbe_dev_macsec_register_disable(dev);
>--
>2.17.1
>
Applied to dpdk-next-net-intel, Thanks.
On 22/05/2020 06:59, Guinan Sun wrote:
> The driver type need to be checked in private API.
> The patch fixes the issue.
>
> Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting")
> Cc: stable@dpdk.org
>
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> ---
> drivers/net/ixgbe/rte_pmd_ixgbe.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c b/drivers/net/ixgbe/rte_pmd_ixgbe.c
> index 8bcaded6e..9bff557f9 100644
> --- a/drivers/net/ixgbe/rte_pmd_ixgbe.c
> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c
> @@ -522,6 +522,9 @@ rte_pmd_ixgbe_macsec_enable(uint16_t port, uint8_t en, uint8_t rp)
>
> dev = &rte_eth_devices[port];
>
> + if (!is_ixgbe_supported(dev))
> + return -ENOTSUP;
> +
> macsec_setting.offload_en = 1;
> macsec_setting.encrypt_en = en;
> macsec_setting.replayprotect_en = rp;
> @@ -542,6 +545,9 @@ rte_pmd_ixgbe_macsec_disable(uint16_t port)
>
> dev = &rte_eth_devices[port];
>
> + if (!is_ixgbe_supported(dev))
> + return -ENOTSUP;
> +
> ixgbe_dev_macsec_setting_reset(dev);
>
> ixgbe_dev_macsec_register_disable(dev);
>
Acked-by: Kevin Traynor <ktraynor@redhat.com>
On 5/22/2020 6:59 AM, Guinan Sun wrote:
> The driver type need to be checked in private API.
> The patch fixes the issue.
>
> Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting")
> Cc: stable@dpdk.org
>
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>