From: Yunjian Wang <wangyunjian@huawei.com>
To: <dev@dpdk.org>
Cc: <matan@nvidia.com>, <viacheslavo@nvidia.com>,
<dingxiaoxiong@huawei.com>, <xudingke@huawei.com>,
Yunjian Wang <wangyunjian@huawei.com>, <stable@dpdk.org>
Subject: [dpdk-dev] [PATCH 1/1] net/mlx5: fix stack buffer overflow
Date: Tue, 21 Dec 2021 15:37:44 +0800 [thread overview]
Message-ID: <782531af297f80054ea965893bf2ed4a71af472c.1640071468.git.wangyunjian@huawei.com> (raw)
The mlx5_sysfs_switch_info function get 'phys_port_name' buffer, using
'IF_NAMESIZE' for that case will be wrong and it can cause buffer overflow.
Detected with address sanitizer:
0 (/usr/lib64/libasan.so.4+0x60b57)
1 vfscanf (/usr/lib64/libasan.so.4+0x6170f)
2 __interceptor_fscanf (/usr/lib64/libasan.so.4+0x61823)
3 mlx5_sysfs_switch_info ../drivers/net/mlx5/linux/mlx5_ethdev_os.c:1098
4 mlx5_os_pci_probe_pf ../drivers/net/mlx5/linux/mlx5_os.c:2417
5 mlx5_os_pci_probe ../drivers/net/mlx5/linux/mlx5_os.c:2647
6 mlx5_os_net_probe ../drivers/net/mlx5/linux/mlx5_os.c:2722
7 drivers_probe ../drivers/common/mlx5/mlx5_common.c:657
8 mlx5_common_dev_probe ../drivers/common/mlx5/mlx5_common.c:711
9 rte_pci_probe_one_driver ../drivers/bus/pci/pci_common.c:269
10 pci_probe_all_drivers ../drivers/bus/pci/pci_common.c:353
11 pci_probe ../drivers/bus/pci/pci_common.c:380
12 rte_bus_probe ../lib/eal/common/eal_common_bus.c:72
13 rte_eal_init ../lib/eal/linux/eal.c:1286
14 main ../app/test-pmd/testpmd.c:4112
15 __libc_start_main (/usr/lib64/libc.so.6+0x23f7f)
16 _start (dpdk/arm64-armv8a-linuxapp-gcc/app/dpdk-testpmd+0x4c88a3)
Fixes: 63d1db710fbc ("net/mlx5: fix unlimited parsing of switch info")
Cc: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
drivers/net/mlx5/linux/mlx5_ethdev_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
index c19825ee52..1d97110864 100644
--- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
@@ -1066,7 +1066,7 @@ int
mlx5_sysfs_switch_info(unsigned int ifindex, struct mlx5_switch_info *info)
{
char ifname[IF_NAMESIZE];
- char port_name[IF_NAMESIZE];
+ char port_name[IF_NAMESIZE + 1];
FILE *file;
struct mlx5_switch_info data = {
.master = 0,
--
2.27.0
next reply other threads:[~2021-12-21 7:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 7:37 Yunjian Wang [this message]
2022-01-28 9:41 ` wangyunjian
2022-02-08 10:55 ` wangyunjian
2022-03-02 10:55 ` wangyunjian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=782531af297f80054ea965893bf2ed4a71af472c.1640071468.git.wangyunjian@huawei.com \
--to=wangyunjian@huawei.com \
--cc=dev@dpdk.org \
--cc=dingxiaoxiong@huawei.com \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).