From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 107EFA0548 for ; Mon, 21 Jun 2021 17:54:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED1CB411C3; Mon, 21 Jun 2021 17:54:25 +0200 (CEST) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mails.dpdk.org (Postfix) with ESMTP id 22E8D41158 for ; Mon, 21 Jun 2021 17:54:24 +0200 (CEST) Received: by mail-wm1-f46.google.com with SMTP id p8-20020a7bcc880000b02901dbb595a9f1so327870wma.2 for ; Mon, 21 Jun 2021 08:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Hx9beCJTHbhVkTW8pKd83qAtWF/7WQqhjntpTkNFj0Q=; b=RMOoP66ho7cNzuqgLKIyZswyjDJ2i660ew7bn9U/CeNv+xXS31C/NbzWw7LWYUzT9n rAFoHx++8fN5OC7FBDTNuv2w37k37OIITmgOQGIfBLMve3L1tpSmZR4t3SQa5N+VkRVJ VrRCX1eCu2KqQelPC02JChfXSdsQX2GKZWZfp8I/Va8Nz7lQU5vrLD7Sxf/lWN42v515 7r5USZ03cTZM13zYZBeohSR8yWRmtlrr/cIrsCsBK/gfzCQJ57nG3q3rCr1GjkUC3yuD 9sIUY7OfKQy6Oxx5Z+FjRLhlZsXcHi9YTu3WxQSsmJmUMfKlKHlf5JpU2Q/xCbrIGKK5 bzVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Hx9beCJTHbhVkTW8pKd83qAtWF/7WQqhjntpTkNFj0Q=; b=IYu7Qs6nt6JHsAkIwStEx67pSueLLDuV01iCaJY1o31QQvnxJxELaCQM0SZ9Rfh5gx Zo03AP7AXlQ0sAsL7cZSoQzlg8sI2JVpPUDtiHOgC03TSGevLW8t6LFft+9xwV9VZEmT 9WWk8N/I59LGMMl2dFeJrPl2acZIwpXRjYv5o7xkyCXwIo4vat/rj+M23mUDC9uAEATu ByBmvHVTzEpYJwFdTILfUHDR6w2OAK5SM/Ip2WZtSnbZAHNqHtc99ISJkjcsUNmle0Xm 2VMGUuBGQihbxetRhox5E1w8izLmdmqRqepH/2AWx7kzeA+Bki3CWJ4XbAnoYYI9RUms L9pQ== X-Gm-Message-State: AOAM531VqE9/oyCgSdxEZleA1P8Jpf6XDJoMgs3lIQa4a0F127nbi/FS qxP8rXuPcfUYtVJKXgQDQAEUY9uGE3Dk X-Google-Smtp-Source: ABdhPJzn0z0oLOD3120xlyGM2TQfZHuooTZZadcCBcXs4RpXjfYXL4hYuCC9w3Lp8kI4bEoohMfrQw== X-Received: by 2002:a05:600c:3ba0:: with SMTP id n32mr28145441wms.107.1624290863613; Mon, 21 Jun 2021 08:54:23 -0700 (PDT) Received: from [10.16.0.39] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f12sm21827021wru.81.2021.06.21.08.54.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jun 2021 08:54:23 -0700 (PDT) To: "Dumitrescu, Cristian" , Thomas Monjalon Cc: "dev@dpdk.org" , "stable@dpdk.org" References: <20210524085341.15184-1-thierry.herbelot@6wind.com> <20210524112836.28224-1-thierry.herbelot@6wind.com> <2876434.PSW51Ridbg@thomas> From: Thierry Herbelot Message-ID: <786a1730-37eb-8f22-7812-74a8a7096dd9@6wind.com> Date: Mon, 21 Jun 2021 17:54:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote: > > >> -----Original Message----- >> From: Thierry Herbelot >> Sent: Thursday, June 17, 2021 8:12 AM >> To: Thomas Monjalon ; Dumitrescu, Cristian >> >> Cc: dev@dpdk.org; stable@dpdk.org >> Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo >> >> On 6/17/21 9:01 AM, Thomas Monjalon wrote: >>>>> Check Bucket key for all possible indices. >>>>> >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table") >>>>> Cc: stable@dpdk.org >>>>> Cc: Cristian Dumitrescu >>>>> >>>>> Signed-off-by: Thierry Herbelot >>> [...] >>>>> - return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2]) >>>>> + return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3]) >>>> >>>> Acked-by: Cristian Dumitrescu >>>> >>>> Thierry, thanks again, you could have actually added my ack from V1 :) >>> >>> The root cause looks to be a typo indeed, >>> but the impact or the scope of the issue >>> should stated in few words in the title please. >>> No need to send a v3, please suggest a title and I will apply. >> >> table: check a bucket is empty for all bucket keys >> >> Thierry >> > > Hi Thierry, > > I think Thomas is asking for you to send a new version of this patch with the title updated. Is this OK with you? > Hello Cristian Sure ! What do you think of this title: "table: check a bucket is empty for all bucket keys" Best regards Thierry > Thanks, > Cristian > >>> >>> >> >> -- >> Thierry Herbelot >> Senior Software Engineer >> Tel: +33 1 39 30 92 61 >> http://www.6wind.com/ >> >> Follow us: >> https://www.linkedin.com/company/6wind/ >> https://twitter.com/6WINDsoftware >> https://www.youtube.com/user/6windsoftware -- Thierry Herbelot Senior Software Engineer Tel: +33 1 39 30 92 61 http://www.6wind.com/ Follow us: https://www.linkedin.com/company/6wind/ https://twitter.com/6WINDsoftware https://www.youtube.com/user/6windsoftware