patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH] net/nfp: fix skip reload firmware issue
@ 2024-03-08 10:50 Chaoyong He
  2024-03-11 18:17 ` Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Chaoyong He @ 2024-03-08 10:50 UTC (permalink / raw)
  To: dev; +Cc: oss-drivers, Peng Zhang, stable, Chaoyong He

From: Peng Zhang <peng.zhang@corigine.com>

When the beat value of all ports are 0, which represent all
ports are unused. But the current port starts beat before
the check process, so it needs to sleep 1 second waiting
the beat value change and to ignore the current port.

Fixes: 8b9a83ea2af2 ("net/nfp: enlarge range of skipping loading firmware")
Cc: stable@dpdk.org

Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
---
 drivers/net/nfp/nfp_ethdev.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 1e713ee111..31c54a595c 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -1193,7 +1193,13 @@ nfp_fw_skip_load(const struct nfp_dev_info *dev_info,
 	uint32_t offset[dev_info->pf_num_per_unit];
 	uint8_t abnormal = dev_info->pf_num_per_unit;
 
+	sleep(1);
 	for (port_num = 0; port_num < dev_info->pf_num_per_unit; port_num++) {
+		if (port_num == multi_pf->function_id) {
+			abnormal--;
+			continue;
+		}
+
 		offset[port_num] = NFP_BEAT_OFFSET(port_num);
 		beat[port_num] = nn_readq(multi_pf->beat_addr + offset[port_num]);
 		if (beat[port_num] == 0)
-- 
2.39.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] net/nfp: fix skip reload firmware issue
  2024-03-08 10:50 [PATCH] net/nfp: fix skip reload firmware issue Chaoyong He
@ 2024-03-11 18:17 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2024-03-11 18:17 UTC (permalink / raw)
  To: Chaoyong He, dev; +Cc: oss-drivers, Peng Zhang, stable

On 3/8/2024 10:50 AM, Chaoyong He wrote:
> From: Peng Zhang <peng.zhang@corigine.com>
> 
> When the beat value of all ports are 0, which represent all
> ports are unused. But the current port starts beat before
> the check process, so it needs to sleep 1 second waiting
> the beat value change and to ignore the current port.
> 
> Fixes: 8b9a83ea2af2 ("net/nfp: enlarge range of skipping loading firmware")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
>

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-11 18:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-08 10:50 [PATCH] net/nfp: fix skip reload firmware issue Chaoyong He
2024-03-11 18:17 ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).