From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63315A0093 for ; Thu, 23 Jun 2022 15:59:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E10640042; Thu, 23 Jun 2022 15:59:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 161A240042 for ; Thu, 23 Jun 2022 15:58:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655992739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f8YcvXnrRvgfHUghUN5nbIibDUYPCtanbw8G+B+fWew=; b=BUN2F9gBPTnabSt5/RIYUtFWPFkVG7I2MC8VEDR6mHXXPBzAoth3qS1onVlE1mCUsVJZll Ia7tpwLDpAXGxJaJ5KHCtbbfErtBLn75Io+oRJwZUkDT+h9hqUkMk/kN4EFErjvOeOI5s7 L9TKwIaBq4+5gaNhnVyZZfep8jIMbb8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-620-aPJ1x0dVMvCCCgjZsNHGHQ-1; Thu, 23 Jun 2022 09:58:58 -0400 X-MC-Unique: aPJ1x0dVMvCCCgjZsNHGHQ-1 Received: by mail-wm1-f69.google.com with SMTP id o3-20020a05600c510300b0039743540ac7so7003018wms.5 for ; Thu, 23 Jun 2022 06:58:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=f8YcvXnrRvgfHUghUN5nbIibDUYPCtanbw8G+B+fWew=; b=a9c8ZEHk/FKnqJUZ6RHuCDBe+cYPgb7CiDbwFUw1vUQNIpPdJWbRiwuuyfpfBOiF/x m1AtG4WJ5K2k1bOoMGh8r/Wt6jAlwJ1bOfaf3ydOLHElYVx4d8TWR0u90JFmxSa4DQ6U yvcG/9C9B9S43f8Bzix/XAZ+V2lk1261egJ7hyzTiH5gcCdjqTmdThxFmG+W45DYsJMR N6E9qLn4Z81PnWvswTiI1T9LALngIWq3ccYqw1Y09EDU4a9ND8aR6Y7IMPTYRRxF0hKo h6w5VCeEi4+mLWIWSKPejaf+1pQU067u7ZodJ/wa4fDZ/IsPCKlRsE+I/Dp39pu1yUmq 4IhA== X-Gm-Message-State: AJIora+V9RJWvSa/fESnblohhnT71YjEwjrtkqYKbZwnsAc7LcTy11ob ZOslz3AanraskD2crNAmDD2yZmPKOtt6zTCokFGFpKAUJy/w6VZvJeOmbwE8gfcEYPn1CaRJv11 r4+FTy+I= X-Received: by 2002:a5d:5047:0:b0:21b:92b2:f34f with SMTP id h7-20020a5d5047000000b0021b92b2f34fmr8399430wrt.677.1655992736696; Thu, 23 Jun 2022 06:58:56 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tdTDG3d1LfzRiCs7UBDX36nVYZeihp+bTgneYUsGQ3ymWWn9Swuhdl1HxAwxDBkN/c3JaIoQ== X-Received: by 2002:a5d:5047:0:b0:21b:92b2:f34f with SMTP id h7-20020a5d5047000000b0021b92b2f34fmr8399416wrt.677.1655992736490; Thu, 23 Jun 2022 06:58:56 -0700 (PDT) Received: from [192.168.0.36] ([78.17.181.1]) by smtp.gmail.com with ESMTPSA id p23-20020a05600c205700b003a0375c4f73sm550869wmg.44.2022.06.23.06.58.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jun 2022 06:58:55 -0700 (PDT) Message-ID: <7a0ca50d-7ead-2c84-5499-029d680de323@redhat.com> Date: Thu, 23 Jun 2022 14:58:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 To: Kalesh A P , stable@dpdk.org References: <20220622083713.23976-1-kalesh-anakkur.purayil@broadcom.com> From: Kevin Traynor Subject: Re: [PATCH 21.11] net/bnxt: fix tunnel stateless offloads In-Reply-To: <20220622083713.23976-1-kalesh-anakkur.purayil@broadcom.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 22/06/2022 09:37, Kalesh A P wrote: > From: Kalesh AP > > [ upstream commit c0278f6e52399f7612f9f1a9d52434071ac49921 ] > > The HW only supports tunnel header parsing globally for supported tunnel > types. When a function uses one default VNIC to receive both the tunnel > and non-tunnel packets, applying the same stateless offload operation to > both tunnel and non-tunnel packets can cause problems in certain scenarios. > To workaround these problems, the firmware advertises no tunnel header > parsing capabilities to the driver using the HWRM_FUNC_QCAPS. > The driver must check this flag setting and accordingly not advertise > tunnel packet stateless offload capabilities to the stack. > > If the device supports VXLAN, GRE, IPIP and GENEVE tunnel parsing, > then reports RX_OFFLOAD_OUTER_IPV4_CKSUM, RX_OFFLOAD_OUTER_UDP_CKSUM > and TX_OFFLOAD_OUTER_IPV4_CKSUM in the Rx/Tx offload capabilities of > the device. > Also, advertise tunnel TSO capabilities based on FW support. > > Backported the needed changes from "2646926002d8" to fix build failures. > > Fixes: 0a6d2a720078 ("net/bnxt: get device infos") > > Signed-off-by: Kalesh AP > Reviewed-by: Ajit Khaparde > Reviewed-by: Somnath Kotur Thanks, applied.