From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by dpdk.org (Postfix) with ESMTP id 5CFBB2BB0 for ; Mon, 10 Apr 2017 12:01:09 +0200 (CEST) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E1BD2AC65; Mon, 10 Apr 2017 10:01:08 +0000 (UTC) To: Yuanhan Liu References: <1491552724-3034-1-git-send-email-yuanhan.liu@linux.intel.com> <1491552724-3034-8-git-send-email-yuanhan.liu@linux.intel.com> Cc: Ferruh Yigit , dpdk stable From: Nirmoy Das Message-ID: <7a23a4c5-b491-b981-a1d5-3ad47d287657@suse.de> Date: Mon, 10 Apr 2017 12:01:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1491552724-3034-8-git-send-email-yuanhan.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] patch 'kni: fix build on Suse 12 SP3' has been queued to LTS release 16.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Apr 2017 10:01:09 -0000 Hi yliu. I realized the fix is not complete. I need to add some more changes to make it work properly. So I would say lets not add the patch to LTS release for now. On 04/07/2017 10:11 AM, Yuanhan Liu wrote: > Hi, > > FYI, your patch has been queued to LTS release 16.11.2 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable > yet. It will be pushed if I get no objections before 04/11/17. > So please shout if anyone has objections. > > Thanks. > > --yliu > > --- > From 7fd328241579dfcb4a4bffc5d1b15ebde21759b6 Mon Sep 17 00:00:00 2001 > From: Nirmoy Das > Date: Tue, 4 Apr 2017 16:16:23 +0200 > Subject: [PATCH] kni: fix build on Suse 12 SP3 > > [ upstream commit 2972254ce1630548d7b62ef7a6c61ce7c1a4b124 ] > > Add support for SLES12SP3, which uses kernel 4.4, > but backported features from newer kernels. > > Signed-off-by: Nirmoy Das > Acked-by: Ferruh Yigit > --- > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > index 84826b2..4abab4a 100644 > --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > @@ -710,6 +710,9 @@ struct _kc_ethtool_pauseparam { > #elif ( LINUX_VERSION_CODE >= KERNEL_VERSION(3,12,28) ) > /* SLES12 is at least 3.12.28+ based */ > #define SLE_VERSION_CODE SLE_VERSION(12,0,0) > +#elif (LINUX_VERSION_CODE >= KERNEL_VERSION(4, 4, 57)) > +/* SLES12SP3 is at least 4.4.57+ based */ > +#define SLE_VERSION_CODE SLE_VERSION(12, 3, 0) > #endif /* LINUX_VERSION_CODE == KERNEL_VERSION(x,y,z) */ > #endif /* CONFIG_SUSE_KERNEL */ > #ifndef SLE_VERSION_CODE > @@ -3929,8 +3932,9 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) > #define vlan_tx_tag_present skb_vlan_tag_present > #endif > > -#if ( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) > +#if ((LINUX_VERSION_CODE >= KERNEL_VERSION(4, 9, 0)) || \ > + (SLE_VERSION_CODE && SLE_VERSION_CODE >= SLE_VERSION(12, 3, 0))) > #define HAVE_VF_VLAN_PROTO > -#endif /* >= 4.9.0 */ > +#endif /* >= 4.9.0, >= SLES12SP3 */ > > #endif /* _KCOMPAT_H_ */ > Nirmoy -- SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Maxfeldstr. 5 D-90409 Nürnberg / Phone: +49-911-740 18-4