From: "Singh, Aman Deep" <aman.deep.singh@intel.com>
To: "Liu, KevinX" <kevinx.liu@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>, dev <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
"Yang, SteveX" <stevex.yang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Li, Xiaoyun" <xiaoyun.li@intel.com>,
dpdk stable <stable@dpdk.org>,
"Zhang, Yuying" <yuying.zhang@intel.com>
Subject: Re: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments
Date: Fri, 11 Mar 2022 14:34:02 +0530 [thread overview]
Message-ID: <7a4c3525-556c-7a23-d58d-361e41a6220c@intel.com> (raw)
In-Reply-To: <DM6PR11MB3673A76C845EA94CBFECAE8A960C9@DM6PR11MB3673.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 4520 bytes --]
On 3/11/2022 1:42 PM, Liu, KevinX wrote:
>
>> -----Original Message-----
>> From: Singh, Aman Deep<aman.deep.singh@intel.com>
>> Sent: 2022年3月11日 16:02
>> To: Liu, KevinX<kevinx.liu@intel.com>; Zhang, Qi Z<qi.z.zhang@intel.com>;
>> dev<dev@dpdk.org>; Yigit, Ferruh<ferruh.yigit@intel.com>
>> Cc: Yang, Qiming<qiming.yang@intel.com>; Yang, SteveX
>> <stevex.yang@intel.com>; Xing, Beilei<beilei.xing@intel.com>; Li, Xiaoyun
>> <xiaoyun.li@intel.com>; dpdk stable<stable@dpdk.org>; Zhang, Yuying
>> <yuying.zhang@intel.com>
>> Subject: Re: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-
>> segments
>>
>> Hi Kevin,
>>
>> On 3/11/2022 12:34 PM, Liu, KevinX wrote:
>>> Hi, Ferruh
>>>
>>> Yuying has already reviewed it days ago.
>>> If you can, I hope you can change the status as soon as possible and try to
>> merge the code in RC4.
>>> Thank you.
>>>
>>>> -----Original Message-----
>>>> From: Zhang, Yuying<yuying.zhang@intel.com>
>>>> Sent: 2022年3月3日 14:30
>>>> To: Zhang, Qi Z<qi.z.zhang@intel.com>; Liu, KevinX
>>>> <kevinx.liu@intel.com>; dev<dev@dpdk.org>
>>>> Cc: Yang, Qiming<qiming.yang@intel.com>; Yang, SteveX
>>>> <stevex.yang@intel.com>; Yigit, Ferruh<ferruh.yigit@intel.com>;
>>>> Xing, Beilei<beilei.xing@intel.com>; Li, Xiaoyun
>>>> <xiaoyun.li@intel.com>; dpdk stable<stable@dpdk.org>
>>>> Subject: RE: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-
>>>> segments
>>>>
>>>> LGTM.
>>>>
>>>>>> -----Original Message-----
>>>>>> From: Liu, KevinX<kevinx.liu@intel.com>
>>>>>> Sent: Wednesday, December 29, 2021 5:37 PM
>>>>>> To:dev@dpdk.org
>>>>>> Cc: Yang, Qiming<qiming.yang@intel.com>; Zhang, Qi Z
>>>>>> <qi.z.zhang@intel.com>; Yang, SteveX<stevex.yang@intel.com>;
>>>>>> Yigit, Ferruh<ferruh.yigit@intel.com>; Liu, KevinX
>>>>>> <kevinx.liu@intel.com>;stable@dpdk.org
>>>>>> Subject: [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in
>>>>>> multi-segments
>>>>>>
>>>>>> Testpmd forwards packets in checksum mode that it needs to
>>>>>> calculate the checksum of each layer's protocol.
>>>>>>
>>>>>> In process_inner_cksums, when parsing tunnel packets, inner L4
>>>>>> offset should be outer_l2_len + outer_l3_len + l2_len + l3_len.
>>>>>>
>>>>>> In process_outer_cksums, when parsing tunnel packets, outer L4
>>>>>> offset should be outer_l2_len + outer_l3_len.
>>>>>>
>>>>>> Fixes: e6b9d6411e91 ("app/testpmd: add SW L4 checksum in multi-
>>>>>> segments")
>>>>>> Cc:stable@dpdk.org
>>>>>>
>>>>>> Signed-off-by: Kevin Liu<kevinx.liu@intel.com>
>>>> Acked-by: Yuying Zhang<yuying.zhang@intel.com>
Acked-by: Aman Singh <aman.deep.singh@intel.com>
>>>>
>>>>>> ---
>>>>>> app/test-pmd/csumonly.c | 6 +++---
>>>>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>>>>
>>>>>> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
>>>>>> index
>>>>>> 02bc3929c7..c235456e58 100644
>>>>>> --- a/app/test-pmd/csumonly.c
>>>>>> +++ b/app/test-pmd/csumonly.c
>>>>>> @@ -513,7 +513,7 @@ process_inner_cksums(void *l3_hdr, const
>> struct
>>>>>> testpmd_offload_info *info, ol_flags |=
>>>> RTE_MBUF_F_TX_UDP_CKSUM; }
>>>>>> else { if (info->is_tunnel) -l4_off = info->l2_len +
>>>>>> +l4_off = info->outer_l2_len +
>>>>>> info->outer_l3_len +
>>>>>> info->l2_len + info->l3_len;
>> This seems OK. A similar miss is present for TCP case also.
>> Can you please do the same for that. Line 537
>>>>>> else
>>>>>> @@ -536,7 +536,7 @@ process_inner_cksums(void *l3_hdr, const
>> struct
>>>>>> testpmd_offload_info *info, ol_flags |=
>>>> RTE_MBUF_F_TX_TCP_CKSUM; }
>>>>>> else { if (info->is_tunnel) -l4_off = info->l2_len +
>>>>>> info->outer_l3_len +
>>>>>> +l4_off = info->outer_l2_len + info-
>>>>>>> outer_l3_len +
>>>>>> info->l2_len + info->l3_len;
>>>>>> else
>>>>>> l4_off = info->l2_len + info->l3_len; @@ -
>> This change might not be required. As for normal packet (non-tunnel case)
>> l4_off = info->l2_len + info->l3_len; should be valid.
>> Please re-check.
> I don't understand what you mean. I fix the code under the tunnel case, and I didn't modify the code for the non-tunnel case.
Sorry, my bad.
>>
>>>>>> 625,7 +625,7 @@ process_outer_cksums(void *outer_l3_hdr, struct
>>>>>> testpmd_offload_info *info, if (udp_hdr->dgram_cksum != 0) {
>>>>>> udp_hdr->dgram_cksum = 0; udp_hdr->dgram_cksum =
>>>>>> get_udptcp_checksum(m, outer_l3_hdr,
>>>>>> -info->l2_len + info->outer_l3_len,
>>>>>> +info->outer_l2_len + info-
>>>>>>> outer_l3_len,
>>>>>> info->outer_ethertype);
>>>>>> }
>>>>>>
>>>>>> --
>>>>>> 2.33.1
[-- Attachment #2: Type: text/html, Size: 11085 bytes --]
next prev parent reply other threads:[~2022-03-11 9:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 15:09 [PATCH] net/ice: fix Tx offload path choice Kevin Liu
[not found] ` <20211229093702.1930214-1-kevinx.liu@intel.com>
2021-12-29 9:37 ` [PATCH v2 1/2] " Kevin Liu
2022-03-04 3:19 ` Xu, Ting
2022-03-04 3:31 ` Zhang, Qi Z
2022-03-04 11:52 ` Ferruh Yigit
2021-12-29 9:37 ` [PATCH v2 2/2] app/testpmd: fix SW L4 checksum in multi-segments Kevin Liu
[not found] ` <d2d97e6cf1a14faaa47b61b63ed55573@intel.com>
2022-03-03 6:29 ` Zhang, Yuying
2022-03-11 7:04 ` Liu, KevinX
2022-03-11 8:02 ` Singh, Aman Deep
2022-03-11 8:12 ` Liu, KevinX
2022-03-11 9:04 ` Singh, Aman Deep [this message]
2022-03-11 10:46 ` Ferruh Yigit
2022-03-14 2:33 ` Zhang, Qi Z
2022-03-14 20:21 ` Thomas Monjalon
2022-02-24 2:32 ` [PATCH] net/ice: fix Tx offload path choice Ling, WeiX
2022-02-27 6:19 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a4c3525-556c-7a23-d58d-361e41a6220c@intel.com \
--to=aman.deep.singh@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kevinx.liu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=stevex.yang@intel.com \
--cc=xiaoyun.li@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).