patches for DPDK stable branches
 help / color / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: Kevin Traynor <ktraynor@redhat.com>,
	"Yu, PingX" <pingx.yu@intel.com>,  dpdk stable <stable@dpdk.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Walker, Benjamin" <benjamin.walker@intel.com>,
	"Xu, Qian Q" <qian.q.xu@intel.com>,
	Raslan Darawsheh <rasland@mellanox.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	"Peng, Yuan" <yuan.peng@intel.com>,
	"Chen, Zhaoyan" <zhaoyan.chen@intel.com>,
	Damian Nowak <damianx.nowak@intel.com>,
	Arek Kusztal <arkadiuszx.kusztal@intel.com>,
	 Fiona Trahe <fiona.trahe@intel.com>,
	"john.griffin@intel.com" <john.griffin@intel.com>,
	deepak.k.jain@intel.com
Subject: Re: [dpdk-stable] [dpdk-dev] 17.11.10 (LTS) patches review and test
Date: Wed, 22 Jan 2020 16:07:45 +0000
Message-ID: <7b19038b20bb3c35ec6e49a5ef877d521fbad5c4.camel@debian.org> (raw)
In-Reply-To: <a5a3e053-ba8b-3063-843d-ddfd34461e50@redhat.com>

On Wed, 2020-01-22 at 15:17 +0100, Kevin Traynor wrote:
> On 22/01/2020 12:37, Luca Boccassi wrote:
> > On Wed, 2020-01-22 at 05:27 +0000, Yu, PingX wrote:
> > > Luca,
> > > Update the regression test result of Intel part. See the details
> > > as
> > > below.
> > > 
> > > * Intel(R) Testing
> > > # Basic Intel(R) NIC testing
> > > * PF(i40e): one compile issue is found and we fix it with
> > > attached
> > > patch to go ahead the test. All passed. 
> > >   1. Bugs:make -j 110 -C test Compile failed
> > > * PF(ixgbe): the same as PF(i40e).
> > > * VF: Pass
> > > * Build or compile: Pass
> > > * Intel NIC single core/NIC performance: Pass 
> > >  
> > > #Basic cryptodev and virtio testing
> > > * vhost/virtio basic loopback, PVP and performance test: Pass.
> > > * cryptodev: 1 bug is found.
> > >   1. [dpdk-stable-17.11.10]Crypto:cryptodev_qat_autotest test
> > > failed.
> > > PS: issue passed on 17.11.9.
> > >   
> > > Regards,
> > > Yu Ping
> > 
> > Hello Yu,
> > 
> > Thanks for the report. For the first issue, you mention the patch
> > is
> > attached, but there were no attachments in your mail?
> > 
> 
> I got the attachment, pasting below as it's straightforward. Didn't
> check but I wonder is that the right Fixes commit, or another commit
> removed path[] being used.
> 
> From bfb6609bc7c8d9d19f74eff6798c9a6931fe0d75 Mon Sep 17 00:00:00
> 2001
> From: Jiang Mao <
> maox.jiang@intel.com
> >
> Date: Fri, 17 Jan 2020 12:53:11 -0500
> Subject: [PATCH] test/test: fix test app defining unused variable
> 
> Delete the unused variable to solve compiling error.
> 
> Signed-off-by: Jiang Mao <
> maox.jiang@intel.com
> >
> 
> Fixes: af75078f ("first public release")
> ---
> Note: This patch just fixes v17.11.10-rc1, the other version have no
> compiling error.
>  test/test/process.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/test/test/process.h b/test/test/process.h
> index 505d2f9..1c369e8 100644
> --- a/test/test/process.h
> +++ b/test/test/process.h
> @@ -56,7 +56,6 @@
>  	int num;
>  	char *argv_cpy[numargs + 1];
>  	int i, status;
> -	char path[32];
> 
>  	pid_t pid = fork();
>  	if (pid < 0)
> 

Thanks - the culprit is this botched backport which was adjusted but
not enough and the unused variable was left behind:

Fixes: 0ecbf7984bb0 ("test: optimise fd closing in forks")

Applied with adjusted fixes line

-- 
Kind regards,
Luca Boccassi

  reply index

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13 12:47 [dpdk-stable] " Luca Boccassi
2020-01-17  2:52 ` Pei Zhang
2020-01-17 10:44   ` [dpdk-stable] [dpdk-dev] " Luca Boccassi
2020-01-22  5:27 ` [dpdk-stable] " Yu, PingX
2020-01-22 11:37   ` [dpdk-stable] [dpdk-dev] " Luca Boccassi
2020-01-22 14:17     ` Kevin Traynor
2020-01-22 16:07       ` Luca Boccassi [this message]
2020-01-22 16:06 ` [dpdk-stable] " Ali Alnubani
2020-01-22 16:34   ` Luca Boccassi
2020-01-23 11:05     ` Luca Boccassi
2020-01-26 14:58       ` Ali Alnubani
2020-01-27 10:41         ` [dpdk-stable] [dpdk-dev] " Luca Boccassi
2020-01-30 10:08 ` [dpdk-stable] " Luca Boccassi
2020-01-30 15:01   ` [dpdk-stable] [dpdk-dev] " Stokes, Ian
2020-01-30 15:25     ` Luca Boccassi
2020-02-15 11:21   ` [dpdk-stable] " Luca Boccassi
2020-02-20 10:00     ` Luca Boccassi
2020-02-20 11:37       ` [dpdk-stable] [dpdk-dev] " Trahe, Fiona

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b19038b20bb3c35ec6e49a5ef877d521fbad5c4.camel@debian.org \
    --to=bluca@debian.org \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=benjamin.walker@intel.com \
    --cc=damianx.nowak@intel.com \
    --cc=deepak.k.jain@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=john.griffin@intel.com \
    --cc=ktraynor@redhat.com \
    --cc=pingx.yu@intel.com \
    --cc=qian.q.xu@intel.com \
    --cc=rasland@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=yuan.peng@intel.com \
    --cc=zhaoyan.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox