From: Raslan Darawsheh <rasland@nvidia.com>
To: Itai Sharoni <isharoni@nvidia.com>, dev@dpdk.org
Cc: thomas@monjalon.net, bingz@nvidia.com, stable@dpdk.org
Subject: Re: [PATCH v2] net/mlx5/windows: fix match criteria in flow creation
Date: Tue, 18 Nov 2025 16:30:01 +0200 [thread overview]
Message-ID: <7bd48e1f-fc2d-4572-8897-b8b099a23c63@nvidia.com> (raw)
In-Reply-To: <20251117084500.1276-1-isharoni@nvidia.com>
Hi,
On 17/11/2025 10:45 AM, Itai Sharoni wrote:
> Currently the Windows implementation hardcodes match criteria to
> MLX5_MATCH_OUTER_HEADERS when creating flow rules, which prevents
> matching on inner headers and other criteria types like NVGRE.
>
> The fix uses the matcher's match_criteria_enable attribute instead
> of hardcoding OUTER_HEADERS, and moves the assignment outside the
> action switch block to apply to all cases.
>
> NVGRE item type is also added to the supported items list.
>
> Fixes: 1d194496b9d1 ("net/mlx5: create flow rule on Windows")
> Cc: stable@dpdk.org
>
> Signed-off-by: Itai Sharoni <isharoni@nvidia.com>
> Acked-by: Bing Zhao <bingz@nvidia.com>
> ---
> v2:
> - Added documentation for NVGRE tunnel support on Windows
> - Noted requirement for DevX dynamic insertion mode
>
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
next prev parent reply other threads:[~2025-11-18 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 12:26 [PATCH] " Itai Sharoni
2025-11-13 22:37 ` Thomas Monjalon
2025-11-17 8:45 ` [PATCH v2] " Itai Sharoni
2025-11-18 14:30 ` Raslan Darawsheh [this message]
2025-11-17 9:10 ` [PATCH] " Itai Sharoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bd48e1f-fc2d-4572-8897-b8b099a23c63@nvidia.com \
--to=rasland@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=isharoni@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).