From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 233F9A00C5
for <public@inbox.dpdk.org>; Fri, 4 Nov 2022 11:17:44 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 17EBB42D1B;
Fri, 4 Nov 2022 11:17:44 +0100 (CET)
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])
by mails.dpdk.org (Postfix) with ESMTP id 9C1E542D0E;
Fri, 4 Nov 2022 11:17:40 +0100 (CET)
Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.54])
by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4N3c1Z4yQBzJnV8;
Fri, 4 Nov 2022 18:14:42 +0800 (CST)
Received: from kwepemm600004.china.huawei.com (7.193.23.242) by
dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2375.31; Fri, 4 Nov 2022 18:17:38 +0800
Received: from [10.67.103.231] (10.67.103.231) by
kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2375.31; Fri, 4 Nov 2022 18:17:38 +0800
Message-ID: <7c88fd96-25cb-8a08-2305-9ab550776187@huawei.com>
Date: Fri, 4 Nov 2022 18:17:37 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
Thunderbird/91.2.0
Subject: Re: [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq
To: "Ye, MingjinX" <mingjinx.ye@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "stable@dpdk.org" <stable@dpdk.org>, "Zhou, YidingX"
<yidingx.zhou@intel.com>, "Singh, Aman Deep" <aman.deep.singh@intel.com>,
"Zhang, Yuying" <yuying.zhang@intel.com>
References: <20221026171007.654038-1-mingjinx.ye@intel.com>
<c86039dc-c99f-ba89-e645-fdae68ac123c@huawei.com>
<SN7PR11MB7139CB778889AB41EA48B02EE5339@SN7PR11MB7139.namprd11.prod.outlook.com>
<ce6d40ab-c0d2-ae3c-47d2-3795840f11b0@huawei.com>
<SN7PR11MB7139DEF89E4D79FB0F37A1FFE5389@SN7PR11MB7139.namprd11.prod.outlook.com>
<230a18f4-258b-1265-bf1d-a3455d730813@huawei.com>
<SN7PR11MB7139433A3D432924A21639F9E53B9@SN7PR11MB7139.namprd11.prod.outlook.com>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <SN7PR11MB7139433A3D432924A21639F9E53B9@SN7PR11MB7139.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.231]
X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To
kwepemm600004.china.huawei.com (7.193.23.242)
X-CFilter-Loop: Reflected
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
在 2022/11/4 16:21, Ye, MingjinX 写道:
>
>> -----Original Message-----
>> From: lihuisong (C) <lihuisong@huawei.com>
>> Sent: 2022年11月3日 15:01
>> To: Ye, MingjinX <mingjinx.ye@intel.com>; dev@dpdk.org
>> Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Singh, Aman
>> Deep <aman.deep.singh@intel.com>; Zhang, Yuying
>> <yuying.zhang@intel.com>
>> Subject: Re: [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq
>>
>>
>> 在 2022/11/3 9:28, Ye, MingjinX 写道:
>>>> -----Original Message-----
>>>> From: lihuisong (C) <lihuisong@huawei.com>
>>>> Sent: 2022年10月28日 10:09
>>>> To: Ye, MingjinX <mingjinx.ye@intel.com>; dev@dpdk.org
>>>> Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Singh,
>>>> Aman Deep <aman.deep.singh@intel.com>; Zhang, Yuying
>>>> <yuying.zhang@intel.com>
>>>> Subject: Re: [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq
>>>>
>>>>
>>>> 在 2022/10/27 19:02, Ye, MingjinX 写道:
>>>>> Hi lihuisong,
>>>>>
>>>>> This means that queue offloads need to update by recalling
>>>>> dev_configure and setup target queues.
>>>> Why not update queue offloads in PMD?
>>>>> Can you tell me, where is the limitation?
>>>> According to other Rx/Tx offload configurations, this may not be a
>> limitation.
>>>> But it seems to create a dependency on user usage.
>>>>
>>>> Port VLAN releated offloads are set by ethdev ops. There is no
>>>> requirement in ehedev layer that this port needs to stopped when set
>> these offloads.
>>>> Now it depends on user does recall dev_configure and setup queues to
>>>> update queue offloads because of setting these offloads.
>>>>> Thanks,
>>>>> Mingjin
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: lihuisong (C) <lihuisong@huawei.com>
>>>>>> Sent: 2022年10月26日 17:53
>>>>>> To: Ye, MingjinX <mingjinx.ye@intel.com>; dev@dpdk.org
>>>>>> Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Singh,
>>>>>> Aman Deep <aman.deep.singh@intel.com>; Zhang, Yuying
>>>>>> <yuying.zhang@intel.com>
>>>>>> Subject: Re: [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq
>>>>>>
>>>>>>
>>>>>> 在 2022/10/27 1:10, Mingjin Ye 写道:
>>>>>>> After setting vlan offload in testpmd, the result is not updated
>>>>>>> to rxq. Therefore, the queue needs to be reconfigured after
>>>>>>> executing the "vlan offload" related commands.
>>>>>>>
>>>>>>> Fixes: a47aa8b97afe ("app/testpmd: add vlan offload support")
>>>>>>> Cc: stable@dpdk.org
>>>>>>>
>>>>>>> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
>>>>>>> ---
>>>>>>> app/test-pmd/cmdline.c | 1 +
>>>>>>> 1 file changed, 1 insertion(+)
>>>>>>>
>>>>>>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
>>>>>>> 17be2de402..ce125f549f 100644
>>>>>>> --- a/app/test-pmd/cmdline.c
>>>>>>> +++ b/app/test-pmd/cmdline.c
>>>>>>> @@ -4133,6 +4133,7 @@ cmd_vlan_offload_parsed(void
>> *parsed_result,
>>>>>>> else
>>>>>>> vlan_extend_set(port_id, on);
>>>>>>>
>>>>>>> + cmd_reconfig_device_queue(port_id, 1, 1);
>>>> In addition, I have some comments:
>>>> 1) Normally, the parsed function of testpmd command needed to
>>>> re-config port and queue needs to check if port status is STOPED. Why
>>>> don't you add this check?
>>> The check is exist.
>> Where is the check? Currently, it seems that this check does not exist in the
>> this command parsed function.
> Check if the port is forwarded, in the source file test-pmd.c:2835.
I don't understand why you mention the check in start_port(). It should
be done in command parsed link other command.
>>>> If the check is not exist, queue offloads are not updated until the
>>>> next port stop/start command is executed. Right?
>>> yes
>>>> 2) Why is the queue-based VLAN offload API not used?
>>> VLAN offload is a port-related configuration. If a single port is
>>> changed, the associated queue needs to be all updated in
>>> configuration. Therefore, there will be no additional api to configure.
>>>> Like, rte_eth_dev_set_vlan_strip_on_queue. It seems that this
>>>> kind of API is
>>>> dedicated to do this.
>>>>>> This means that queue offloads need to upadte by re-calling
>>>>>> dev_configure and setup all queues, right?
>>>>>> If it is, this adds a usage limitation.
>>>>>>> return;
>>>>>>> }
>>>>>>>